mips64: remove empty mips_mips64_soft_reset_halt()
authorAntonio Borneo <borneo.antonio@gmail.com>
Sat, 10 Sep 2022 12:34:51 +0000 (14:34 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Tue, 13 Sep 2022 22:19:13 +0000 (22:19 +0000)
The method soft_reset_halt is optional; no need to add an
empty function.

Remove mips_mips64_soft_reset_halt() and move the TODO comment
in struct target_type.

Change-Id: Id541a75e7a08645568961d59b73a120c2238701f
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7184
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
src/target/mips_mips64.c

index 449f5a217aba6a43f00081fd3527abe44dca3dc5..d05b55c4621fd3969c49134b4956ce23cf2b01c3 100644 (file)
@@ -205,12 +205,6 @@ static int mips_mips64_deassert_reset(struct target *target)
        return ERROR_OK;
 }
 
-static int mips_mips64_soft_reset_halt(struct target *target)
-{
-       /* TODO */
-       return ERROR_OK;
-}
-
 static int mips_mips64_single_step_core(struct target *target)
 {
        struct mips64_common *mips64 = target->arch_info;
@@ -1168,7 +1162,7 @@ struct target_type mips_mips64_target = {
 
        .assert_reset = mips_mips64_assert_reset,
        .deassert_reset = mips_mips64_deassert_reset,
-       .soft_reset_halt = mips_mips64_soft_reset_halt,
+       /* TODO: add .soft_reset_halt */
 
        .get_gdb_reg_list = mips64_get_gdb_reg_list,