From cec3b6232811dc504ad461ad99384e39b40aad52 Mon Sep 17 00:00:00 2001 From: Antonio Borneo Date: Sat, 10 Sep 2022 14:34:51 +0200 Subject: [PATCH] mips64: remove empty mips_mips64_soft_reset_halt() The method soft_reset_halt is optional; no need to add an empty function. Remove mips_mips64_soft_reset_halt() and move the TODO comment in struct target_type. Change-Id: Id541a75e7a08645568961d59b73a120c2238701f Signed-off-by: Antonio Borneo Reviewed-on: https://review.openocd.org/c/openocd/+/7184 Tested-by: jenkins Reviewed-by: Tomas Vanek --- src/target/mips_mips64.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/target/mips_mips64.c b/src/target/mips_mips64.c index 449f5a217..d05b55c46 100644 --- a/src/target/mips_mips64.c +++ b/src/target/mips_mips64.c @@ -205,12 +205,6 @@ static int mips_mips64_deassert_reset(struct target *target) return ERROR_OK; } -static int mips_mips64_soft_reset_halt(struct target *target) -{ - /* TODO */ - return ERROR_OK; -} - static int mips_mips64_single_step_core(struct target *target) { struct mips64_common *mips64 = target->arch_info; @@ -1168,7 +1162,7 @@ struct target_type mips_mips64_target = { .assert_reset = mips_mips64_assert_reset, .deassert_reset = mips_mips64_deassert_reset, - .soft_reset_halt = mips_mips64_soft_reset_halt, + /* TODO: add .soft_reset_halt */ .get_gdb_reg_list = mips64_get_gdb_reg_list, -- 2.30.2