The FAT file system code wasn't cleaned up when the warning fixes were
done recently.
Signed-off-by: Keith Packard <keithp@keithp.com>
#if 0
#define DBG(...) printf(__VA_ARGS__)
#else
#if 0
#define DBG(...) printf(__VA_ARGS__)
#else
+#define DBG(...) (void) 0
#endif
static inline void
#endif
static inline void
sector_t sector;
cluster_offset_t offset;
uint8_t *buf;
sector_t sector;
cluster_offset_t offset;
uint8_t *buf;
cluster_t old_value;
uint8_t fat;
cluster_t old_value;
uint8_t fat;
DBG("current sector offset %d size %d\n",
file->offset, file->dirent->size);
DBG("current sector offset %d size %d\n",
file->offset, file->dirent->size);
- if (file->offset > file->dirent->size) {
+ if (file->offset > (offset_t) file->dirent->size) {
printf ("file offset %d larger than size %d\n",
file->offset, file->dirent->size);
return 0xffffffff;
printf ("file offset %d larger than size %d\n",
file->offset, file->dirent->size);
return 0xffffffff;
DBG("\treset to start of file %08x\n", file->cluster);
}
DBG("\treset to start of file %08x\n", file->cluster);
}
- if (file->cluster_offset + bytes_per_cluster <= file->offset) {
+ if ((offset_t) (file->cluster_offset + bytes_per_cluster) <= file->offset) {
cluster_t cluster_distance;
cluster_offset = sector_offset / sectors_per_cluster;
cluster_t cluster_distance;
cluster_offset = sector_offset / sectors_per_cluster;
if (!file->busy)
continue;
if (file->dirent == dirent) {
if (!file->busy)
continue;
if (file->dirent == dirent) {
- if (file->cluster_offset >= dirent->size) {
+ if (file->cluster_offset >= (offset_t) dirent->size) {
file->cluster_offset = 0;
file->cluster = dirent->cluster;
}
file->cluster_offset = 0;
file->cluster = dirent->cluster;
}
DBG ("\tfirst cluster %08x have %d need %d\n", first_cluster, have_clusters, need_clusters);
if (have_clusters != need_clusters) {
DBG ("\tfirst cluster %08x have %d need %d\n", first_cluster, have_clusters, need_clusters);
if (have_clusters != need_clusters) {
- if (file->cluster && size > file->cluster_offset) {
+ if (file->cluster && (offset_t) size > file->cluster_offset) {
cluster_t offset_clusters = (file->cluster_offset + bytes_per_cluster) / bytes_per_cluster;
cluster_t extra_clusters = need_clusters - offset_clusters;
cluster_t next_cluster;
cluster_t offset_clusters = (file->cluster_offset + bytes_per_cluster) / bytes_per_cluster;
cluster_t extra_clusters = need_clusters - offset_clusters;
cluster_t next_cluster;
static void
_ao_fat_root_init(uint8_t *dent, char name[11], uint8_t attr)
{
static void
_ao_fat_root_init(uint8_t *dent, char name[11], uint8_t attr)
{
memset(dent, '\0', 0x20);
memmove(dent, name, 11);
memset(dent, '\0', 0x20);
memmove(dent, name, 11);
- if (file->offset + len > file->dirent->size)
+ if (file->offset + len > (offset_t) file->dirent->size)
len = file->dirent->size - file->offset;
if (len < 0)
len = file->dirent->size - file->offset;
if (len < 0)
- if (file->offset + len > file->dirent->size) {
+ if (file->offset + len > (offset_t) file->dirent->size) {
ret = _ao_fat_set_size(file, file->offset + len);
if (ret < 0)
goto done;
ret = _ao_fat_set_size(file, file->offset + len);
if (ret < 0)
goto done;
int8_t
ao_fat_rename(char old[11], char new[11])
{
int8_t
ao_fat_rename(char old[11], char new[11])
{
+ (void) old;
+ (void) new;
putchar('.');
for (; i < 11; i++)
putchar(dirent.name[i]);
putchar('.');
for (; i < 11; i++)
putchar(dirent.name[i]);
- for (i = 0; i < NUM_FAT_ATTR; i++)
+ for (i = 0; i < (int) NUM_FAT_ATTR; i++)
putchar (dirent.attr & ao_fat_attr[i].bit ? ao_fat_attr[i].label : ' ');
printf (" @%08x %d\n", dirent.cluster, dirent.size);
}
putchar (dirent.attr & ao_fat_attr[i].bit ? ao_fat_attr[i].label : ' ');
printf (" @%08x %d\n", dirent.cluster, dirent.size);
}
printf ("readdir failed: %d\n", status);
}
printf ("readdir failed: %d\n", status);
}
ao_fat_parse_name(char name[11])
{
uint8_t c;
ao_fat_parse_name(char name[11])
{
uint8_t c;
{
static char name[11];
int8_t fd;
{
static char name[11];
int8_t fd;
- int cnt, i;
- static char buf[64];
#if SDCARD_TRACE
#define DBG(...) printf(__VA_ARGS__)
#else
#if SDCARD_TRACE
#define DBG(...) printf(__VA_ARGS__)
#else
+#define DBG(...) (void) 0
#endif
#if SDCARD_WARN
#define WARN(...) printf(__VA_ARGS__)
#else
#endif
#if SDCARD_WARN
#define WARN(...) printf(__VA_ARGS__)
#else
+#define WARN(...) (void) 0
#endif
#define later(x,y) ((int16_t) ((x) - (y)) >= 0)
#endif
#define later(x,y) ((int16_t) ((x) - (y)) >= 0)
{
uint8_t data[6];
uint8_t reply;
{
uint8_t data[6];
uint8_t reply;
uint16_t timeout;
DBG ("\tsend_cmd %d arg %08x\n", cmd, arg);
uint16_t timeout;
DBG ("\tsend_cmd %d arg %08x\n", cmd, arg);
return SDCARD_STATUS_TIMEOUT;
}
return SDCARD_STATUS_TIMEOUT;
}
- data[0] = cmd & 0x3f | 0x40;
+ data[0] = (cmd & 0x3f) | 0x40;
data[1] = arg >> 24;
data[2] = arg >> 16;
data[3] = arg >> 8;
data[1] = arg >> 24;
data[2] = arg >> 16;
data[3] = arg >> 8;
_ao_sdcard_reset(void)
{
int i;
_ao_sdcard_reset(void)
{
int i;
uint8_t response[10];
for (i = 0; i < SDCARD_IDLE_RETRY; i++) {
uint8_t response[10];
for (i = 0; i < SDCARD_IDLE_RETRY; i++) {
*/
if (ao_sdcard_send_if_cond(0x1aa, response) == SDCARD_STATUS_IDLE_STATE) {
uint32_t arg = 0;
*/
if (ao_sdcard_send_if_cond(0x1aa, response) == SDCARD_STATUS_IDLE_STATE) {
uint32_t arg = 0;
/* Check for SD version 2 */
if ((response[2] & 0xf) == 1 && response[3] == 0xaa) {
arg = 0x40000000;
/* Check for SD version 2 */
if ((response[2] & 0xf) == 1 && response[3] == 0xaa) {
arg = 0x40000000;
}
for (i = 0; i < SDCARD_IDLE_RETRY; i++) {
}
for (i = 0; i < SDCARD_IDLE_RETRY; i++) {
uint8_t
ao_sdcard_read_block(uint32_t block, uint8_t *data)
{
uint8_t
ao_sdcard_read_block(uint32_t block, uint8_t *data)
{
uint8_t start_block;
uint8_t crc[2];
int tries;
uint8_t start_block;
uint8_t crc[2];
int tries;
WARN ("read block command failed %d status %02x\n", block, ret);
status = _ao_sdcard_send_status();
WARN ("\tstatus now %04x\n", status);
WARN ("read block command failed %d status %02x\n", block, ret);
status = _ao_sdcard_send_status();
WARN ("\tstatus now %04x\n", status);
uint8_t response[1];
uint8_t start_block[8];
uint16_t status;
uint8_t response[1];
uint8_t start_block[8];
uint16_t status;
- static uint8_t check_data[512];
- int i;
int tries;
ao_sdcard_lock();
int tries;
ao_sdcard_lock();
if ((response[0] & SDCARD_DATA_RES_MASK) != SDCARD_DATA_RES_ACCEPTED) {
int i;
WARN("Data not accepted, response");
if ((response[0] & SDCARD_DATA_RES_MASK) != SDCARD_DATA_RES_ACCEPTED) {
int i;
WARN("Data not accepted, response");
- for (i = 0; i < sizeof (response); i++)
+ for (i = 0; i < (int) sizeof (response); i++)
WARN(" %02x", response[i]);
WARN("\n");
ret = 0x3f;
WARN(" %02x", response[i]);
WARN("\n");
ret = 0x3f;