src-avr: Disable USB interrupts while we're not interested
[fw/altos] / src-avr / ao_usb_avr.c
index ba9361eed33f454f8abdb71990a919c151312950..69a2dfa4ea3c0f7d994c03b136f5cb2582436b3f 100644 (file)
  */
 
 #include "ao.h"
+#include "ao_usb.h"
 
-struct ao_task __xdata ao_usb_task;
+#define USB_DEBUG 0
 
-static __xdata uint16_t        ao_usb_in_bytes;
-static __xdata uint16_t ao_usb_in_bytes_last;
-static __xdata uint16_t        ao_usb_out_bytes;
-static __xdata uint8_t ao_usb_iif;
-static __xdata uint8_t ao_usb_running;
+#if USB_DEBUG
+#define debug(format, args...) printf(format, ## args)
+#else
+#define debug(format, args...)
+#endif
 
-static void
-ao_usb_set_interrupts(void)
-{
-       /* IN interrupts on the control an IN endpoints */
-       USBIIE = (1 << AO_USB_CONTROL_EP) | (1 << AO_USB_IN_EP);
+struct ao_task __xdata ao_usb_task;
 
-       /* OUT interrupts on the OUT endpoint */
-       USBOIE = (1 << AO_USB_OUT_EP);
+struct ao_usb_setup {
+       uint8_t         dir_type_recip;
+       uint8_t         request;
+       uint16_t        value;
+       uint16_t        index;
+       uint16_t        length;
+} __xdata ao_usb_setup;
 
-       /* Only care about reset */
-       USBCIE = USBCIE_RSTIE;
-}
+static __xdata uint8_t         ao_usb_ep0_state;
+static const uint8_t * __xdata ao_usb_ep0_in_data;
+static __xdata uint8_t         ao_usb_ep0_in_len;
+static __xdata uint8_t ao_usb_ep0_in_pending;
+static __xdata uint8_t ao_usb_addr_pending;
+static __xdata uint8_t ao_usb_ep0_in_buf[2];
+static __xdata uint8_t         ao_usb_ep0_out_len;
+static __xdata uint8_t *__xdata ao_usb_ep0_out_data;
+
+static __xdata uint8_t ao_usb_in_flushed;
+static __xdata uint8_t ao_usb_running;
+static __xdata uint8_t ao_usb_configuration;
 
 void
 ao_usb_set_address(uint8_t address)
 {
-       UDADD = (0 << ADDEN) | address;
-       ao_usb_running = 1;
+       UDADDR = (0 << ADDEN) | address;
+       ao_usb_addr_pending = 1;
 }
 
 #define EP_SIZE(s)     ((s) == 64 ? 0x30 :     \
@@ -50,9 +61,18 @@ ao_usb_set_address(uint8_t address)
                        ((s) == 16 ? 0x10 :     \
                                     0x00)))
 
+static void
+ao_usb_dump_ep(uint8_t ep)
+{
+       UENUM = ep;
+       debug ("EP %d: UECONX %02x UECFG0X %02x UECFG1X %02x UEIENX %02x UESTA0X %02x UESTA1X %02X\n",
+               ep, UECONX, UECFG0X, UECFG1X, UEIENX, UESTA0X, UESTA1X);
+}
+
 static void
 ao_usb_set_ep0(void)
 {
+       debug ("set_ep0\n");
        /* Set the CONTROL max packet size, single buffered */
        UENUM = 0;
        UECONX = (1 << EPEN);                                   /* Enable */
@@ -60,12 +80,15 @@ ao_usb_set_ep0(void)
        UECFG0X = ((0 << EPTYPE0) |                             /* Control */
                   (0 << EPDIR));                               /* Out (ish) */
 
-       UECFG1X = ((EP_SIZE(AO_USB_CONTROL_SIZE) << EPSIZE0) |  /* Size */
-                  (0 << EPBK));                                /* Single bank */
+       UECFG1X = (EP_SIZE(AO_USB_CONTROL_SIZE) |               /* Size */
+                  (0 << EPBK0) |                               /* Single bank */
+                  (1 << ALLOC));
 
-       UEIENX = ((1 << RXSTPE) |       /* Enable SETUP interrupt */
-                 (1 << RXOUTE) |       /* Enable OUT interrupt */
-                 (1 << TXINE));        /* Enable IN complete interrupt */
+       UEIENX = ((1 << RXSTPE) |                               /* Enable SETUP interrupt */
+                 (1 << RXOUTE));                               /* Enable OUT interrupt */
+
+//     ao_usb_dump_ep(0);
+       ao_usb_addr_pending = 0;
 }
 
 static void
@@ -78,10 +101,16 @@ ao_usb_set_configuration(void)
        UECFG0X = ((2 << EPTYPE0) |                             /* Bulk */
                   (1 << EPDIR));                               /* In */
 
-       UECFG1X = ((EP_SIZE(AO_USB_IN_SIZE) << EPSIZE0) |       /* Size */
-                  (1 << EPBK) |                                /* Double bank */
+       UECFG1X = (EP_SIZE(AO_USB_IN_SIZE) |                    /* Size */
+                  (1 << EPBK0) |                               /* Double bank */
                   (1 << ALLOC));                               /* Allocate */
 
+#if 0
+       UEIENX = ((1 << TXINE));                                /* Enable IN complete interrupt */
+#endif
+
+       ao_usb_dump_ep(AO_USB_IN_EP);
+
        /* Set the OUT max packet size, double buffered */
        UENUM = AO_USB_OUT_EP;
        UECONX |= (1 << EPEN);                                  /* Enable */
@@ -89,74 +118,21 @@ ao_usb_set_configuration(void)
        UECFG0X = ((2 << EPTYPE0) |                             /* Bulk */
                   (0 << EPDIR));                               /* Out */
 
-       UECFG1X = ((EP_SIZE(AO_USB_OUT_SIZE) << EPSIZE0) |      /* Size */
-                  (1 << EPBK) |                                /* Double bank */
+       UECFG1X = (EP_SIZE(AO_USB_OUT_SIZE) |                   /* Size */
+                  (1 << EPBK0) |                               /* Double bank */
                   (1 << ALLOC));                               /* Allocate */
+
+       UEIENX = ((1 << RXOUTE));                               /* Enable OUT complete interrupt */
+
+       ao_usb_dump_ep(AO_USB_OUT_EP);
+       ao_usb_running = 1;
 }
 
 ISR(USB_GEN_vect)
 {
-       uint8_t intbits;
-
-        intbits = UDINT;
-        UDINT = 0;
-        if (intbits & (1<<EORSTI)) {
-               ao_usb_set_ep0();
-               usb_configuration = 0;
-        }
-       if (intbits & (1<<SOFI)) {
-               if (usb_configuration) {
-                       t = transmit_flush_timer;
-                       if (t) {
-                               transmit_flush_timer = --t;
-                               if (!t) {
-                                       UENUM = CDC_TX_ENDPOINT;
-                                       UEINTX = 0x3A;
-                               }
-                       }
-               }
-       }
+       ao_wakeup(&ao_usb_task);
 }
 
-struct ao_usb_setup {
-       uint8_t         dir_type_recip;
-       uint8_t         request;
-       uint16_t        value;
-       uint16_t        index;
-       uint16_t        length;
-} __xdata ao_usb_setup;
-
-__xdata uint8_t ao_usb_ep0_state;
-uint8_t * __xdata ao_usb_ep0_in_data;
-__xdata uint8_t ao_usb_ep0_in_len;
-__xdata uint8_t        ao_usb_ep0_in_buf[2];
-__xdata uint8_t ao_usb_ep0_out_len;
-__xdata uint8_t *__xdata ao_usb_ep0_out_data;
-__xdata uint8_t ao_usb_configuration;
-
-/* Send an IN data packet */
-static void
-ao_usb_ep0_flush(void)
-{
-       __xdata uint8_t this_len;
-       __xdata uint8_t cs0;
-
-       /* If the IN packet hasn't been picked up, just return */
-       UENUM = 0;
-       if (!(UEINTX & (1 << TXINI)))
-               return;
-
-       this_len = ao_usb_ep0_in_len;
-       if (this_len > AO_USB_CONTROL_SIZE)
-               this_len = AO_USB_CONTROL_SIZE;
-
-       ao_usb_ep0_in_len -= this_len;
-       while (this_len--)
-               UEDATX = *ao_usb_ep0_in_data++;
-
-       /* Clear the TXINI bit to send the packet */
-       UEINTX &= ~(1 << TXINI);
-}
 
 __xdata static struct ao_usb_line_coding ao_usb_line_coding = {115200, 0, 0, 8};
 
@@ -183,22 +159,77 @@ ao_usb_get_descriptor(uint16_t value)
        }
 }
 
-/* Read data from the ep0 OUT fifo
- */
 static void
-ao_usb_ep0_fill(void)
+ao_usb_ep0_set_in_pending(uint8_t in_pending)
+{
+       ao_usb_ep0_in_pending = in_pending;
+
+       if (in_pending) {
+               UENUM = 0;
+               UEIENX = ((1 << RXSTPE) | (1 << RXOUTE) | (1 << TXINE));        /* Enable IN interrupt */
+       }
+}
+
+/* Send an IN data packet */
+static void
+ao_usb_ep0_flush(void)
 {
-       __xdata uint8_t len;
+       __xdata uint8_t this_len;
 
+       cli();
        UENUM = 0;
-       len = UEBCLX;   /* read length */
+       if (!(UEINTX & (1 << TXINI))) {
+               debug("EP0 not accepting IN data\n");
+               ao_usb_ep0_set_in_pending(1);
+       } else {
+               this_len = ao_usb_ep0_in_len;
+               if (this_len > AO_USB_CONTROL_SIZE)
+                       this_len = AO_USB_CONTROL_SIZE;
+
+               ao_usb_ep0_in_len -= this_len;
+
+               /* Set IN interrupt enable */
+               if (ao_usb_ep0_in_len == 0 && this_len != AO_USB_CONTROL_SIZE)
+                       ao_usb_ep0_set_in_pending(0);
+               else
+                       ao_usb_ep0_set_in_pending(1);
+
+               debug ("Flush EP0 len %d:", this_len);
+               while (this_len--) {
+                       uint8_t c = *ao_usb_ep0_in_data++;
+                       debug(" %02x", c);
+                       UEDATX = c;
+               }
+               debug ("\n");
+
+               /* Clear the TXINI bit to send the packet */
+               UEINTX &= ~(1 << TXINI);
+       }
+       sei();
+}
+
+/* Read data from the ep0 OUT fifo */
+static void
+ao_usb_ep0_fill(uint8_t len, uint8_t ack)
+{
        if (len > ao_usb_ep0_out_len)
                len = ao_usb_ep0_out_len;
        ao_usb_ep0_out_len -= len;
 
+//     debug ("EP0 UEINTX %02x UEBCLX %d UEBCHX %d\n",
+//             UEINTX, UEBCLX, UEBCHX);
        /* Pull all of the data out of the packet */
-       while (len--)
-               *ao_usb_ep0_out_data++ = UEDATX;
+       debug ("Fill EP0 len %d:", len);
+       UENUM = 0;
+       while (len--) {
+               uint8_t c = UEDATX;
+               *ao_usb_ep0_out_data++ = c;
+               debug (" %02x", c);
+       }
+       debug ("\n");
+
+       /* ACK the packet */
+       UEINTX &= ~ack;
 }
 
 void
@@ -213,11 +244,11 @@ ao_usb_ep0_setup(void)
        /* Pull the setup packet out of the fifo */
        ao_usb_ep0_out_data = (__xdata uint8_t *) &ao_usb_setup;
        ao_usb_ep0_out_len = 8;
-       ao_usb_ep0_fill();
-       UENUM = 0;
-       UEINTX &= ~(1 << RXSTPI);
-       if (ao_usb_ep0_out_len != 0)
+       ao_usb_ep0_fill(8, (1 << RXSTPI) | (1 << RXOUTI) | (1 << TXINI));
+       if (ao_usb_ep0_out_len != 0) {
+               debug ("invalid setup packet length\n");
                return;
+       }
 
        /* Figure out how to ACK the setup packet */
        if (ao_usb_setup.dir_type_recip & AO_USB_DIR_IN) {
@@ -231,8 +262,8 @@ ao_usb_ep0_setup(void)
                else
                        ao_usb_ep0_state = AO_USB_EP0_IDLE;
        }
-       UENUM = 0;
 /*
+       UENUM = 0;
        if (ao_usb_ep0_state == AO_USB_EP0_IDLE)
                USBCS0 = USBCS0_CLR_OUTPKT_RDY | USBCS0_DATA_END;
        else
@@ -243,30 +274,40 @@ ao_usb_ep0_setup(void)
        ao_usb_ep0_in_len = 0;
        switch(ao_usb_setup.dir_type_recip & AO_USB_SETUP_TYPE_MASK) {
        case AO_USB_TYPE_STANDARD:
+               debug ("Standard setup packet\n");
                switch(ao_usb_setup.dir_type_recip & AO_USB_SETUP_RECIP_MASK) {
                case AO_USB_RECIP_DEVICE:
+                       debug ("Device setup packet\n");
                        switch(ao_usb_setup.request) {
                        case AO_USB_REQ_GET_STATUS:
+                               debug ("get status\n");
                                ao_usb_ep0_queue_byte(0);
                                ao_usb_ep0_queue_byte(0);
                                break;
                        case AO_USB_REQ_SET_ADDRESS:
+                               debug ("set address %d\n", ao_usb_setup.value);
                                ao_usb_set_address(ao_usb_setup.value);
                                break;
                        case AO_USB_REQ_GET_DESCRIPTOR:
+                               debug ("get descriptor %d\n", ao_usb_setup.value);
                                ao_usb_get_descriptor(ao_usb_setup.value);
                                break;
                        case AO_USB_REQ_GET_CONFIGURATION:
+                               debug ("get configuration %d\n", ao_usb_configuration);
                                ao_usb_ep0_queue_byte(ao_usb_configuration);
                                break;
                        case AO_USB_REQ_SET_CONFIGURATION:
                                ao_usb_configuration = ao_usb_setup.value;
+                               debug ("set configuration %d\n", ao_usb_configuration);
                                ao_usb_set_configuration();
                                break;
                        }
                        break;
                case AO_USB_RECIP_INTERFACE:
+#ifndef AVR
                        #pragma disable_warning 110
+#endif
+                       debug ("Interface setup packet\n");
                        switch(ao_usb_setup.request) {
                        case AO_USB_REQ_GET_STATUS:
                                ao_usb_ep0_queue_byte(0);
@@ -280,6 +321,7 @@ ao_usb_ep0_setup(void)
                        }
                        break;
                case AO_USB_RECIP_ENDPOINT:
+                       debug ("Endpoint setup packet\n");
                        switch(ao_usb_setup.request) {
                        case AO_USB_REQ_GET_STATUS:
                                ao_usb_ep0_queue_byte(0);
@@ -290,12 +332,15 @@ ao_usb_ep0_setup(void)
                }
                break;
        case AO_USB_TYPE_CLASS:
+               debug ("Class setup packet\n");
                switch (ao_usb_setup.request) {
                case SET_LINE_CODING:
+                       debug ("set line coding\n");
                        ao_usb_ep0_out_len = 7;
                        ao_usb_ep0_out_data = (__xdata uint8_t *) &ao_usb_line_coding;
                        break;
                case GET_LINE_CODING:
+                       debug ("get line coding\n");
                        ao_usb_ep0_in_len = 7;
                        ao_usb_ep0_in_data = (uint8_t *) &ao_usb_line_coding;
                        break;
@@ -307,7 +352,8 @@ ao_usb_ep0_setup(void)
        if (ao_usb_ep0_state != AO_USB_EP0_DATA_OUT) {
                if (ao_usb_setup.length < ao_usb_ep0_in_len)
                        ao_usb_ep0_in_len = ao_usb_setup.length;
-               ao_usb_ep0_flush();
+               debug ("Start ep0 in delivery %d\n", ao_usb_ep0_in_len);
+               ao_usb_ep0_set_in_pending(1);
        }
 }
 
@@ -315,28 +361,52 @@ ao_usb_ep0_setup(void)
 static void
 ao_usb_ep0(void)
 {
-       __xdata uint8_t intx;
+       uint8_t intx, udint;
 
+       debug ("usb task started\n");
        ao_usb_ep0_state = AO_USB_EP0_IDLE;
        for (;;) {
                cli();
                for (;;) {
+                       udint = UDINT;
+                       UDINT = 0;
+//                     debug ("UDINT %02x\n", udint);
+                       if (udint & (1 << EORSTI)) {
+                               ao_usb_configuration = 0;
+                               ao_usb_set_ep0();
+                       }
                        UENUM = 0;
                        intx = UEINTX;
-                       if (intx & ((1 << RXOUTI) | (1 <<RXSTPI)))
-                           break;
+//                     debug ("UEINTX %02x\n", intx);
+                       if (intx & ((1 << RXSTPI) | (1 << RXOUTI)))
+                               break;
+                       if ((intx & (1 << TXINI))) {
+                               if (ao_usb_ep0_in_pending)
+                                       break;
+                               else
+                               {
+                                       if (ao_usb_addr_pending) {
+                                               UDADDR |= (1 << ADDEN);
+                                               ao_usb_addr_pending = 0;
+                                       }
+                                       UEIENX = ((1 << RXSTPE) | (1 << RXOUTE));       /* Disable IN interrupt */
+                               }
+                       }
+//                     debug ("usb task sleeping...\n");
                        ao_sleep(&ao_usb_task);
                }
                sei();
+//             debug ("UEINTX for ep0 is %02x\n", intx);
                if (intx & (1 << RXSTPI)) {
                        ao_usb_ep0_setup();
-                       UENUM = 0;
-                       UEINTX &= ~(1 << RXSTPI);
                }
                if (intx & (1 << RXOUTI)) {
-                       ao_usb_ep0_fill();
-                       UENUM = 0;
-                       UEINTX &= ~(1 << RXOUTI);
+                       ao_usb_ep0_fill(UEBCLX, (1 << RXOUTI));
+                       ao_usb_ep0_set_in_pending(1);
+               }
+               if (intx & (1 << TXINI) && ao_usb_ep0_in_pending) {
+                       debug ("continue sending ep0 IN data\n");
+                       ao_usb_ep0_flush();
                }
        }
 }
@@ -346,23 +416,49 @@ static void
 ao_usb_in_wait(void)
 {
        for (;;) {
+               /* Check if the current buffer is writable */
                UENUM = AO_USB_IN_EP;
-               if ((UEINTX & (1 << RWAL)))
+               if (UEINTX & (1 << RWAL))
                        break;
-               ao_sleep(&ao_usb_in_bytes);
+
+               cli();
+               /* Wait for an IN buffer to be ready */
+               for (;;) {
+                       UENUM = AO_USB_IN_EP;
+                       if ((UEINTX & (1 << TXINI)))
+                               break;
+                       UEIENX = (1 << TXINE);
+                       ao_sleep(&ao_usb_in_flushed);
+               }
+               /* Ack the interrupt */
+               UEINTX &= ~(1 << TXINI);
+               sei();
        }
 }
 
+/* Queue the current IN buffer for transmission */
+static void
+ao_usb_in_send(void)
+{
+       UENUM = AO_USB_IN_EP;
+       UEINTX &= ~(1 << FIFOCON);
+}
+
 void
 ao_usb_flush(void) __critical
 {
        if (!ao_usb_running)
                return;
 
-       /* If there are pending bytes, or if the last packet was full,
-        * send another IN packet
+       /* Anytime we've sent a character since
+        * the last time we flushed, we'll need
+        * to send a packet -- the only other time
+        * we would send a packet is when that
+        * packet was full, in which case we now
+        * want to send an empty packet
         */
-       if (ao_usb_in_bytes || (ao_usb_in_bytes_last == AO_USB_IN_SIZE)) {
+       if (!ao_usb_in_flushed) {
+               ao_usb_in_flushed = 1;
                ao_usb_in_wait();
                ao_usb_in_send();
        }
@@ -376,78 +472,116 @@ ao_usb_putchar(char c) __critical __reentrant
 
        ao_usb_in_wait();
 
-       /* Queue a byte, sending the packet when full */
+       /* Queue a byte */
        UENUM = AO_USB_IN_EP;
        UEDATX = c;
-       if (++ao_usb_in_bytes == AO_USB_IN_SIZE)
+
+       /* Send the packet when full */
+       if ((UEINTX & (1 << RWAL)) == 0)
                ao_usb_in_send();
+       ao_usb_in_flushed = 0;
 }
 
-char
-ao_usb_pollchar(void) __critical
+static char
+_ao_usb_pollchar(void)
 {
        char c;
-       if (ao_usb_out_bytes == 0) {
-               /* Check to see if a packet has arrived */
+       uint8_t intx;
+
+       if (!ao_usb_running)
+               return AO_READ_AGAIN;
+
+       for (;;) {
                UENUM = AO_USB_OUT_EP;
-               if ((UEINTX & (1 << RXOUTI)) == 0)
-                       return AO_READ_AGAIN;
-               ao_usb_out_bytes = (UEBCHX << 8) | UEBCLX;
-               if (ao_usb_out_bytes == 0) {
-                       UEINTX &= ~(1 << RXOUTI);
+               intx = UEINTX;
+               debug("usb_pollchar UEINTX %02d\n", intx);
+               if (intx & (1 << RWAL))
+                       break;
+
+               if (intx & (1 << FIFOCON)) {
+                       /* Ack the last packet */
+                       UEINTX = (uint8_t) ~(1 << FIFOCON);
+               }
+
+               /* Check to see if a packet has arrived */
+               if ((intx & (1 << RXOUTI)) == 0) {
+                       UENUM = AO_USB_OUT_EP;
+                       UEIENX = (1 << RXOUTE);
                        return AO_READ_AGAIN;
                }
+
+               /* Ack the interrupt */
+               UEINTX = ~(1 << RXOUTI);
        }
-       --ao_usb_out_bytes;
-       UENUM = AO_USB_OUT_EP;
+
+       /* Pull a character out of the fifo */
        c = UEDATX;
-       if (ao_usb_out_bytes == 0) {
-               UENUM = AO_USB_OUT_EP;
-               UEINTX &= ~(1 << RXOUTI);
-       }
        return c;
 }
 
 char
-ao_usb_getchar(void) __critical
+ao_usb_pollchar(void)
 {
        char    c;
-
-       while ((c = ao_usb_pollchar()) == AO_READ_AGAIN)
-               ao_sleep(&ao_stdin_ready);
+       cli();
+       c = _ao_usb_pollchar();
+       sei();
        return c;
 }
 
-// Misc functions to wait for ready and send/receive packets
-static inline void usb_wait_in_ready(void)
-{
-       while (!(UEINTX & (1<<TXINI))) ;
-}
-static inline void usb_send_in(void)
-{
-       UEINTX = ~(1<<TXINI);
-}
-static inline void usb_wait_receive_out(void)
-{
-       while (!(UEINTX & (1<<RXOUTI))) ;
-}
-static inline void usb_ack_out(void)
+char
+ao_usb_getchar(void) __critical
 {
-       UEINTX = ~(1<<RXOUTI);
+       char    c;
+
+       cli();
+       while ((c = _ao_usb_pollchar()) == AO_READ_AGAIN)
+               ao_sleep(&ao_stdin_ready);
+       sei();
+       return c;
 }
 
-/* Endpoint 0 interrupt */
+uint16_t       control_count;
+uint16_t       in_count;
+uint16_t       out_count;
 
+/* Endpoint interrupt */
 ISR(USB_COM_vect)
 {
-       ao_wakeup(&ao_usb_task);
+       uint8_t old_num = UENUM;
+       uint8_t i = UEINT;
+
+#ifdef AO_LED_RED
+       ao_led_toggle(AO_LED_RED);
+#endif
+       UEINT = 0;
+       if (i & (1 << 0)) {
+               ao_wakeup(&ao_usb_task);
+               ++control_count;
+       }
+       if (i & (1 << AO_USB_IN_EP)) {
+               UENUM = AO_USB_IN_EP;
+               UEIENX = 0;
+               ao_wakeup(&ao_usb_in_flushed);
+               in_count++;
+       }
+       if (i & (1 << AO_USB_OUT_EP)) {
+               UENUM = AO_USB_OUT_EP;
+               UEIENX = 0;
+               ao_wakeup(&ao_stdin_ready);
+               ++out_count;
+       }
+       UENUM = old_num;
 }
 
 #if AVR_VCC_5V
 #define AO_PAD_REGULATOR_INIT  (1 << UVREGE)   /* Turn on pad regulator */
 #endif
 #if AVR_VCC_3V3
-#define AO_PAD_REGULATOR_INIT  0               /* Turn off pad regulator */
+/* TeleScience V0.1 has a hardware bug -- UVcc is hooked up, but UCap is not
+ * Make this work by running power through UVcc to the USB system
+ */
+#define AO_PAD_REGULATOR_INIT  (1 << UVREGE)   /* Turn off pad regulator */
 #endif
 
 #if AVR_CLOCK == 16000000UL
@@ -462,7 +596,6 @@ ao_usb_disable(void)
 {
        /* Unplug from the bus */
        UDCON = (1 << DETACH);
-       ao_usb_detatch_interface();
 
        /* Disable the interface */
        USBCON = 0;
@@ -497,16 +630,54 @@ ao_usb_enable(void)
        /* Enable USB, enable the VBUS pad */
        USBCON = AO_USB_CON | (1 << OTGPADE);
 
+       /* Enable global interrupts */
+       UDIEN = (1 << EORSTE);          /* End of reset interrupt */
+
+       ao_usb_configuration = 0;
+
+       debug ("ao_usb_enable\n");
+
+       debug ("UHWCON %02x USBCON %02x PLLCSR %02x UDIEN %02x\n",
+              UHWCON, USBCON, PLLCSR, UDIEN);
        UDCON = (0 << DETACH);  /* Clear the DETACH bit to plug into the bus */
+}
+
+#if USB_DEBUG
+struct ao_task __xdata ao_usb_echo_task;
+
+static void
+ao_usb_echo(void)
+{
+       char    c;
+
+       for (;;) {
+               c = ao_usb_getchar();
+               ao_usb_putchar(c);
+               ao_usb_flush();
+       }
+}
+#endif
 
-       usb_configuration = 0;
+static void
+ao_usb_irq(void)
+{
+       printf ("control: %d out: %d in: %d\n",
+               control_count, out_count, in_count);
 }
 
+__code struct ao_cmds ao_usb_cmds[] = {
+       { ao_usb_irq, "i\0Show USB interrupt counts" },
+       { 0, NULL }
+};
+
 void
 ao_usb_init(void)
 {
        ao_usb_enable();
 
+       debug ("ao_usb_init\n");
        ao_add_task(&ao_usb_task, ao_usb_ep0, "usb");
+//     ao_add_task(&ao_usb_echo_task, ao_usb_echo, "usb echo");
+       ao_cmd_register(&ao_usb_cmds[0]);
        ao_add_stdio(ao_usb_pollchar, ao_usb_putchar, ao_usb_flush);
 }