Remove duplicate endianness

diff --git a/src/stlink-common.c b/src/stlink-common.c
index 53a9d291f59e81c641b16d8537f0e858697c71c2..7f51a56902a526f85a4ef6423c0eecb66db7b075 100644 (file)
--- a/src/stlink-common.c
+++ b/src/stlink-common.c
@@ -108,7 +108,7 @@ void stlink_write_mem8(stlink_t *sl, uint32_t addr, uint16_t len) {
 // const int i = 1;
 // #define is_bigendian() ( (*(char*)&i) == 0 )
 
-static inline unsigned int is_bigendian(void) {
+inline unsigned int is_bigendian(void) {
     static volatile const unsigned int i = 1;
     return *(volatile const char*) &i == 0;
 }

diff --git a/src/stlink-common.h b/src/stlink-common.h
index 7fbc0ab013157d6c4b2ae0e233b70b3d253de2fb..32ea444523648a254ca65d2ee8f1d1d7be805556 100644 (file)
--- a/src/stlink-common.h
+++ b/src/stlink-common.h
@@ -175,6 +175,7 @@ extern "C" {
     uint16_t read_uint16(const unsigned char *c, const int pt);
     void stlink_core_stat(stlink_t *sl);
     void stlink_print_data(stlink_t *sl);
+    unsigned int is_bigendian(void);
 
 
 #include "stlink-sg.h"

diff --git a/src/stlink-usb.c b/src/stlink-usb.c
index d989633bf056e2e38fcedc62dfcf49a312236518..4a2fe16bfd946d398ef9c983d4be316ab3b6b2ba 100644 (file)
--- a/src/stlink-usb.c
+++ b/src/stlink-usb.c
@@ -8,12 +8,6 @@
 #include "stlink-common.h"
 #include "stlink-usb.h"
 
-/* endianess related */
-static inline unsigned int is_bigendian(void) {
-    static volatile const unsigned int i = 1;
-    return *(volatile const char*) &i == 0;
-}
-
 void _stlink_usb_close(stlink_t* sl) {
     struct stlink_libusb * const handle = sl->backend_data;
     // maybe we couldn't even get the usb device?
@@ -206,7 +200,7 @@ void _stlink_usb_version(stlink_t * sl) {
     if (size == -1) {
         printf("[!] send_recv\n");
         return;
-    }mkdir g
+    }
 
 #if 1 /* DEBUG */
     {
@@ -218,15 +212,16 @@ void _stlink_usb_version(stlink_t * sl) {
 }
 
 void _stlink_usb_write_mem32(stlink_t *sl, uint32_t addr, uint16_t len) {
-    D(sl, "oops! no write32 support yet ;)\n");
+    DD(sl, "oops! no write32 support yet, wanted to write %d bytes to %#x\n",
+            len, addr);
 }
 
 void _stlink_usb_write_mem8(stlink_t *sl, uint32_t addr, uint16_t len) {
-    D(sl, "oops! no write8 support yet ;)\n");
+    DD(sl, "oops! no write8 support yet, wanted to write %d bytes to %#x\n",
+            len, addr);
 }
 
 
-
 int stlink_current_mode(stlink_t * sl) {
     int mode = -1;