target/riscv: fix unused initialization
authorAntonio Borneo <borneo.antonio@gmail.com>
Mon, 19 Sep 2022 12:55:55 +0000 (14:55 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Fri, 23 Sep 2022 21:24:34 +0000 (21:24 +0000)
Scan-build reports:
Unused code: Dead assignment
riscv.c:716 Value stored to 'result' is never read

Remove the initialization of variable 'result'.

Change-Id: Ied67bb4fcfa5bace186522074247ead43a5d5cd5
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7207
Reviewed-by: Tim Newsome <tim@sifive.com>
Reviewed-by: Jan Matyas <matyas@codasip.com>
Tested-by: jenkins
src/target/riscv/riscv.c

index dde3d7e696ef2e95e4578847c8df2ef6a552776c..c25efcde9a0d8cfbfe3004633dbfdc8be627de58 100644 (file)
@@ -713,7 +713,6 @@ static int add_trigger(struct target *target, struct trigger *trigger)
                        return result;
                int type = get_field(tdata1, MCONTROL_TYPE(riscv_xlen(target)));
 
-               result = ERROR_OK;
                switch (type) {
                        case 1:
                                result = maybe_add_trigger_t1(target, trigger, tdata1);