target: Remove error messages as no .get_gdb_fileio_info
authorHsiangkai Wang <hsiangkai@gmail.com>
Wed, 28 Aug 2013 02:59:29 +0000 (10:59 +0800)
committerSpencer Oliver <spen@spen-soft.co.uk>
Thu, 29 Aug 2013 08:01:26 +0000 (08:01 +0000)
If target does not support semi-hosting function, it has
no need to provide .get_gdb_fileio_info callback. OpenOCD
will use default function target_get_gdb_fileio_info_default.
The default function just return ERROR_FAIL and gdb_server
will treat every halted condition as normal halted and
return "Txx" to gdb.

Change-Id: I9ddb2be3a1145eae2ef5b712bdea89eb2e0fbc20
Signed-off-by: Hsiangkai Wang <hsiangkai@gmail.com>
Reviewed-on: http://openocd.zylin.com/1586
Tested-by: jenkins
Reviewed-by: Nemui Trinomius <nemuisan_kawausogasuki@live.jp>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/target/target.c

index e4235ed26ab5d2e4c52f55e488826be24a52b519..29a011cea13756efd635fe822c1a298c41a6a45e 100644 (file)
@@ -1734,14 +1734,16 @@ int target_arch_state(struct target *target)
 static int target_get_gdb_fileio_info_default(struct target *target,
                struct gdb_fileio_info *fileio_info)
 {
-       LOG_ERROR("Not implemented: %s", __func__);
+       /* If target does not support semi-hosting function, target
+          has no need to provide .get_gdb_fileio_info callback.
+          It just return ERROR_FAIL and gdb_server will return "Txx"
+          as target halted every time.  */
        return ERROR_FAIL;
 }
 
 static int target_gdb_fileio_end_default(struct target *target,
                int retcode, int fileio_errno, bool ctrl_c)
 {
-       LOG_ERROR("Not implemented: %s", __func__);
        return ERROR_OK;
 }