jtag/drivers/ulink: fix clang static analyzer warning
authorTomas Vanek <vanekt@fbl.cz>
Fri, 20 Dec 2019 22:34:19 +0000 (23:34 +0100)
committerOleksij Rempel <linux@rempel-privat.de>
Mon, 20 Apr 2020 17:25:53 +0000 (18:25 +0100)
scan-build-9:
Description: Potential leak of memory pointed to by 'tdo_buffer'
File: src/jtag/drivers/ulink.c
Line: 1629

Free the buffer before error return.

Change-Id: Ic47651a5ae78c7a47ae4fcbad225f329b14c45cb
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/5519
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-by: Oleksij Rempel <linux@rempel-privat.de>
src/jtag/drivers/ulink.c

index 77fbe61933b6d9dd21c20bcb36cbbc6165b93c53..9235eb8935829c1add5c62adce7face83dbafd2d 100644 (file)
@@ -1627,6 +1627,7 @@ int ulink_queue_scan(struct ulink *device, struct jtag_command *cmd)
 
                if (ret != ERROR_OK) {
                        free(tdi_buffer_start);
+                       free(tdo_buffer_start);
                        return ret;
                }
        }