NULL check before dereferencing
authorLuca BRUNO <lucab@debian.org>
Thu, 22 Aug 2013 14:22:31 +0000 (16:22 +0200)
committerAndreas Fritiofson <andreas.fritiofson@gmail.com>
Sun, 1 Dec 2013 12:44:09 +0000 (12:44 +0000)
Check reg_list[i]->feature for NULL pointers before checking feature->name
in order to avoid NULL access.

Change-Id: If20401a6c5aa5e1e29f0fcf9bb95585b49658832
Signed-off-by: Luca BRUNO <lucab@debian.org>
Reviewed-on: http://openocd.zylin.com/1809
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
Reviewed-by: Jens Bauer <jens@gpio.dk>
src/server/gdb_server.c

index c49f87c1ca6da1309a7a63db97663676e0ef08b8..c578780c8d374cc865c3d2de90a7d2dc95894682 100644 (file)
@@ -1988,7 +1988,8 @@ static int get_reg_features_list(struct target *target, char **feature_list[], i
                if (reg_list[i]->exist == false)
                        continue;
 
-               if ((reg_list[i]->feature->name != NULL)
+               if (reg_list[i]->feature != NULL
+                       && reg_list[i]->feature->name != NULL
                        && (strcmp(reg_list[i]->feature->name, ""))) {
                        /* We found a feature, check if the feature is already in the
                         * table. If not, allocate a new entry for the table and