target: esp_xtensa_smp: fix clang report
authorAntonio Borneo <borneo.antonio@gmail.com>
Sat, 25 Jun 2022 10:40:24 +0000 (12:40 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 2 Jul 2022 08:27:31 +0000 (08:27 +0000)
The variable 'smp_break' is only set and used in case of smp.
But clang cannot track if 'target->smp' get modified between the
set and the use of 'smp_break', so it consider possible to use
'smp_break' uninitialized.

Initialize 'smp_break' to silent clang.

Change-Id: Ifa25a84fe9ffa25b8b58d7920ec77994c3b7ebfe
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Fixes: 77287b8d47b4 ("target: add Espressif ESP32 basic support")
Reviewed-on: https://review.openocd.org/c/openocd/+/7050
Reviewed-by: Erhan Kurubas <erhan.kurubas@espressif.com>
Tested-by: jenkins
src/target/espressif/esp_xtensa_smp.c

index 1c36a295a946ae1d3805d4e7c5364209d3459b69..d51906befd032e5ae35bf225bcf256fe81a8e0de 100644 (file)
@@ -386,7 +386,7 @@ int esp_xtensa_smp_step(struct target *target,
        int handle_breakpoints)
 {
        int res;
-       uint32_t smp_break;
+       uint32_t smp_break = 0;
        struct esp_xtensa_smp_common *esp_xtensa_smp = target_to_esp_xtensa_smp(target);
 
        if (target->smp) {