gdb: fix regression in gdb_port command
authorØyvind Harboe <oyvind.harboe@zylin.com>
Tue, 5 Jan 2010 13:57:45 +0000 (14:57 +0100)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Tue, 5 Jan 2010 14:28:23 +0000 (15:28 +0100)
The gdb_port command can be invoked during normal execution
to report the port used for gdb, whereas it was listed as
CONFIG stage only, which caused an error when excuting
it to return the reported error.

Also in line with the grander goal of making more commands
available during all "modes" (perhaps retiring config mode),
there is no particular reason to limit gdb_port to the
config stage.

Regression was introduced in:

b3bf1d12b2fdfba1c1cbee3e1afbfbb27cbd1a26 aka
v0.4.0-rc1-32-gb3bf1d1

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
src/server/gdb_server.c

index d5d7042cd5ced097ac68236df6dd13096119458f..96b9dbf1f730189c56d0997c099fdf0371a519db 100644 (file)
@@ -2421,8 +2421,9 @@ static const struct command_registration gdb_command_handlers[] = {
        {
                .name = "gdb_port",
                .handler = &handle_gdb_port_command,
-               .mode = COMMAND_CONFIG,
-               .help = "daemon configuration command gdb_port",
+               .mode = COMMAND_ANY,
+               .help = "daemon configuration command gdb_port. No arguments reports "
+                               "GDB port.",
                .usage = "<port>",
        },
        {