flash: fix clang static analyzer build errors
authorErhan Kurubas <erhan.kurubas@espressif.com>
Mon, 9 May 2022 21:01:35 +0000 (23:01 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 21 May 2022 09:00:51 +0000 (09:00 +0000)
Fixes "variable set but not used" errors.
Tested with Homebrew clang version 13.0.1

Signed-off-by: Erhan Kurubas <erhan.kurubas@espressif.com>
Change-Id: Ia90baf5b4857db2b5569ebe6adbbb832de772aad
Reviewed-on: https://review.openocd.org/c/openocd/+/6971
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
src/flash/nand/davinci.c
src/flash/nor/dsp5680xx_flash.c

index 84f8e3480650da74b3e1f99bcc590ba7fdef673e..1aa7ffc0578658a7a8c54584801d9852d9953b1d 100644 (file)
@@ -605,8 +605,6 @@ static int davinci_write_page_ecc4infix(struct nand_device *nand, uint32_t page,
                /* write this "out-of-band" data -- infix */
                davinci_write_block_data(nand, oob, 16);
                oob += 16;
-               oob_size -= 16;
-
        } while (data_size);
 
        /* the last data and OOB writes included the spare area */
index 5e8eec30fb0d313d231cfec41348a84e6d8a4b50..858b669815f6d5958331206e3a2f6b6c7d6de8bc 100644 (file)
 
 static int dsp5680xx_build_sector_list(struct flash_bank *bank)
 {
-       uint32_t offset = HFM_FLASH_BASE_ADDR;
-
        bank->sectors = malloc(sizeof(struct flash_sector) * bank->num_sectors);
 
        for (unsigned int i = 0; i < bank->num_sectors; ++i) {
                bank->sectors[i].offset = i * HFM_SECTOR_SIZE;
                bank->sectors[i].size = HFM_SECTOR_SIZE;
-               offset += bank->sectors[i].size;
                bank->sectors[i].is_erased = -1;
                bank->sectors[i].is_protected = -1;
        }