target/dsp563xx: Handle return values
authorMarc Schink <dev@zapb.de>
Thu, 17 Jun 2021 13:47:11 +0000 (15:47 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 26 Jun 2021 13:40:18 +0000 (14:40 +0100)
This fixes 'dead assignment' bugs identified by the clang static analyzer.

Change-Id: I140ed55f0043e06a533f45f50a36887614585b04
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/6323
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
src/target/dsp563xx.c

index 81ea21e8130304901787d5bc79a1735577be7c73..7305733479f0ad97b729bce57f7b12f114d8ed76 100644 (file)
@@ -1085,8 +1085,17 @@ static int dsp563xx_poll(struct target *target)
 
        if (!dsp563xx->hardware_breakpoints_cleared) {
                err = dsp563xx_once_reg_write(target->tap, 1, DSP563XX_ONCE_OBCR, 0);
+               if (err != ERROR_OK)
+                       return err;
+
                err = dsp563xx_once_reg_write(target->tap, 1, DSP563XX_ONCE_OMLR0, 0);
+               if (err != ERROR_OK)
+                       return err;
+
                err = dsp563xx_once_reg_write(target->tap, 1, DSP563XX_ONCE_OMLR1, 0);
+               if (err != ERROR_OK)
+                       return err;
+
                dsp563xx->hardware_breakpoints_cleared = 1;
        }