target/register: Minor code cleanup

Change-Id: Ie02a112c0339ae5d3b3763483e493370b487be98
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/6294
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

diff --git a/src/target/register.c b/src/target/register.c
index 4ddda6e6b3c420978d7c58e5692e8d2e1b1fa9ff..638747560cb08f9c66762477c84ef0fa2220db6d 100644 (file)
--- a/src/target/register.c
+++ b/src/target/register.c
@@ -39,21 +39,20 @@
 struct reg *register_get_by_number(struct reg_cache *first,
                uint32_t reg_num, bool search_all)
 {
-       unsigned i;
        struct reg_cache *cache = first;
 
        while (cache) {
-               for (i = 0; i < cache->num_regs; i++) {
-                       if (cache->reg_list[i].exist == false)
+               for (unsigned int i = 0; i < cache->num_regs; i++) {
+                       if (!cache->reg_list[i].exist)
                                continue;
                        if (cache->reg_list[i].number == reg_num)
                                return &(cache->reg_list[i]);
                }
 
-               if (search_all)
-                       cache = cache->next;
-               else
+               if (!search_all)
                        break;
+
+               cache = cache->next;
        }
 
        return NULL;
@@ -62,21 +61,20 @@ struct reg *register_get_by_number(struct reg_cache *first,
 struct reg *register_get_by_name(struct reg_cache *first,
                const char *name, bool search_all)
 {
-       unsigned i;
        struct reg_cache *cache = first;
 
        while (cache) {
-               for (i = 0; i < cache->num_regs; i++) {
-                       if (cache->reg_list[i].exist == false)
+               for (unsigned int i = 0; i < cache->num_regs; i++) {
+                       if (!cache->reg_list[i].exist)
                                continue;
                        if (strcmp(cache->reg_list[i].name, name) == 0)
                                return &(cache->reg_list[i]);
                }
 
-               if (search_all)
-                       cache = cache->next;
-               else
+               if (!search_all)
                        break;
+
+               cache = cache->next;
        }
 
        return NULL;
@@ -108,8 +106,8 @@ void register_cache_invalidate(struct reg_cache *cache)
 {
        struct reg *reg = cache->reg_list;
 
-       for (unsigned n = cache->num_regs; n != 0; n--, reg++) {
-               if (reg->exist == false)
+       for (unsigned int n = cache->num_regs; n != 0; n--, reg++) {
+               if (!reg->exist)
                        continue;
                reg->valid = false;
                reg->dirty = false;