rtos: fix bug in error handling
authorØyvind Harboe <oyvind.harboe@zylin.com>
Sat, 7 Jan 2012 08:55:54 +0000 (09:55 +0100)
committerØyvind Harboe <oyvindharboe@gmail.com>
Mon, 9 Jan 2012 08:58:24 +0000 (08:58 +0000)
checking for != ERROR_FAIL is broken.

Change-Id: Id7085afac653bb9c38d08928227a9ea402d8e6e9
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/351
Tested-by: jenkins
Reviewed-by: Michel JAOUEN <michel.jaouen@stericsson.com>
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
src/server/gdb_server.c

index 537513a1b6b831179ac8a405ef02d44170fa1e75..abec1383b122bb9263733a2a8855ed00586a7b69 100644 (file)
@@ -1039,8 +1039,8 @@ static int gdb_get_registers_packet(struct connection *connection,
        LOG_DEBUG("-");
 #endif
 
-       if ( ( target->rtos != NULL ) &&
-                ( ERROR_FAIL != rtos_get_gdb_reg_list( connection, &reg_list, &reg_list_size) ) )
+       if ((target->rtos != NULL) &&
+               (ERROR_OK == rtos_get_gdb_reg_list(connection, &reg_list, &reg_list_size)))
        {
                return ERROR_OK;
        }