server: warn if user changes server port after init
authorSpencer Oliver <spen@spen-soft.co.uk>
Tue, 21 Aug 2012 10:10:18 +0000 (11:10 +0100)
committerFreddie Chopin <freddie.chopin@gmail.com>
Wed, 29 Aug 2012 06:42:52 +0000 (06:42 +0000)
So the user can view the current port number these cmds were changed to COMMAND_ANY.
However this means that the user can also attempt to change the port number after init,
even though this is not supported. Issue a warning that this is not supported.

Change-Id: I3d20dcd81277e7d994240a8e314f27672ff760c4
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/788
Tested-by: jenkins
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>
src/server/server.c

index 16f751079b017ed9f7c8432b6c2f3882326d5bf7..96f06b3feff65095bde1d1697a1c85b8ca806b55 100644 (file)
@@ -635,6 +635,10 @@ SERVER_PIPE_COMMAND()
                        break;
                case 1:
                {
+                       if (CMD_CTX->mode == COMMAND_EXEC) {
+                               LOG_WARNING("unable to change server port after init");
+                               return ERROR_COMMAND_ARGUMENT_INVALID;
+                       }
                        const char *t = strdup(CMD_ARGV[0]);
                        free((void *)*out);
                        *out = t;