flash: add stm32l Revision X support
[fw/openocd] / src / flash / nor / stm32lx.c
1 /***************************************************************************
2  *   Copyright (C) 2005 by Dominic Rath                                    *
3  *   Dominic.Rath@gmx.de                                                   *
4  *                                                                         *
5  *   Copyright (C) 2008 by Spencer Oliver                                  *
6  *   spen@spen-soft.co.uk                                                  *
7  *                                                                         *
8  *   Copyright (C) 2011 by Clement Burin des Roziers                       *
9  *   clement.burin-des-roziers@hikob.com                                   *
10  *                                                                         *
11  *   This program is free software; you can redistribute it and/or modify  *
12  *   it under the terms of the GNU General Public License as published by  *
13  *   the Free Software Foundation; either version 2 of the License, or     *
14  *   (at your option) any later version.                                   *
15  *                                                                         *
16  *   This program is distributed in the hope that it will be useful,       *
17  *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
18  *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
19  *   GNU General Public License for more details.                          *
20  *                                                                         *
21  *   You should have received a copy of the GNU General Public License     *
22  *   along with this program; if not, write to the                         *
23  *   Free Software Foundation, Inc.,                                       *
24  *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
25  ***************************************************************************/
26
27 #ifdef HAVE_CONFIG_H
28 #include "config.h"
29 #endif
30
31 #include "imp.h"
32 #include <helper/binarybuffer.h>
33 #include <target/algorithm.h>
34 #include <target/armv7m.h>
35
36 /* stm32lx flash register locations */
37
38 #define FLASH_BASE              0x40023C00
39 #define FLASH_ACR               0x40023C00
40 #define FLASH_PECR              0x40023C04
41 #define FLASH_PDKEYR    0x40023C08
42 #define FLASH_PEKEYR    0x40023C0C
43 #define FLASH_PRGKEYR   0x40023C10
44 #define FLASH_OPTKEYR   0x40023C14
45 #define FLASH_SR                0x40023C18
46 #define FLASH_OBR               0x40023C1C
47 #define FLASH_WRPR              0x40023C20
48
49 /* FLASH_ACR bites */
50 #define FLASH_ACR__LATENCY              (1<<0)
51 #define FLASH_ACR__PRFTEN               (1<<1)
52 #define FLASH_ACR__ACC64                (1<<2)
53 #define FLASH_ACR__SLEEP_PD             (1<<3)
54 #define FLASH_ACR__RUN_PD               (1<<4)
55
56 /* FLASH_PECR bits */
57 #define FLASH_PECR__PELOCK              (1<<0)
58 #define FLASH_PECR__PRGLOCK             (1<<1)
59 #define FLASH_PECR__OPTLOCK             (1<<2)
60 #define FLASH_PECR__PROG                (1<<3)
61 #define FLASH_PECR__DATA                (1<<4)
62 #define FLASH_PECR__FTDW                (1<<8)
63 #define FLASH_PECR__ERASE               (1<<9)
64 #define FLASH_PECR__FPRG                (1<<10)
65 #define FLASH_PECR__EOPIE               (1<<16)
66 #define FLASH_PECR__ERRIE               (1<<17)
67 #define FLASH_PECR__OBL_LAUNCH  (1<<18)
68
69 /* FLASH_SR bits */
70 #define FLASH_SR__BSY           (1<<0)
71 #define FLASH_SR__EOP           (1<<1)
72 #define FLASH_SR__ENDHV         (1<<2)
73 #define FLASH_SR__READY         (1<<3)
74 #define FLASH_SR__WRPERR        (1<<8)
75 #define FLASH_SR__PGAERR        (1<<9)
76 #define FLASH_SR__SIZERR        (1<<10)
77 #define FLASH_SR__OPTVERR       (1<<11)
78
79 /* Unlock keys */
80 #define PEKEY1                  0x89ABCDEF
81 #define PEKEY2                  0x02030405
82 #define PRGKEY1                 0x8C9DAEBF
83 #define PRGKEY2                 0x13141516
84 #define OPTKEY1                 0xFBEAD9C8
85 #define OPTKEY2                 0x24252627
86
87 /* other registers */
88 #define DBGMCU_IDCODE   0xE0042000
89 #define F_SIZE                  0x1FF8004C
90
91 /* Constants */
92 #define FLASH_PAGE_SIZE 256
93 #define FLASH_SECTOR_SIZE 4096
94 #define FLASH_PAGES_PER_SECTOR 16
95 #define FLASH_BANK0_ADDRESS 0x08000000
96
97 /* stm32lx option byte register location */
98 #define OB_RDP                  0x1FF80000
99 #define OB_USER                 0x1FF80004
100 #define OB_WRP0_1               0x1FF80008
101 #define OB_WRP2_3               0x1FF8000C
102
103 /* OB_RDP values */
104 #define OB_RDP__LEVEL0  0xFF5500AA
105 #define OB_RDP__LEVEL1  0xFFFF0000
106
107 /* stm32lx RCC register locations */
108 #define RCC_CR          0x40023800
109 #define RCC_ICSCR       0x40023804
110 #define RCC_CFGR        0x40023808
111
112 /* RCC_ICSCR bits */
113 #define RCC_ICSCR__MSIRANGE_MASK        (7<<13)
114
115 static int stm32lx_unlock_program_memory(struct flash_bank *bank);
116 static int stm32lx_lock_program_memory(struct flash_bank *bank);
117 static int stm32lx_enable_write_half_page(struct flash_bank *bank);
118 static int stm32lx_erase_sector(struct flash_bank *bank, int sector);
119 static int stm32lx_wait_until_bsy_clear(struct flash_bank *bank);
120
121 struct stm32lx_flash_bank {
122         struct working_area *write_algorithm;
123         int probed;
124 };
125
126 /* flash bank stm32lx <base> <size> 0 0 <target#>
127  */
128 FLASH_BANK_COMMAND_HANDLER(stm32lx_flash_bank_command)
129 {
130         struct stm32lx_flash_bank *stm32lx_info;
131         if (CMD_ARGC < 6)
132                 return ERROR_COMMAND_SYNTAX_ERROR;
133
134         /* Create the bank structure */
135         stm32lx_info = malloc(sizeof(struct stm32lx_flash_bank));
136
137         /* Check allocation */
138         if (stm32lx_info == NULL) {
139                 LOG_ERROR("failed to allocate bank structure");
140                 return ERROR_FAIL;
141         }
142
143         bank->driver_priv = stm32lx_info;
144
145         stm32lx_info->write_algorithm = NULL;
146         stm32lx_info->probed = 0;
147
148         return ERROR_OK;
149 }
150
151 static int stm32lx_protect_check(struct flash_bank *bank)
152 {
153         int retval;
154         struct target *target = bank->target;
155
156         uint32_t wrpr;
157
158         if (target->state != TARGET_HALTED) {
159                 LOG_ERROR("Target not halted");
160                 return ERROR_TARGET_NOT_HALTED;
161         }
162
163         /*
164          * Read the WRPR word, and check each bit (corresponding to each
165          * flash sector
166          */
167         retval = target_read_u32(target, FLASH_WRPR, &wrpr);
168         if (retval != ERROR_OK)
169                 return retval;
170
171         for (int i = 0; i < 32; i++) {
172                 if (wrpr & (1 << i))
173                         bank->sectors[i].is_protected = 1;
174                 else
175                         bank->sectors[i].is_protected = 0;
176         }
177         return ERROR_OK;
178 }
179
180 static int stm32lx_erase(struct flash_bank *bank, int first, int last)
181 {
182         int retval;
183
184         /*
185          * It could be possible to do a mass erase if all sectors must be
186          * erased, but it is not implemented yet.
187          */
188
189         if (bank->target->state != TARGET_HALTED) {
190                 LOG_ERROR("Target not halted");
191                 return ERROR_TARGET_NOT_HALTED;
192         }
193
194         /*
195          * Loop over the selected sectors and erase them
196          */
197         for (int i = first; i <= last; i++) {
198                 retval = stm32lx_erase_sector(bank, i);
199                 if (retval != ERROR_OK)
200                         return retval;
201                 bank->sectors[i].is_erased = 1;
202         }
203         return ERROR_OK;
204 }
205
206 static int stm32lx_protect(struct flash_bank *bank, int set, int first,
207                 int last)
208 {
209         LOG_WARNING("protection of the STM32L flash is not implemented");
210         return ERROR_OK;
211 }
212
213 static int stm32lx_write_half_pages(struct flash_bank *bank, uint8_t *buffer,
214                 uint32_t offset, uint32_t count)
215 {
216         struct stm32lx_flash_bank *stm32lx_info = bank->driver_priv;
217         struct target *target = bank->target;
218         uint32_t buffer_size = 4096 * 4;
219         struct working_area *source;
220         uint32_t address = bank->base + offset;
221
222         struct reg_param reg_params[5];
223         struct armv7m_algorithm armv7m_info;
224
225         int retval = ERROR_OK;
226         uint32_t reg32;
227
228         /* see contib/loaders/flash/stm32lx.s for src */
229
230         static const uint16_t stm32lx_flash_write_code_16[] = {
231         /*      00000000 <write_word-0x4>: */
232                         0x2300, /* 0:   2300            movs    r3, #0 */
233                         0xe004, /* 2:   e004            b.n     e <test_done> */
234
235                         /*      00000004 <write_word>: */
236                         0xf851, 0xcb04, /* 4:   f851 cb04       ldr.w   ip, [r1], #4 */
237                         0xf840, 0xcb04, /* 8:   f840 cb04       str.w   ip, [r0], #4 */
238                         0x3301, /* c:   3301            adds    r3, #1 */
239
240                         /*      0000000e <test_done>: */
241                         0x4293, /* e:   4293            cmp     r3, r2 */
242                         0xd3f8, /* 10:  d3f8            bcc.n   4 <write_word> */
243                         0xbe00, /* 12:  be00            bkpt    0x0000 */
244
245                         };
246
247         /* Flip endian */
248         uint8_t stm32lx_flash_write_code[sizeof(stm32lx_flash_write_code_16)];
249         for (unsigned int i = 0; i < sizeof(stm32lx_flash_write_code_16) / 2; i++) {
250                 stm32lx_flash_write_code[i * 2 + 0] = stm32lx_flash_write_code_16[i]
251                                 & 0xff;
252                 stm32lx_flash_write_code[i * 2 + 1] = (stm32lx_flash_write_code_16[i]
253                                 >> 8) & 0xff;
254         }
255         /* Check if there is an even number of half pages (128bytes) */
256         if (count % 128) {
257                 LOG_ERROR("there should be an even number "
258                                 "of half pages = 128 bytes (count = %" PRIi32 " bytes)", count);
259                 return ERROR_FAIL;
260         }
261
262         /* Allocate working area */
263         reg32 = sizeof(stm32lx_flash_write_code);
264         /* Add bytes to make 4byte aligned */
265         reg32 += (4 - (reg32 % 4)) % 4;
266         retval = target_alloc_working_area(target, reg32,
267                         &stm32lx_info->write_algorithm);
268         if (retval != ERROR_OK)
269                 return retval;
270
271         /* Write the flashing code */
272         retval = target_write_buffer(target,
273                         stm32lx_info->write_algorithm->address,
274                         sizeof(stm32lx_flash_write_code),
275                         (uint8_t *)stm32lx_flash_write_code);
276         if (retval != ERROR_OK) {
277                 target_free_working_area(target, stm32lx_info->write_algorithm);
278                 return retval;
279         }
280
281         /* Allocate half pages memory */
282         while (target_alloc_working_area_try(target, buffer_size, &source)
283                         != ERROR_OK) {
284                 if (buffer_size > 1024)
285                         buffer_size -= 1024;
286                 else
287                         buffer_size /= 2;
288
289                 if (buffer_size <= 256) {
290                         /* if we already allocated the writing code, but failed to get a
291                          * buffer, free the algorithm */
292                         if (stm32lx_info->write_algorithm)
293                                 target_free_working_area(target, stm32lx_info->write_algorithm);
294
295                         LOG_WARNING("no large enough working area available, can't do block memory writes");
296                         return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
297                 }
298         }
299         LOG_DEBUG("allocated working area for data (%" PRIx32 " bytes)", buffer_size);
300
301         armv7m_info.common_magic = ARMV7M_COMMON_MAGIC;
302         armv7m_info.core_mode = ARMV7M_MODE_ANY;
303         init_reg_param(&reg_params[0], "r0", 32, PARAM_OUT);
304         init_reg_param(&reg_params[1], "r1", 32, PARAM_OUT);
305         init_reg_param(&reg_params[2], "r2", 32, PARAM_OUT);
306         init_reg_param(&reg_params[3], "r3", 32, PARAM_IN_OUT);
307         init_reg_param(&reg_params[4], "r4", 32, PARAM_OUT);
308
309         /* Enable half-page write */
310         retval = stm32lx_enable_write_half_page(bank);
311         if (retval != ERROR_OK) {
312                 target_free_working_area(target, source);
313                 target_free_working_area(target, stm32lx_info->write_algorithm);
314
315                 destroy_reg_param(&reg_params[0]);
316                 destroy_reg_param(&reg_params[1]);
317                 destroy_reg_param(&reg_params[2]);
318                 destroy_reg_param(&reg_params[3]);
319                 return retval;
320         }
321
322         /* Loop while there are bytes to write */
323         while (count > 0) {
324                 uint32_t this_count;
325                 this_count = (count > buffer_size) ? buffer_size : count;
326
327                 /* Write the next half pages */
328                 retval = target_write_buffer(target, source->address, this_count,
329                                 buffer);
330                 if (retval != ERROR_OK)
331                         break;
332
333                 /* 4: Store useful information in the registers */
334                 /* the destination address of the copy (R0) */
335                 buf_set_u32(reg_params[0].value, 0, 32, address);
336                 /* The source address of the copy (R1) */
337                 buf_set_u32(reg_params[1].value, 0, 32, source->address);
338                 /* The length of the copy (R2) */
339                 buf_set_u32(reg_params[2].value, 0, 32, this_count / 4);
340
341                 /* 5: Execute the bunch of code */
342                 retval = target_run_algorithm(target, 0, NULL, sizeof(reg_params)
343                                 / sizeof(*reg_params), reg_params,
344                                 stm32lx_info->write_algorithm->address, 0, 20000, &armv7m_info);
345                 if (retval != ERROR_OK)
346                         break;
347
348                 /* 6: Wait while busy */
349                 retval = stm32lx_wait_until_bsy_clear(bank);
350                 if (retval != ERROR_OK)
351                         break;
352
353                 buffer += this_count;
354                 address += this_count;
355                 count -= this_count;
356         }
357
358         if (retval == ERROR_OK)
359                 retval = stm32lx_lock_program_memory(bank);
360
361         target_free_working_area(target, source);
362         target_free_working_area(target, stm32lx_info->write_algorithm);
363
364         destroy_reg_param(&reg_params[0]);
365         destroy_reg_param(&reg_params[1]);
366         destroy_reg_param(&reg_params[2]);
367         destroy_reg_param(&reg_params[3]);
368
369         return retval;
370 }
371 static int stm32lx_write(struct flash_bank *bank, uint8_t *buffer,
372                 uint32_t offset, uint32_t count)
373 {
374         struct target *target = bank->target;
375
376         uint32_t halfpages_number;
377         uint32_t words_remaining;
378         uint32_t bytes_remaining;
379         uint32_t address = bank->base + offset;
380         uint32_t bytes_written = 0;
381         int retval;
382
383         if (bank->target->state != TARGET_HALTED) {
384                 LOG_ERROR("Target not halted");
385                 return ERROR_TARGET_NOT_HALTED;
386         }
387
388         if (offset & 0x1) {
389                 LOG_ERROR("offset 0x%" PRIx32 " breaks required 2-byte alignment", offset);
390                 return ERROR_FLASH_DST_BREAKS_ALIGNMENT;
391         }
392
393         /* Check if there are some full half pages */
394         if (((offset % 128) == 0) && (count >= 128)) {
395                 halfpages_number = count / 128;
396                 words_remaining = (count - 128 * halfpages_number) / 4;
397                 bytes_remaining = (count & 0x3);
398         } else {
399                 halfpages_number = 0;
400                 words_remaining = (count / 4);
401                 bytes_remaining = (count & 0x3);
402         }
403
404         if (halfpages_number) {
405                 retval = stm32lx_write_half_pages(bank, buffer, offset, 128
406                                 * halfpages_number);
407                 if (retval != ERROR_OK)
408                         return ERROR_FAIL;
409         }
410
411         bytes_written = 128 * halfpages_number;
412         address += bytes_written;
413
414         retval = stm32lx_unlock_program_memory(bank);
415         if (retval != ERROR_OK)
416                 return retval;
417
418         while (words_remaining > 0) {
419                 uint32_t value;
420                 uint8_t *p = buffer + bytes_written;
421
422                 /* Prepare the word, Little endian conversion */
423                 value = p[0] + (p[1] << 8) + (p[2] << 16) + (p[3] << 24);
424
425                 retval = target_write_u32(target, address, value);
426                 if (retval != ERROR_OK)
427                         return retval;
428
429                 bytes_written += 4;
430                 words_remaining--;
431                 address += 4;
432
433                 retval = stm32lx_wait_until_bsy_clear(bank);
434                 if (retval != ERROR_OK)
435                         return retval;
436         }
437
438         if (bytes_remaining) {
439                 uint8_t last_word[4] = {0xff, 0xff, 0xff, 0xff};
440
441                 /* copy the last remaining bytes into the write buffer */
442                 memcpy(last_word, buffer+bytes_written, bytes_remaining);
443
444                 retval = target_write_buffer(target, address, 4, last_word);
445                 if (retval != ERROR_OK)
446                         return retval;
447
448                 retval = stm32lx_wait_until_bsy_clear(bank);
449                 if (retval != ERROR_OK)
450                         return retval;
451         }
452
453         retval = stm32lx_lock_program_memory(bank);
454         if (retval != ERROR_OK)
455                 return retval;
456
457         return ERROR_OK;
458 }
459
460 static int stm32lx_probe(struct flash_bank *bank)
461 {
462         struct target *target = bank->target;
463         struct stm32lx_flash_bank *stm32lx_info = bank->driver_priv;
464         int i;
465         uint16_t flash_size_in_kb;
466         uint32_t device_id;
467
468         stm32lx_info->probed = 0;
469
470         /* read stm32 device id register */
471         int retval = target_read_u32(target, DBGMCU_IDCODE, &device_id);
472         if (retval != ERROR_OK)
473                 return retval;
474
475         LOG_DEBUG("device id = 0x%08" PRIx32 "", device_id);
476
477         /* get flash size from target. */
478         retval = target_read_u16(target, F_SIZE, &flash_size_in_kb);
479         if (retval != ERROR_OK)
480                 return retval;
481
482         if ((device_id & 0xfff) == 0x416) {
483                 /* check for early silicon */
484                 if (flash_size_in_kb == 0xffff) {
485                         /* number of sectors may be incorrrect on early silicon */
486                         LOG_WARNING("STM32 flash size failed, probe inaccurate - assuming 128k flash");
487                         flash_size_in_kb = 128;
488                 }
489         } else if ((device_id & 0xfff) == 0x436) {
490                 /* check for early silicon */
491                 if (flash_size_in_kb == 0xffff) {
492                         /* number of sectors may be incorrrect on early silicon */
493                         LOG_WARNING("STM32 flash size failed, probe inaccurate - assuming 384k flash");
494                         flash_size_in_kb = 384;
495                 }
496         } else {
497                 LOG_WARNING("Cannot identify target as a STM32L family.");
498                 return ERROR_FAIL;
499         }
500
501         /* STM32L - we have 32 sectors, 16 pages per sector -> 512 pages
502          * 16 pages for a protection area */
503
504         /* calculate numbers of sectors (4kB per sector) */
505         int num_sectors = (flash_size_in_kb * 1024) / FLASH_SECTOR_SIZE;
506         LOG_INFO("flash size = %dkbytes", flash_size_in_kb);
507
508         if (bank->sectors) {
509                 free(bank->sectors);
510                 bank->sectors = NULL;
511         }
512
513         bank->base = FLASH_BANK0_ADDRESS;
514         bank->size = flash_size_in_kb * 1024;
515         bank->num_sectors = num_sectors;
516         bank->sectors = malloc(sizeof(struct flash_sector) * num_sectors);
517         if (bank->sectors == NULL) {
518                 LOG_ERROR("failed to allocate bank sectors");
519                 return ERROR_FAIL;
520         }
521
522         for (i = 0; i < num_sectors; i++) {
523                 bank->sectors[i].offset = i * FLASH_SECTOR_SIZE;
524                 bank->sectors[i].size = FLASH_SECTOR_SIZE;
525                 bank->sectors[i].is_erased = -1;
526                 bank->sectors[i].is_protected = 1;
527         }
528
529         stm32lx_info->probed = 1;
530
531         return ERROR_OK;
532 }
533
534 static int stm32lx_auto_probe(struct flash_bank *bank)
535 {
536         struct stm32lx_flash_bank *stm32lx_info = bank->driver_priv;
537
538         if (stm32lx_info->probed)
539                 return ERROR_OK;
540
541         return stm32lx_probe(bank);
542 }
543
544 static int stm32lx_erase_check(struct flash_bank *bank)
545 {
546         struct target *target = bank->target;
547         const int buffer_size = 4096;
548         int i;
549         uint32_t nBytes;
550         int retval = ERROR_OK;
551
552         if (bank->target->state != TARGET_HALTED) {
553                 LOG_ERROR("Target not halted");
554                 return ERROR_TARGET_NOT_HALTED;
555         }
556
557         uint8_t *buffer = malloc(buffer_size);
558         if (buffer == NULL) {
559                 LOG_ERROR("failed to allocate read buffer");
560                 return ERROR_FAIL;
561         }
562
563         for (i = 0; i < bank->num_sectors; i++) {
564                 uint32_t j;
565                 bank->sectors[i].is_erased = 1;
566
567                 /* Loop chunk by chunk over the sector */
568                 for (j = 0; j < bank->sectors[i].size; j += buffer_size) {
569                         uint32_t chunk;
570                         chunk = buffer_size;
571                         if (chunk > (j - bank->sectors[i].size))
572                                 chunk = (j - bank->sectors[i].size);
573
574                         retval = target_read_memory(target, bank->base
575                                         + bank->sectors[i].offset + j, 4, chunk / 4, buffer);
576                         if (retval != ERROR_OK)
577                                 break;
578
579                         for (nBytes = 0; nBytes < chunk; nBytes++) {
580                                 if (buffer[nBytes] != 0x00) {
581                                         bank->sectors[i].is_erased = 0;
582                                         break;
583                                 }
584                         }
585                 }
586                 if (retval != ERROR_OK)
587                         break;
588         }
589         free(buffer);
590
591         return retval;
592 }
593
594 static int stm32lx_get_info(struct flash_bank *bank, char *buf, int buf_size)
595 {
596         /* This method must return a string displaying information about the bank */
597
598         struct target *target = bank->target;
599         uint32_t device_id;
600         int printed;
601
602         /* read stm32 device id register */
603         int retval = target_read_u32(target, DBGMCU_IDCODE, &device_id);
604         if (retval != ERROR_OK)
605                 return retval;
606
607         if ((device_id & 0xfff) == 0x416) {
608                 printed = snprintf(buf, buf_size, "stm32lx - Rev: ");
609                 buf += printed;
610                 buf_size -= printed;
611
612                 switch (device_id >> 16) {
613                         case 0x1000:
614                                 snprintf(buf, buf_size, "A");
615                                 break;
616
617                         case 0x1008:
618                                 snprintf(buf, buf_size, "Y");
619                                 break;
620
621                         case 0x1018:
622                                 snprintf(buf, buf_size, "X");
623                                 break;
624
625                         case 0x1038:
626                                 snprintf(buf, buf_size, "W");
627                                 break;
628
629                         case 0x1078:
630                                 snprintf(buf, buf_size, "V");
631                                 break;
632
633                         default:
634                                 snprintf(buf, buf_size, "unknown");
635                                 break;
636                 }
637         } else if ((device_id & 0xfff) == 0x436) {
638                 printed = snprintf(buf, buf_size, "stm32lx (HD) - Rev: ");
639                 buf += printed;
640                 buf_size -= printed;
641
642                 switch (device_id >> 16) {
643                         case 0x1000:
644                                 snprintf(buf, buf_size, "A");
645                                 break;
646
647                         case 0x1008:
648                                 snprintf(buf, buf_size, "Z");
649                                 break;
650
651                         default:
652                                 snprintf(buf, buf_size, "unknown");
653                                 break;
654                 }
655         } else {
656                 snprintf(buf, buf_size, "Cannot identify target as a stm32lx");
657                 return ERROR_FAIL;
658         }
659
660         return ERROR_OK;
661 }
662
663 static const struct command_registration stm32lx_exec_command_handlers[] = {
664         COMMAND_REGISTRATION_DONE
665 };
666
667 static const struct command_registration stm32lx_command_handlers[] = {
668         {
669                 .name = "stm32lx",
670                 .mode = COMMAND_ANY,
671                 .help = "stm32lx flash command group",
672                 .usage = "",
673                 .chain = stm32lx_exec_command_handlers,
674         },
675         COMMAND_REGISTRATION_DONE
676 };
677
678 struct flash_driver stm32lx_flash = {
679                 .name = "stm32lx",
680                 .commands = stm32lx_command_handlers,
681                 .flash_bank_command = stm32lx_flash_bank_command,
682                 .erase = stm32lx_erase,
683                 .protect = stm32lx_protect,
684                 .write = stm32lx_write,
685                 .read = default_flash_read,
686                 .probe = stm32lx_probe,
687                 .auto_probe = stm32lx_auto_probe,
688                 .erase_check = stm32lx_erase_check,
689                 .protect_check = stm32lx_protect_check,
690                 .info = stm32lx_get_info,
691 };
692
693 /* Static methods implementation */
694 static int stm32lx_unlock_program_memory(struct flash_bank *bank)
695 {
696         struct target *target = bank->target;
697         int retval;
698         uint32_t reg32;
699
700         /*
701          * Unlocking the program memory is done by unlocking the PECR,
702          * then by writing the 2 PRGKEY to the PRGKEYR register
703          */
704
705         /* To unlock the PECR write the 2 PEKEY to the PEKEYR register */
706         retval = target_write_u32(target, FLASH_PEKEYR, PEKEY1);
707         if (retval != ERROR_OK)
708                 return retval;
709
710         retval = target_write_u32(target, FLASH_PEKEYR, PEKEY2);
711         if (retval != ERROR_OK)
712                 return retval;
713
714         /* Make sure it worked */
715         retval = target_read_u32(target, FLASH_PECR, &reg32);
716         if (retval != ERROR_OK)
717                 return retval;
718
719         if (reg32 & FLASH_PECR__PELOCK) {
720                 LOG_ERROR("PELOCK is not cleared :(");
721                 return ERROR_FLASH_OPERATION_FAILED;
722         }
723
724         retval = target_write_u32(target, FLASH_PRGKEYR, PRGKEY1);
725         if (retval != ERROR_OK)
726                 return retval;
727         retval = target_write_u32(target, FLASH_PRGKEYR, PRGKEY2);
728         if (retval != ERROR_OK)
729                 return retval;
730
731         /* Make sure it worked */
732         retval = target_read_u32(target, FLASH_PECR, &reg32);
733         if (retval != ERROR_OK)
734                 return retval;
735
736         if (reg32 & FLASH_PECR__PRGLOCK) {
737                 LOG_ERROR("PRGLOCK is not cleared :(");
738                 return ERROR_FLASH_OPERATION_FAILED;
739         }
740         return ERROR_OK;
741 }
742
743 static int stm32lx_enable_write_half_page(struct flash_bank *bank)
744 {
745         struct target *target = bank->target;
746         int retval;
747         uint32_t reg32;
748
749         /**
750          * Unlock the program memory, then set the FPRG bit in the PECR register.
751          */
752         retval = stm32lx_unlock_program_memory(bank);
753         if (retval != ERROR_OK)
754                 return retval;
755
756         retval = target_read_u32(target, FLASH_PECR, &reg32);
757         if (retval != ERROR_OK)
758                 return retval;
759
760         reg32 |= FLASH_PECR__FPRG;
761         retval = target_write_u32(target, FLASH_PECR, reg32);
762         if (retval != ERROR_OK)
763                 return retval;
764
765         retval = target_read_u32(target, FLASH_PECR, &reg32);
766         if (retval != ERROR_OK)
767                 return retval;
768
769         reg32 |= FLASH_PECR__PROG;
770         retval = target_write_u32(target, FLASH_PECR, reg32);
771
772         return retval;
773 }
774
775 static int stm32lx_lock_program_memory(struct flash_bank *bank)
776 {
777         struct target *target = bank->target;
778         int retval;
779         uint32_t reg32;
780
781         /* To lock the program memory, simply set the lock bit and lock PECR */
782
783         retval = target_read_u32(target, FLASH_PECR, &reg32);
784         if (retval != ERROR_OK)
785                 return retval;
786
787         reg32 |= FLASH_PECR__PRGLOCK;
788         retval = target_write_u32(target, FLASH_PECR, reg32);
789         if (retval != ERROR_OK)
790                 return retval;
791
792         retval = target_read_u32(target, FLASH_PECR, &reg32);
793         if (retval != ERROR_OK)
794                 return retval;
795
796         reg32 |= FLASH_PECR__PELOCK;
797         retval = target_write_u32(target, FLASH_PECR, reg32);
798         if (retval != ERROR_OK)
799                 return retval;
800
801         return ERROR_OK;
802 }
803
804 static int stm32lx_erase_sector(struct flash_bank *bank, int sector)
805 {
806         struct target *target = bank->target;
807         int retval;
808         uint32_t reg32;
809
810         /*
811          * To erase a sector (i.e. FLASH_PAGES_PER_SECTOR pages),
812          * first unlock the memory, loop over the pages of this sector
813          * and write 0x0 to its first word.
814          */
815
816         retval = stm32lx_unlock_program_memory(bank);
817         if (retval != ERROR_OK)
818                 return retval;
819
820         for (int page = 0; page < FLASH_PAGES_PER_SECTOR; page++) {
821                 reg32 = FLASH_PECR__PROG | FLASH_PECR__ERASE;
822                 retval = target_write_u32(target, FLASH_PECR, reg32);
823                 if (retval != ERROR_OK)
824                         return retval;
825
826                 retval = stm32lx_wait_until_bsy_clear(bank);
827                 if (retval != ERROR_OK)
828                         return retval;
829
830                 uint32_t addr = bank->base + bank->sectors[sector].offset + (page
831                                 * FLASH_PAGE_SIZE);
832                 retval = target_write_u32(target, addr, 0x0);
833                 if (retval != ERROR_OK)
834                         return retval;
835
836                 retval = stm32lx_wait_until_bsy_clear(bank);
837                 if (retval != ERROR_OK)
838                         return retval;
839         }
840
841         retval = stm32lx_lock_program_memory(bank);
842         if (retval != ERROR_OK)
843                 return retval;
844
845         return ERROR_OK;
846 }
847
848 static int stm32lx_wait_until_bsy_clear(struct flash_bank *bank)
849 {
850         struct target *target = bank->target;
851         uint32_t status;
852         int retval = ERROR_OK;
853         int timeout = 100;
854
855         /* wait for busy to clear */
856         for (;;) {
857                 retval = target_read_u32(target, FLASH_SR, &status);
858                 if (retval != ERROR_OK)
859                         return retval;
860
861                 if ((status & FLASH_SR__BSY) == 0)
862                         break;
863                 if (timeout-- <= 0) {
864                         LOG_ERROR("timed out waiting for flash");
865                         return ERROR_FAIL;
866                 }
867                 alive_sleep(1);
868         }
869
870         if (status & FLASH_SR__WRPERR) {
871                 LOG_ERROR("access denied / write protected");
872                 retval = ERROR_FAIL;
873         }
874
875         if (status & FLASH_SR__PGAERR) {
876                 LOG_ERROR("invalid program address");
877                 retval = ERROR_FAIL;
878         }
879
880         return retval;
881 }