Variety of changes based on suggestions from ADT Lint. Includes removing extra drawa...

git-svn-id: https://openrocket.svn.sourceforge.net/svnroot/openrocket/trunk@720 180e2498-e6e9-4542-8430-84ac67f01cd8

diff --git a/android/res/drawable-hdpi/actionbar_shadow.9.png b/android/res/drawable-hdpi/actionbar_shadow.9.png
deleted file mode 100644 (file)
index 3c80a3f..0000000
Binary files a/android/res/drawable-hdpi/actionbar_shadow.9.png and /dev/null differ

diff --git a/android/res/drawable-mdpi/actionbar_shadow.9.png b/android/res/drawable-mdpi/actionbar_shadow.9.png
deleted file mode 100644 (file)
index cae1778..0000000
Binary files a/android/res/drawable-mdpi/actionbar_shadow.9.png and /dev/null differ

diff --git a/android/res/drawable-mdpi/ic_home_carat.png b/android/res/drawable-mdpi/ic_home_carat.png
deleted file mode 100644 (file)
index 22dad56..0000000
Binary files a/android/res/drawable-mdpi/ic_home_carat.png and /dev/null differ

diff --git a/android/res/drawable-xhdpi/actionbar_shadow.9.png b/android/res/drawable-xhdpi/actionbar_shadow.9.png
deleted file mode 100644 (file)
index 30778e3..0000000
Binary files a/android/res/drawable-xhdpi/actionbar_shadow.9.png and /dev/null differ

diff --git a/android/res/drawable/actionbar_compat_item.xml b/android/res/drawable/actionbar_compat_item.xml
deleted file mode 100644 (file)
index 4b3960c..0000000
--- a/android/res/drawable/actionbar_compat_item.xml
+++ /dev/null
@@ -1,23 +0,0 @@
-<!--
-  Copyright 2011 The Android Open Source Project
-
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
-  -->
-
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-    <item android:drawable="@drawable/actionbar_compat_item_pressed"
-        android:state_pressed="true" />
-    <item android:drawable="@drawable/actionbar_compat_item_focused"
-        android:state_focused="true" />
-    <item android:drawable="@android:color/transparent" />
-</selector>

diff --git a/android/res/drawable/actionbar_compat_item_focused.xml b/android/res/drawable/actionbar_compat_item_focused.xml
deleted file mode 100644 (file)
index 04811d3..0000000
--- a/android/res/drawable/actionbar_compat_item_focused.xml
+++ /dev/null
@@ -1,19 +0,0 @@
-<!--
-  Copyright 2011 The Android Open Source Project
-
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
-  -->
-
-<shape xmlns:android="http://schemas.android.com/apk/res/android">
-    <solid android:color="#ef7000" />
-</shape>

diff --git a/android/res/drawable/actionbar_compat_item_pressed.xml b/android/res/drawable/actionbar_compat_item_pressed.xml
deleted file mode 100644 (file)
index 72ff4b4..0000000
--- a/android/res/drawable/actionbar_compat_item_pressed.xml
+++ /dev/null
@@ -1,19 +0,0 @@
-<!--
-  Copyright 2011 The Android Open Source Project
-
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
-  -->
-
-<shape xmlns:android="http://schemas.android.com/apk/res/android">
-    <solid android:color="#eda700" />
-</shape>

diff --git a/android/res/drawable/home_item.xml b/android/res/drawable/home_item.xml
deleted file mode 100644 (file)
index 9afcd5a..0000000
--- a/android/res/drawable/home_item.xml
+++ /dev/null
@@ -1,4 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-
-<bitmap  xmlns:android="http://schemas.android.com/apk/res/android"
-    android:src="@drawable/or_launcher"/>

diff --git a/android/res/layout-xlarge-land/motorbrowser.xml b/android/res/layout-xlarge-land/motorbrowser.xml
index 33c1237d587dbfb2576810e3d5934d215fac7087..25a2a8360633b7737735bf541d64af6161bcf412 100644 (file)
--- a/android/res/layout-xlarge-land/motorbrowser.xml
+++ b/android/res/layout-xlarge-land/motorbrowser.xml
@@ -2,18 +2,19 @@
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"\r
     android:layout_width="match_parent"\r
     android:layout_height="match_parent"\r
+    android:baselineAligned="false"\r
     android:orientation="horizontal" >\r
 \r
     <FrameLayout\r
         android:id="@+id/motorBrowserList"\r
         android:layout_width="wrap_content"\r
         android:layout_height="match_parent"\r
-        android:layout_weight="4"/>\r
+        android:layout_weight="4" />\r
 \r
     <FrameLayout\r
         android:id="@+id/sidepane"\r
         android:layout_width="wrap_content"\r
         android:layout_height="wrap_content"\r
-        android:layout_weight="1"/>\r
+        android:layout_weight="1" />\r
 \r
 </LinearLayout>
\ No newline at end of file

diff --git a/android/res/layout/component_list_item.xml b/android/res/layout/component_list_item.xml
index 6956b2d01f07cddf1721278bcce6c3bde5531282..7b12fc2d38181c7519714b2f57e8bcb24e6de420 100644 (file)
--- a/android/res/layout/component_list_item.xml
+++ b/android/res/layout/component_list_item.xml
@@ -3,11 +3,11 @@
     android:layout_width="fill_parent"
     android:layout_height="fill_parent"
     android:gravity="center_vertical"
-    padding="2dip" >
+    android:padding="2dip" >
 
     <TextView
         android:id="@android:id/text1"
-        android:layout_width="fill_parent"
+        android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_weight="1"
         android:padding="4dip"

diff --git a/android/res/layout/filebrowser_list_item.xml b/android/res/layout/filebrowser_list_item.xml
index 9e8de5e713f9bb57368f429f62936e321fab9cab..0cee268fc919fb587cf2e0192adf96970fd66c19 100644 (file)
--- a/android/res/layout/filebrowser_list_item.xml
+++ b/android/res/layout/filebrowser_list_item.xml
@@ -11,7 +11,7 @@
 
     <TextView
         android:id="@+id/filebrowser_list_item_name"
-        android:layout_width="wrap_content"
+        android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_weight="1"
         android:gravity="center_vertical"

diff --git a/android/res/layout/tcqueryform.xml b/android/res/layout/tcqueryform.xml
index 4295e879babf1e6af52e490ca5ed19971927e4db..3c6d63332e437a57e3309a9a8ff21325b044946c 100644 (file)
--- a/android/res/layout/tcqueryform.xml
+++ b/android/res/layout/tcqueryform.xml
@@ -49,6 +49,7 @@
                 android:text="@string/motor_commonname" />
 
             <EditText
+                android:inputType="text"
                 android:id="@+id/TCMotorSearchFormCommonNameField"
                 android:text="" />
         </TableRow>

diff --git a/android/res/layout/tree_list_item_wrapper.xml b/android/res/layout/tree_list_item_wrapper.xml
index ba93f47d40a99cc9e9455998ec3cb4a659a55b0a..7fe3196187872eaf06fed7ef636e3a188d11730e 100644 (file)
--- a/android/res/layout/tree_list_item_wrapper.xml
+++ b/android/res/layout/tree_list_item_wrapper.xml
@@ -1,7 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="fill_parent"
-    android:layout_height="fill_parent" >
+    android:layout_height="fill_parent"
+    android:baselineAligned="false" >
 
     <LinearLayout
         android:id="@+id/treeview_list_item_image_layout"
@@ -19,7 +20,7 @@
 
     <FrameLayout
         android:id="@+id/treeview_list_item_frame"
-        android:layout_width="fill_parent"
+        android:layout_width="0dp"
         android:layout_height="fill_parent"
         android:layout_weight="1" >
     </FrameLayout>

diff --git a/android/res/menu/rocket_viewer_option_menu.xml b/android/res/menu/rocket_viewer_option_menu.xml
index ac2387e2e320a7e1e5979e51829490fdf4e7bdec..349893b60c95f69b1304ff5b068ddc8fd5069c4f 100644 (file)
--- a/android/res/menu/rocket_viewer_option_menu.xml
+++ b/android/res/menu/rocket_viewer_option_menu.xml
@@ -7,7 +7,7 @@
     <item\r
         android:id="@+id/motor_list_menu_option"\r
         android:icon="@drawable/ic_motorbrowser"\r
-        android:showAsAction="always"\r
+        android:showAsAction="ifRoom"\r
         android:title="@string/viewmotorslabel"/>\r
     <item\r
         android:id="@+id/preference_menu_option"\r

diff --git a/android/src/net/sf/openrocket/android/motor/BurnPlotFragment.java b/android/src/net/sf/openrocket/android/motor/BurnPlotFragment.java
index c055e556ba927b95378bdcdae6beeffba1eef163..eff07756a696c5a4d7e2b202b879d95cb8de07ae 100644 (file)
--- a/android/src/net/sf/openrocket/android/motor/BurnPlotFragment.java
+++ b/android/src/net/sf/openrocket/android/motor/BurnPlotFragment.java
@@ -132,7 +132,7 @@ public class BurnPlotFragment extends Fragment {
                int datasize = timePoints.length;\r
                for( int i = 0; i<datasize; i++ ) {\r
                        series.add(timePoints[i], thrustPoints[i]);\r
-                       int ceil = new Double(Math.ceil(thrustPoints[i])).intValue();\r
+                       int ceil =(int) Math.ceil(thrustPoints[i]);\r
                        if ( ceil > maxy ) {\r
                                maxy = ceil;\r
                        }\r
@@ -144,7 +144,7 @@ public class BurnPlotFragment extends Fragment {
                if ( maxx >= 2.0 ) {\r
                        maxx = Math.ceil(maxx);\r
                } else {\r
-                       maxx = new Double( Math.ceil(maxx*10.0) ).intValue() /10.0;\r
+                       maxx = Math.ceil(maxx*10.0) /10.0;\r
                }\r
                renderer.setXAxisMax(maxx);\r
                \r