From 32807fb95080f3e500d2dbd64e319cc33577a658 Mon Sep 17 00:00:00 2001
From: Jerry Jacobs <jerry.jacobs@dualinventive.com>
Date: Thu, 7 Apr 2016 11:58:16 +0200
Subject: [PATCH] cmake: Add -ggdb flag when CMAKE_BUILD_TYPE=Debug, add more
 usefull and stricter compiler flags when supported

---
 CMakeLists.txt | 68 ++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 52 insertions(+), 16 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 247e515..cae6bd1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,12 +1,48 @@
 cmake_minimum_required(VERSION 2.8.11)
-project(stlink)
+project(stlink C)
 
+include(CheckCCompilerFlag)
 find_package(PkgConfig)
 
 pkg_check_modules(libusb REQUIRED libusb-1.0)
 pkg_check_modules(gtk gtk+-3.0)
 
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99 -Wall -Wextra")
+function(add_cflag_if_supported flag)
+    string(REPLACE "-" "_" flagclean ${flag})
+    string(REPLACE "=" "_" flagclean ${flagclean})
+    string(REPLACE "+" "_" flagclean ${flagclean})
+    string(REPLACE "," "_" flagclean ${flagclean})
+    string(TOUPPER ${flagclean} flagclean)
+
+    check_c_compiler_flag(${flag} C_SUPPORTS${flagclean})
+
+    if (C_SUPPORTS${flagclean})
+        set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${flag}" PARENT_SCOPE)
+    endif()
+endfunction()
+
+add_cflag_if_supported("-std=gnu99")
+add_cflag_if_supported("-Wall")
+add_cflag_if_supported("-Wextra")
+add_cflag_if_supported("-Wshadow")
+add_cflag_if_supported("-D_FORTIFY_SOURCE=2")
+add_cflag_if_supported("-fstrict-aliasing")
+add_cflag_if_supported("-Wformat")
+add_cflag_if_supported("-Wformat-security")
+add_cflag_if_supported("-Wmaybe-uninitialized")
+add_cflag_if_supported("-Wmissing-variable-declarations")
+add_cflag_if_supported("-Wshorten-64-to-32")
+add_cflag_if_supported("-Wimplicit-function-declaration")
+add_cflag_if_supported("-Wredundant-decls")
+add_cflag_if_supported("-Wundef")
+
+if(${CMAKE_BUILD_TYPE} MATCHES "Debug")
+    include(CTest)
+    add_cflag_if_supported("-ggdb")
+    add_cflag_if_supported("-O0")
+elseif()
+    add_cflag_if_supported("-O2")
+endif()
 
 set(HFILES src/stlink-common.h
            src/stlink-usb.h
@@ -24,34 +60,35 @@ include_directories(${libusb_INCLUDE_DIRS})
 include_directories(src)
 include_directories(mingw)
 
-add_library(stlink STATIC
+add_library(${PROJECT_NAME} STATIC
             ${HFILES} # header files for ide projects generated by cmake
             ${CFILES})
-target_link_libraries(stlink ${libusb_LDFLAGS})
+target_link_libraries(${PROJECT_NAME} ${libusb_LDFLAGS})
 
 add_executable(st-flash flash/main.c)
-target_link_libraries(st-flash stlink)
+target_link_libraries(st-flash ${PROJECT_NAME})
+
+add_executable(st-info src/st-info.c)
+target_link_libraries(st-info ${PROJECT_NAME})
+
+add_executable(st-probe src/st-probe.c)
+target_link_libraries(st-probe ${PROJECT_NAME})
 
 add_executable(st-util gdbserver/gdb-remote.c
                        gdbserver/gdb-remote.h
                        gdbserver/gdb-server.c
                        gdbserver/gdb-server.h)
-target_link_libraries(st-util stlink)
+target_link_libraries(st-util ${PROJECT_NAME})
 
-add_executable(st-info src/st-info.c)
-target_link_libraries(st-info stlink)
-
-add_executable(st-probe src/st-probe.c)
-target_link_libraries(st-probe stlink)
-
-install(TARGETS  stlink st-flash st-util st-info st-probe
+install(TARGETS ${PROJECT_NAME} st-flash st-util st-info st-probe
         RUNTIME DESTINATION bin
-        ARCHIVE DESTINATION lib)
+        ARCHIVE DESTINATION lib
+)
 
 if(NOT MINGW)
   list(APPEND CFILES src/st-term.c)
   add_executable(st-term src/st-term.c)
-  target_link_libraries(st-term stlink)
+  target_link_libraries(st-term ${PROJECT_NAME})
 
   install(TARGETS st-term
           RUNTIME DESTINATION bin)
@@ -78,4 +115,3 @@ if(gtk_FOUND)
   install(FILES gui/stlink-gui.ui
           DESTINATION ${INSTALLED_UI_DIR})
 endif()
-
-- 
2.30.2