From aa57890554cb4f8b4ccf35a69598238a12a79069 Mon Sep 17 00:00:00 2001 From: Antonio Borneo Date: Mon, 19 Sep 2022 14:50:26 +0200 Subject: [PATCH] target/riscv-013: fix unused initialization Scan-build reports: Unused code: Dead initialization riscv-013.c:2362 Value stored to 'control' during its initialization is never read Remove the initialization of variable 'control'. Change-Id: I548f8175530b9a2aa4c1788549d6467bf9824584 Signed-off-by: Antonio Borneo Reviewed-on: https://review.openocd.org/c/openocd/+/7206 Reviewed-by: Tim Newsome Reviewed-by: Jan Matyas Tested-by: jenkins --- src/target/riscv/riscv-013.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/target/riscv/riscv-013.c b/src/target/riscv/riscv-013.c index 1f4c34346..99d3873de 100644 --- a/src/target/riscv/riscv-013.c +++ b/src/target/riscv/riscv-013.c @@ -2359,9 +2359,7 @@ static int assert_reset(struct target *target) /* TODO: Try to use hasel in dmcontrol */ /* Set haltreq for each hart. */ - uint32_t control = control_base; - - control = set_hartsel(control_base, target->coreid); + uint32_t control = set_hartsel(control_base, target->coreid); control = set_field(control, DM_DMCONTROL_HALTREQ, target->reset_halt ? 1 : 0); dmi_write(target, DM_DMCONTROL, control); -- 2.30.2