From 9849883a754a73b861dd7be530753ff5c2abb499 Mon Sep 17 00:00:00 2001 From: Keith Packard Date: Wed, 24 Aug 2011 01:48:28 -0700 Subject: [PATCH] altosui: Don't trust companion telemetry record 'channels' count It can be bogus, allowing the code to walk off the end of the allocated data array. Signed-off-by: Keith Packard --- altosui/AltosTelemetryRecordCompanion.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/altosui/AltosTelemetryRecordCompanion.java b/altosui/AltosTelemetryRecordCompanion.java index 11b349e1..52d7f4cf 100644 --- a/altosui/AltosTelemetryRecordCompanion.java +++ b/altosui/AltosTelemetryRecordCompanion.java @@ -36,7 +36,7 @@ public class AltosTelemetryRecordCompanion extends AltosTelemetryRecordRaw { companion.tick = tick; companion.board_id = uint8(5); companion.update_period = uint8(6+off); - for (int i = 0; i < channels; i++) + for (int i = 0; i < companion.companion_data.length; i++) companion.companion_data[i] = uint16(8 + off + i * 2); } -- 2.30.2