From 57c1320962ad08d52e89d39bd5852f8d228dd872 Mon Sep 17 00:00:00 2001 From: Keith Packard Date: Thu, 21 Apr 2016 22:37:35 -0400 Subject: [PATCH] altosdroid: Can only use message once And here I thought re-using the message was clever. That generates a nice exception and crashes the program. Signed-off-by: Keith Packard --- .../src/org/altusmetrum/AltosDroid/TelemetryService.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/altosdroid/src/org/altusmetrum/AltosDroid/TelemetryService.java b/altosdroid/src/org/altusmetrum/AltosDroid/TelemetryService.java index 6edc20c7..63592e29 100644 --- a/altosdroid/src/org/altusmetrum/AltosDroid/TelemetryService.java +++ b/altosdroid/src/org/altusmetrum/AltosDroid/TelemetryService.java @@ -248,7 +248,7 @@ public class TelemetryService extends Service implements LocationListener { /* On connect, send the current state to the new client */ - send_to_client(client, message()); + send_to_client(client); /* If we've got an address from a previous session, then * go ahead and try to reconnect to the device @@ -275,7 +275,8 @@ public class TelemetryService extends Service implements LocationListener { } } - private void send_to_client(Messenger client, Message m) { + private void send_to_client(Messenger client) { + Message m = message(); try { client.send(m); } catch (RemoteException e) { @@ -285,9 +286,8 @@ public class TelemetryService extends Service implements LocationListener { } private void send_to_clients() { - Message m = message(); for (Messenger client : clients) - send_to_client(client, m); + send_to_client(client); } private void disconnect(boolean notify) { -- 2.30.2