ao-tools: Add lots of compiler warning flags to ao-tools build
authorKeith Packard <keithp@keithp.com>
Thu, 3 Jan 2019 19:40:32 +0000 (11:40 -0800)
committerKeith Packard <keithp@keithp.com>
Thu, 3 Jan 2019 19:40:32 +0000 (11:40 -0800)
This catches some uninitialized variable errors which cause
ao-cal-accel to crash (fixes coming next)

Signed-off-by: Keith Packard <keithp@keithp.com>
31 files changed:
ao-tools/ao-bitbang/Makefile.am
ao-tools/ao-bm70/Makefile.am [new file with mode: 0644]
ao-tools/ao-boot-stm32/Makefile.am [new file with mode: 0644]
ao-tools/ao-cal-accel/Makefile.am
ao-tools/ao-cal-freq/Makefile.am
ao-tools/ao-chaosread/Makefile.am
ao-tools/ao-dbg/Makefile.am
ao-tools/ao-dump-up/Makefile.am
ao-tools/ao-dumpflash/Makefile.am
ao-tools/ao-dumplog/Makefile.am
ao-tools/ao-edit-telem/Makefile.am
ao-tools/ao-eeprom/Makefile.am
ao-tools/ao-elftohex/Makefile.am
ao-tools/ao-list/Makefile.am
ao-tools/ao-load/Makefile.am
ao-tools/ao-makebin/Makefile.am
ao-tools/ao-mega/Makefile.am
ao-tools/ao-postflight/Makefile.am
ao-tools/ao-rawload/Makefile.am
ao-tools/ao-send-telem/Makefile.am
ao-tools/ao-sky-flash/Makefile.am
ao-tools/ao-stmload/Makefile.am
ao-tools/ao-telem/Makefile.am
ao-tools/ao-test-baro/Makefile.am
ao-tools/ao-test-flash/Makefile.am
ao-tools/ao-test-gps/Makefile.am
ao-tools/ao-test-igniter/Makefile.am
ao-tools/ao-usbload/Makefile.am
ao-tools/ao-usbtrng/Makefile.am
ao-tools/ao-view/Makefile.am
configure.ac

index f01cddd47d5e940f34d6efcbda9194cff7452838..b42885a40d0f8fd6a3f70e850dc6edbf8b60e205 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-bitbang
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_BITBANG_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_bitbang_DEPENDENCIES = $(AO_BITBANG_LIBS)
diff --git a/ao-tools/ao-bm70/Makefile.am b/ao-tools/ao-bm70/Makefile.am
new file mode 100644 (file)
index 0000000..f13ce0f
--- /dev/null
@@ -0,0 +1,7 @@
+bin_PROGRAMS=ao-bm70
+
+AM_CFLAGS=-O0 -g
+
+ao_bm70_SOURCES = ao-bm70.c
+
+man_MANS=ao-bm70.1
diff --git a/ao-tools/ao-boot-stm32/Makefile.am b/ao-tools/ao-boot-stm32/Makefile.am
new file mode 100644 (file)
index 0000000..581eb2d
--- /dev/null
@@ -0,0 +1,9 @@
+bin_PROGRAMS=ao-chaosread
+
+AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+
+ao_chaosread_LDADD=$(LIBUSB_LIBS)
+
+ao_chaosread_SOURCES = ao-chaosread.c
+
+man_MANS = ao-chaosread.1
index d278097a27e434f6315c00ca03c801363b6e05a2..49997252d941c6513b7a1df4715700352f2d2658 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-cal-accel
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 
 ao_cal_accel_DEPENDENCIES = $(top_builddir)/ao-tools/lib/libao-tools.a
 
index e11c2b0aa50cdcc33f65a985eb62f86015945805..eccfde242bc1b2aad9bf135dfa969a40407397c5 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-cal-freq
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 
 ao_cal_freq_DEPENDENCIES = $(top_builddir)/ao-tools/lib/libao-tools.a
 
index 6ba8885ce12dd1ebb5f3c113b842cc42f5e1e1d8..d2bf0e9108acb84179ec06b1295715d56596b14e 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-chaosread
 
-AM_CFLAGS=$(LIBUSB_CFLAGS) -Wall -Wextra
+AM_CFLAGS=$(WARN_CFLAGS) $(LIBUSB_CFLAGS) -Wall -Wextra
 
 ao_chaosread_LDADD=$(LIBUSB_LIBS)
 
index 2c33cf0677cee345151df0716a580971c4454be2..e2fe65421a23c08c7114bd9256e40eaaad34ba08 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-dbg
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_DBG_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 man_MANS = ao-dbg.1
index 94bb94a909b02c7f5004f604a130900b64f5727b..a5395a42222d7651caa8d3b5e903af3ea1a739a9 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-dump-up
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS) $(GNOME_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS) $(GNOME_CFLAGS)
 AO_DUMP_LOG_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_dump_up_DEPENDENCIES = $(AO_DUMP_LOG_LIBS)
index db99f5aedebd078c97ff6c205a3c107d942efc00..2b134f94e522f5bc603ae3bb00bb8842022fb584 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-dumpflash
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_DUMPLOG_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_dumpflash_DEPENDENCIES = $(AO_DUMPLOG_LIBS)
index a80cac33f6196a64ed4a8f9d9284cec658b8b39a..bd4a8707bd2c230640525e639d861196a7690b88 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-dumplog
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS) $(GNOME_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS) $(GNOME_CFLAGS)
 AO_DUMPLOG_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_dumplog_DEPENDENCIES = $(AO_DUMPLOG_LIBS)
index c5965c4707b852c79ec5e8345ba18f3f0b5d633a..154d6395db0bc2f893f4dffed60b06c411e75949 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-edit-telem
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_POSTFLIGHT_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_edit_telem_DEPENDENCIES = $(AO_POSTFLIGHT_LIBS)
index efeed97689d40c832d7b4c4a249c4f973a023b7d..6c5e038315c7e2af57f59b30b0f08291bd761848 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-eeprom
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_EEPROM_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_eeprom_DEPENDENCIES = $(AO_EEPROM_LIBS)
index dd0046d7b04bfbb56c26c5e5283776dae66d3d0b..5e1975e742b7bbf672c6a3c71d4a565391177f14 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-elftohex
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_ELFTOHEX_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_elftohex_DEPENDENCIES = $(AO_ELFTOHEX_LIBS)
index de3c4deb8dc051c74c1853d4757c1940cd2835a5..a3fbfa83a423941caa8a27b4c329b99c6de23e88 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-list
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_LIST_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_list_DEPENDENCIES = $(AO_LIST_LIBS)
index 3c48dc27eb4a70ed1801d1c3ac125043a2f80499..b92a9c8723a79005505cf72a43b959c8204f7be0 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-load
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_LOAD_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_load_DEPENDENCIES = $(AO_LOAD_LIBS)
index 758097a4c297e12cc498da96b26765cb65311b7c..0946fb23225fb951e8bc83f8012854b56e5b857d 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-makebin
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_ELFTOHEX_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_makebin_DEPENDENCIES = $(AO_ELFTOHEX_LIBS)
index 22b62608f471b41e2cd3c369db5c6a9129964f26..1a221b681e38bf65613da3a33b032ecea1bfc641 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-mega
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_POSTFLIGHT_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_mega_DEPENDENCIES = $(AO_POSTFLIGHT_LIBS)
index 589d164a40616746755dc3e357e12146cb693d74..892c62c6b04edcec08a0355a6208438e3831e930 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-postflight
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS) $(GNOME_CFLAGS) $(PLPLOT_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS) $(GNOME_CFLAGS) $(PLPLOT_CFLAGS)
 AO_POSTFLIGHT_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_postflight_DEPENDENCIES = $(AO_POSTFLIGHT_LIBS)
index d2c55658804419875bf31d8fa1e668185c5e5055..64880549dee222f9b5c0bc5f0ea80c0ea5a593e1 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-rawload
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_RAWLOAD_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_rawload_DEPENDENCIES = $(AO_RAWLOAD_LIBS)
index bfddf131c895e0414cfaae9bb1b29475c7ec2b44..227e714f39fd86f2095d483963b0c5a2d52be1cb 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-send-telem
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_POSTFLIGHT_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_send_telem_DEPENDENCIES = $(AO_POSTFLIGHT_LIBS)
index f6c5089a0ddf150d49ff7fcdb5ffa474807e20f8..9e3f2c1216eacb5a1f04a181d061dcbe574c0420 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-sky-flash
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_SKY_FLASH_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_sky_flash_DEPENDENCIES = $(AO_SKY_FLASH_LIBS)
index 45eb6216787f5afe2d50e68f497eb9b34744c914..a049f275ffe07812926a20af3ee826b7d385942c 100644 (file)
@@ -2,7 +2,7 @@ if LIBSTLINK
 
 bin_PROGRAMS=ao-stmload
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(STLINK_CFLAGS) $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(STLINK_CFLAGS) $(LIBUSB_CFLAGS)
 AO_STMLOAD_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_stmload_DEPENDENCIES = $(AO_STMLOAD_LIBS)
index 3436443ebb346872b8ab79c913dc151c378f1f8a..8cc05ce315c23788003c1c9a83d92e18d755655c 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-telem
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_POSTFLIGHT_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_telem_DEPENDENCIES = $(AO_POSTFLIGHT_LIBS)
index 69e47529cb5613c8602873d972040d018b77cc6b..c4d8cf252c120f08a97c167c468f95858438367b 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-test-baro
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 
 ao_test_baro_DEPENDENCIES = $(top_builddir)/ao-tools/lib/libao-tools.a
 
index 0323c28240f6c8eefc995c22313546fedc39ca6f..e01c7a63e304b6949e4dc3d6cff968bc4b91a89c 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-test-flash
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 
 ao_test_flash_DEPENDENCIES = $(top_builddir)/ao-tools/lib/libao-tools.a
 
index d89ddddd61e5f4f4773e60d757b06959178e532e..db28891dda2eaf6ee437bfa282e2756961386dd8 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-test-gps
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 
 ao_test_gps_DEPENDENCIES = $(top_builddir)/ao-tools/lib/libao-tools.a
 
index e24ed469fb283686af98e5a68f1d4e8d63c20c77..6c9efddba76570108a395a418cbc8e116dd066a5 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-test-igniter
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 
 ao_test_igniter_DEPENDENCIES = $(top_builddir)/ao-tools/lib/libao-tools.a
 
index e3b63a85f6fffeb01c0451a3bac4946397f16292..9a05d5c40352fc25168dfa9d38234100d0ae1255 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-usbload
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 AO_STMLOAD_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
 
 ao_usbload_DEPENDENCIES = $(AO_STMLOAD_LIBS)
index 5cbab5cf48da64219164ea9dea96072d43cde86f..14113a8225f5b185cfcf99862a62fbfb8e855f0c 100644 (file)
@@ -1,6 +1,6 @@
 bin_PROGRAMS=ao-usbtrng
 
-AM_CFLAGS=-I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
+AM_CFLAGS=$(WARN_CFLAGS) -I$(top_srcdir)/ao-tools/lib $(LIBUSB_CFLAGS)
 
 ao_usbtrng_DEPENDENCIES = $(top_builddir)/ao-tools/lib/libao-tools.a
 
index 7a288417b10f161d874a607fc2764191e40c25a7..3cdf1dddf01aa16b8c4eaaef09e69d3e12bb0696 100644 (file)
@@ -2,7 +2,7 @@ VERSION=$(shell git describe)
 
 AO_VIEW_CFLAGS=-I$(top_srcdir)/ao-tools/lib
 AO_VIEW_LIBS=$(top_builddir)/ao-tools/lib/libao-tools.a
-AM_CFLAGS=$(AO_VIEW_CFLAGS) $(GNOME_CFLAGS) $(ALSA_CFLAGS) -I$(top_srcdir)/src -DAOVIEW_VERSION=\"$(VERSION)\" @FLITE_INCS@
+AM_CFLAGS=$(WARN_CFLAGS) $(AO_VIEW_CFLAGS) $(GNOME_CFLAGS) $(ALSA_CFLAGS) -I$(top_srcdir)/src -DAOVIEW_VERSION=\"$(VERSION)\" @FLITE_INCS@
 
 bin_PROGRAMS=ao-view
 
index abaec2cdb7d25df3c1240755438babf8f8cfa39f..32fcea3a344f9fba60dbd84a339c7376e1a0717b 100644 (file)
@@ -184,6 +184,9 @@ else
        HAVE_GOOGLE_KEY="no"
 fi
 
+WARN_CFLAGS="-Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs"
+AC_SUBST(WARN_CFLAGS)
+
 AC_ARG_ENABLE(faketime, AS_HELP_STRING([--enable-faketime],
               [Use faketime program to ensure pdf files are reproducible (default=no)]),
              [FAKETIME=$enableval], [FAKETIME=no])