X-Git-Url: https://git.gag.com/?p=fw%2Faltos;a=blobdiff_plain;f=altosui%2FAltosSerial.java;h=74e945f3eff7d31d29ca6ff6af57b7615745ec5c;hp=5e496d7f3d8070181018d48edc09c50255fc0a38;hb=3c2f601139d36761de6a8a2210545d082ef16133;hpb=7146311d9df541e075b4450cf9656a9aa7ffdd93

diff --git a/altosui/AltosSerial.java b/altosui/AltosSerial.java
index 5e496d7f..74e945f3 100644
--- a/altosui/AltosSerial.java
+++ b/altosui/AltosSerial.java
@@ -31,6 +31,7 @@ import java.awt.event.*;
 import javax.swing.*;
 import javax.swing.filechooser.FileNameExtensionFilter;
 import javax.swing.table.*;
+import org.altusmetrum.AltosLib.*;
 
 import libaltosJNI.*;
 
@@ -55,7 +56,7 @@ public class AltosSerial implements Runnable {
 	boolean monitor_mode;
 	int telemetry;
 	double frequency;
-	static boolean debug;
+	public static boolean debug;
 	boolean remote;
 	LinkedList<String> pending_output = new LinkedList<String>();
 	Frame frame;
@@ -187,7 +188,7 @@ public class AltosSerial implements Runnable {
 		return abort;
 	}
 
-	public void flush_input() {
+	public void flush_input() throws InterruptedException {
 		flush_output();
 		boolean	got_some;
 
@@ -195,10 +196,7 @@ public class AltosSerial implements Runnable {
 		if (remote)
 			timeout = 500;
 		do {
-			try {
-				Thread.sleep(timeout);
-			} catch (InterruptedException ie) {
-			}
+			Thread.sleep(timeout);
 			got_some = !reply_queue.isEmpty();
 			synchronized(this) {
 				if (!"VERSION".startsWith(line) &&
@@ -213,31 +211,38 @@ public class AltosSerial implements Runnable {
 
 	public String get_reply(int timeout) throws InterruptedException {
 		boolean	can_cancel = true;
-		++in_reply;
+		String	reply = null;
 
-		if (SwingUtilities.isEventDispatchThread()) {
-			can_cancel = false;
-			if (remote)
-				System.out.printf("Uh-oh, reading remote serial device from swing thread\n");
-		}
-		flush_output();
-		if (remote && can_cancel) {
-			timeout = 500;
-		}
-		abort = false;
-		timeout_started = false;
-		for (;;) {
-			AltosLine line = reply_queue.poll(timeout, TimeUnit.MILLISECONDS);
-			if (line != null) {
-				stop_timeout_dialog();
-				--in_reply;
-				return line.line;
+		try {
+			++in_reply;
+
+			if (SwingUtilities.isEventDispatchThread()) {
+				can_cancel = false;
+				if (remote)
+					System.out.printf("Uh-oh, reading remote serial device from swing thread\n");
 			}
-			if (!remote || !can_cancel || check_timeout()) {
-				--in_reply;
-				return null;
+			flush_output();
+			if (remote && can_cancel) {
+				timeout = 500;
 			}
+			abort = false;
+			timeout_started = false;
+			for (;;) {
+				AltosLine line = reply_queue.poll(timeout, TimeUnit.MILLISECONDS);
+				if (line != null) {
+					stop_timeout_dialog();
+					reply = line.line;
+					break;
+				}
+				if (!remote || !can_cancel || check_timeout()) {
+					reply = null;
+					break;
+				}
+			}
+		} finally {
+			--in_reply;
 		}
+		return reply;
 	}
 
 	public String get_reply() throws InterruptedException {
@@ -264,8 +269,12 @@ public class AltosSerial implements Runnable {
 	}
 
 	public void close() {
-		if (remote)
-			stop_remote();
+		if (remote) {
+			try {
+				stop_remote();
+			} catch (InterruptedException ie) {
+			}
+		}
 		if (in_reply != 0)
 			System.out.printf("Uh-oh. Closing active serial device\n");
 
@@ -315,8 +324,10 @@ public class AltosSerial implements Runnable {
 		}
 		altos = device.open();
 		if (altos == null) {
+			final String	message = device.getErrorString();
 			close();
-			throw new FileNotFoundException(device.toShortString());
+			throw new FileNotFoundException(String.format("%s (%s)",
+								      device.toShortString(), message));
 		}
 		if (debug)
 			System.out.printf("Open %s\n", device.getPath());
@@ -345,18 +356,36 @@ public class AltosSerial implements Runnable {
 	private void set_radio_setting(int setting) {
 		if (altos != null) {
 			if (monitor_mode)
-				printf("m 0\nc R %d\nc r 0\nm %x\n",
+				printf("m 0\nc R %d\nm %x\n",
 				       setting, telemetry_len());
 			else
-				printf("c R %d\nc r 0\n", setting);
+				printf("c R %d\n", setting);
+			flush_output();
+		}
+	}
+
+	private void set_radio_freq(int frequency) {
+		if (altos != null) {
+			if (monitor_mode)
+				printf("m 0\nc F %d\nm %x\n",
+				       frequency, telemetry_len());
+			else
+				printf("c F %d\n", frequency);
 			flush_output();
 		}
 	}
 
 	public void set_radio_frequency(double frequency,
+					boolean has_frequency,
 					boolean has_setting,
 					int cal) {
-		if (has_setting)
+		if (debug)
+			System.out.printf("set_radio_frequency %7.3f (freq %b) (set %b) %d\n", frequency, has_frequency, has_setting, cal);
+		if (frequency == 0)
+			return;
+		if (has_frequency)
+			set_radio_freq((int) Math.floor (frequency * 1000));
+		else if (has_setting)
 			set_radio_setting(AltosConvert.radio_frequency_to_setting(frequency, cal));
 		else
 			set_channel(AltosConvert.radio_frequency_to_channel(frequency));
@@ -364,8 +393,11 @@ public class AltosSerial implements Runnable {
 
 	public void set_radio_frequency(double in_frequency) throws InterruptedException, TimeoutException {
 		frequency = in_frequency;
+		if (frequency == 0.0)
+			frequency = AltosPreferences.frequency(device.getSerial());
 		config_data();
 		set_radio_frequency(frequency,
+				    config_data.radio_frequency != 0,
 				    config_data.radio_setting != 0,
 				    config_data.radio_calibration);
 	}
@@ -405,17 +437,17 @@ public class AltosSerial implements Runnable {
 
 	public void start_remote() throws TimeoutException, InterruptedException {
 		if (debug)
-			System.out.printf("start remote\n");
+			System.out.printf("start remote %7.3f\n", frequency);
 		if (frequency == 0.0)
-			frequency = AltosPreferences.frequency(device.getSerial());
+			frequency = AltosUIPreferences.frequency(device.getSerial());
 		set_radio_frequency(frequency);
-		set_callsign(AltosPreferences.callsign());
+		set_callsign(AltosUIPreferences.callsign());
 		printf("p\nE 0\n");
 		flush_input();
 		remote = true;
 	}
 
-	public void stop_remote() {
+	public void stop_remote() throws InterruptedException {
 		if (debug)
 			System.out.printf("stop remote\n");
 		try {