Telemetry code was mis-computing RSSI

[fw/altos] / ao-tools / lib / cc-telem.c

diff --git a/ao-tools/lib/cc-telem.c b/ao-tools/lib/cc-telem.c
index 9a2f6155a4345ce12bd22e022a83a89dc590237f..aa52b7c5b14ce863b4c663679072107fc8c0a0a2 100644 (file)
--- a/ao-tools/lib/cc-telem.c
+++ b/ao-tools/lib/cc-telem.c
@@ -101,6 +101,10 @@ cc_telem_parse(const char *input_line, struct cc_telem *telem)
                telem->flight = 0;
 
        cc_parse_int(&telem->rssi, words[5]);
+       if (version <= 2) {
+               /* Older telemetry versions mis-computed the rssi value */
+               telem->rssi = (telem->rssi + 74) / 2 - 74;
+       }
        cc_parse_string(telem->state, sizeof (telem->state), words[9]);
        cc_parse_int(&telem->tick, words[10]);
        cc_parse_int(&telem->accel, words[12]);
@@ -178,18 +182,25 @@ cc_telem_parse(const char *input_line, struct cc_telem *telem)
        }
        if (tracking_pos >= 0 && nword >= tracking_pos + 2 && strcmp(words[tracking_pos], "SAT") == 0) {
                int     c, n, pos;
+               int     per_sat;
+               int     state;
+
+               if (version >= 2)
+                       per_sat = 2;
+               else
+                       per_sat = 3;
                cc_parse_int(&n, words[tracking_pos + 1]);
                pos = tracking_pos + 2;
-               if (nword >= pos + n * 3) {
+               if (nword >= pos + n * per_sat) {
                        telem->gps_tracking.channels = n;
                        for (c = 0; c < n; c++) {
                                cc_parse_int(&telem->gps_tracking.sats[c].svid,
                                                 words[pos + 0]);
-                               cc_parse_hex(&telem->gps_tracking.sats[c].state,
-                                                words[pos + 1]);
+                               if (version < 2)
+                                       cc_parse_hex(&state, words[pos + 1]);
                                cc_parse_int(&telem->gps_tracking.sats[c].c_n0,
-                                                words[pos + 2]);
-                               pos += 3;
+                                                words[pos + per_sat - 1]);
+                               pos += per_sat;
                        }
                } else {
                        telem->gps_tracking.channels = 0;