From 95499d5d9525e155075240e5ce2a2711652a4808 Mon Sep 17 00:00:00 2001 From: borutr Date: Thu, 29 Aug 2002 16:30:36 +0000 Subject: [PATCH] corrected improper use of assert git-svn-id: https://sdcc.svn.sourceforge.net/svnroot/sdcc/trunk/sdcc@2090 4a8a32a2-be11-0410-ad9d-d568d2c75423 --- ChangeLog | 7 +++++++ src/ds390/ralloc.c | 3 ++- src/mcs51/ralloc.c | 3 ++- src/z80/ralloc.c | 3 ++- 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index b1309016..deccf639 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2002-08-29 Borut Razem + * sdcc/src/ds390/ralloc.c, sdcc/src/mcs51/ralloc.c, sdcc/src/z80/ralloc.c: + corrected improper use of assert: the assignment to clr variable was done inside the assert. + In case that NDEBUG was defined, the assert macro was substituted with no-op, so the assignment + was not executed, and the compiler (cl) launched a warning: + ralloc.c(1442) : warning C4700: local variable 'clr' used without having been initialized + 2002-08-28 Bernhard Held * src/SDCCglue.c (printIvalArray): iterative calculation of array length diff --git a/src/ds390/ralloc.c b/src/ds390/ralloc.c index 5a0fad33..7174970b 100644 --- a/src/ds390/ralloc.c +++ b/src/ds390/ralloc.c @@ -1436,7 +1436,8 @@ static void fillGaps() bitVectBitValue(_G.totRegAssigned,i) == 0) /* and are still assigned to registers */ continue ; - assert (clr = hTabItemWithKey(liveRanges,i)); + clr = hTabItemWithKey(liveRanges,i); + assert(clr); /* mark these registers as used */ for (k = 0 ; k < clr->nRegs ; k++ ) diff --git a/src/mcs51/ralloc.c b/src/mcs51/ralloc.c index ddfef2de..4c326f7c 100644 --- a/src/mcs51/ralloc.c +++ b/src/mcs51/ralloc.c @@ -1267,7 +1267,8 @@ static void fillGaps() bitVectBitValue(_G.totRegAssigned,i) == 0) /* and are still assigned to registers */ continue ; - assert (clr = hTabItemWithKey(liveRanges,i)); + clr = hTabItemWithKey(liveRanges,i); + assert(clr); /* mark these registers as used */ for (k = 0 ; k < clr->nRegs ; k++ ) diff --git a/src/z80/ralloc.c b/src/z80/ralloc.c index 1f0aa6b2..72331e49 100644 --- a/src/z80/ralloc.c +++ b/src/z80/ralloc.c @@ -1231,7 +1231,8 @@ static void fillGaps() bitVectBitValue(_G.totRegAssigned,i) == 0) /* and are still assigned to registers */ continue ; - assert (clr = hTabItemWithKey(liveRanges,i)); + clr = hTabItemWithKey(liveRanges,i); + assert(clr); /* mark these registers as used */ for (k = 0 ; k < clr->nRegs ; k++ ) -- 2.47.2