From 79bace9eb9e441405535e082f3f0ee1a26740fe0 Mon Sep 17 00:00:00 2001
From: Josh Blum <josh@joshknows.com>
Date: Sat, 5 Sep 2009 21:11:51 -0700
Subject: [PATCH] renamed params dialog to props dialog

---
 grc/gui/ActionHandler.py                    | 4 ++--
 grc/gui/Makefile.am                         | 2 +-
 grc/gui/{ParamsDialog.py => PropsDialog.py} | 2 +-
 grc/todo.txt                                | 2 ++
 4 files changed, 6 insertions(+), 4 deletions(-)
 rename grc/gui/{ParamsDialog.py => PropsDialog.py} (99%)

diff --git a/grc/gui/ActionHandler.py b/grc/gui/ActionHandler.py
index 8f317d6a..f1289357 100644
--- a/grc/gui/ActionHandler.py
+++ b/grc/gui/ActionHandler.py
@@ -31,7 +31,7 @@ import Messages
 from .. base import ParseXML
 import random
 from MainWindow import MainWindow
-from ParamsDialog import ParamsDialog
+from PropsDialog import PropsDialog
 import Dialogs
 from FileDialogs import OpenFlowGraphFileDialog, SaveFlowGraphFileDialog, SaveImageFileDialog
 
@@ -240,7 +240,7 @@ class ActionHandler:
 		##################################################
 		elif state == Actions.BLOCK_PARAM_MODIFY:
 			selected_block = self.get_flow_graph().get_selected_block()
-			if selected_block and ParamsDialog(selected_block).run():
+			if selected_block and PropsDialog(selected_block).run():
 				self.get_flow_graph().update()
 				self.get_page().get_state_cache().save_new_state(self.get_flow_graph().export_data())
 				self.get_page().set_saved(False)
diff --git a/grc/gui/Makefile.am b/grc/gui/Makefile.am
index cb45d535..b14817d0 100644
--- a/grc/gui/Makefile.am
+++ b/grc/gui/Makefile.am
@@ -43,7 +43,7 @@ ourpython_PYTHON = \
 	MainWindow.py \
 	Messages.py \
 	NotebookPage.py \
-	ParamsDialog.py \
+	PropsDialog.py \
 	Preferences.py \
 	StateCache.py \
 	__init__.py
diff --git a/grc/gui/ParamsDialog.py b/grc/gui/PropsDialog.py
similarity index 99%
rename from grc/gui/ParamsDialog.py
rename to grc/gui/PropsDialog.py
index ccf19d1a..200cff1f 100644
--- a/grc/gui/ParamsDialog.py
+++ b/grc/gui/PropsDialog.py
@@ -37,7 +37,7 @@ def get_title_label(title):
 	hbox.pack_start(label, False, False, padding=11)
 	return hbox
 
-class ParamsDialog(gtk.Dialog):
+class PropsDialog(gtk.Dialog):
 	"""A dialog box to set block parameters."""
 
 	def __init__(self, block):
diff --git a/grc/todo.txt b/grc/todo.txt
index ca9a6818..8afd2f14 100644
--- a/grc/todo.txt
+++ b/grc/todo.txt
@@ -73,6 +73,8 @@
   * will not update for non-enum params
   * needs to account for added or removed params
   * example with grid params need update after notebook change
+  * idea: hash the current param keys list and types,
+    if changed, redo the whole dialog (params part)
 
 ##################################################
 # Future
-- 
2.47.2