Zachary T Welch [Fri, 27 Nov 2009 19:02:54 +0000 (11:02 -0800)]
update minidummy interface driver command handling
Changes the interface definition field reference from register_commands
to commands, which allows the module to compile.
Zachary T Welch [Fri, 27 Nov 2009 17:57:25 +0000 (09:57 -0800)]
fix 'nand info' command
Move device argument parsing after check for number of arguments;
otherwise, calling this command without any arguments would access
argv[0] before checking whether it even existed.
Øyvind Harboe [Fri, 27 Nov 2009 18:41:22 +0000 (19:41 +0100)]
zy1000: keep up with changes to log_init()
fn's and return value for log_init() changed to void.
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Øyvind Harboe [Fri, 27 Nov 2009 08:10:37 +0000 (09:10 +0100)]
minidummy: fix compilation error
during refactoring a search and replace error crept in
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Dean Glazeski [Mon, 16 Nov 2009 18:47:45 +0000 (12:47 -0600)]
ARM NAND I/O header documentation update.
Fixed the header file to properly specify the doxygen documentation for the
items defined in it.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Dean Glazeski [Mon, 16 Nov 2009 18:43:39 +0000 (12:43 -0600)]
ARM NAND I/O documentation update.
This updates the functions in the file to all have doxygen comments
describing what they do.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Dean Glazeski [Mon, 16 Nov 2009 18:26:21 +0000 (12:26 -0600)]
ARM NAND I/O refactor code copying.
Created a function for copying code to the working area on
a target. The NAND write and read functions are updated to
include use of this function.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Dean Glazeski [Sun, 15 Nov 2009 08:32:38 +0000 (02:32 -0600)]
ARM NAND I/O read function.
Implementation of the NAND read function for ARM NAND I/O that
includes running a local algorithm on a device to increase the
performance of block reads.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Dean Glazeski [Tue, 17 Nov 2009 20:16:23 +0000 (14:16 -0600)]
NAND Flash documentation update.
Updated doxygen comments for different interface structures for
the NAND interface.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
David Brownell [Thu, 26 Nov 2009 20:00:56 +0000 (12:00 -0800)]
XScale: add stub {read,write}_phys routines
Just make these fail, instead of letting them write over
potentially random memory. Users should be able to work
around the lack of real implementations by disbling the
MMU by hand ... until someone provides a Real Fix.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Uwe Hermann [Tue, 24 Nov 2009 19:42:42 +0000 (20:42 +0100)]
update bug reporting information
The Berlios bug-tracker is disabled, bug reports go to the list.
Signed-off-by: Zachary T Welch <zw@superlucidity.net>
Uwe Hermann [Tue, 24 Nov 2009 19:28:21 +0000 (20:28 +0100)]
fix typos in documentation
Fixes some minor typos in the top-level documentation files.
Signed-off-by: Zachary T Welch <zw@superlucidity.net>
Uwe Hermann [Tue, 24 Nov 2009 19:01:15 +0000 (20:01 +0100)]
fix typos in source files
Correct some spelling errors in source comments and printed output.
Signed-off-by: Zachary T Welch <zw@superlucidity.net>
Øyvind Harboe [Tue, 24 Nov 2009 19:26:40 +0000 (20:26 +0100)]
styleguide: add some embedded style rules.
Embedded and pthreads rely on modest and predictable
stack usage.
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Eric Wetzel [Thu, 26 Nov 2009 15:54:45 +0000 (07:54 -0800)]
fix 'flash protect' and 'flash erase_sector'
Command upgrading introduced two off-by-one bugs in the flash commands.
This patch fixes the 'flash {protect,erase_sector}' commands to check
that they have been passed the correct number of arguments.
Ammended during commit to fix help text for 'erase_address' too.
David Brownell [Thu, 26 Nov 2009 00:38:08 +0000 (16:38 -0800)]
target: create and use target_name()
Several of the sites now using target_type_name() really
ought to be using an instance-specific name. Create a
function called target_name(), accessing the instance's
own (command) name.
Use it in several places that really should be displaying
instance-specific names. Also in several places which
were already doing so, but which had no wrapper to call.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
David Brownell [Thu, 26 Nov 2009 00:38:08 +0000 (16:38 -0800)]
target: target_get_name() --> target_type_name()
There are two names that may matter on a per-target basis.
One is a per-instance name (for example, "at91sam7s.cpu").
The other is the name of its type (for example, "arm7tdmi"),
which is shared among multiple targets.
Currently target_get_name() returns the type name, which is
misleading and is rarely appropriate for target diagnostics.
Rename that as target_type_name().
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
David Brownell [Thu, 26 Nov 2009 00:19:53 +0000 (16:19 -0800)]
omap3530.cfg: yes we have SRAM!
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
David Brownell [Thu, 26 Nov 2009 00:18:22 +0000 (16:18 -0800)]
ARM: minor armv4/armv5 cleanup
Lines of 300+ characters are still bad; debug tweaks.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
David Brownell [Thu, 26 Nov 2009 00:14:45 +0000 (16:14 -0800)]
ARM: comment tweaks in ADIv5
"OptimoDE DESS" is ARM's semicustom DSPish stuff.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
David Brownell [Thu, 26 Nov 2009 00:11:26 +0000 (16:11 -0800)]
ARM7/9: shrink run_algorithm_inner() lines
300+ characters is unreasonable. So is half that.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
David Brownell [Thu, 26 Nov 2009 00:05:35 +0000 (16:05 -0800)]
NEWS updates
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Zachary T Welch [Fri, 20 Nov 2009 15:06:32 +0000 (07:06 -0800)]
update NEWS with recent developments
Mention changes to flash bank command syntax, 'nand verify' command,
command error handling and reporting, and help/usage command upgrades.
Zachary T Welch [Wed, 25 Nov 2009 04:32:10 +0000 (20:32 -0800)]
use ARRAY_SIZE macro
Search and destroy lingering cases where the ARRAY_SIZE macro should
be used to convey more intrinsic meaning in the OpenOCD code.
Zachary T Welch [Mon, 23 Nov 2009 20:14:05 +0000 (12:14 -0800)]
support OPENOCD_DEBUG_LEVEL environment setting
Detect the OPENOCD_DEBUG_LEVEL setting in log_init(), allowing the
very early startup phases to be debugged.
Zachary T Welch [Sat, 21 Nov 2009 00:36:32 +0000 (16:36 -0800)]
log: improve initialization
Removes redundant assignment of start_ms from log_register_commands().
Eliminates command_context parameter and return value.
Adds Doxygen comment block for this API call.
Zachary T Welch [Wed, 25 Nov 2009 02:47:35 +0000 (18:47 -0800)]
update command handler documentation
Adds sections on command registration and chaining, giving an overview
to developers that want to use these features.
Zachary T Welch [Sun, 22 Nov 2009 06:09:53 +0000 (22:09 -0800)]
add 'testee' target type
Alliteration aside, this should provide the final piece of the puzzle
for developers that want to get started writing a new target type.
In this way, it also seeks to complement the 'dummy' interface driver
and 'faux' NOR flash driver.
Zachary T Welch [Sun, 22 Nov 2009 03:27:20 +0000 (19:27 -0800)]
improve command handling examples
Removes hello and foo commands from top-level registration. Instead,
the dummy interface driver and faux flash driver have been augmented
to register these commands as sub-commands.
Zachary T Welch [Wed, 25 Nov 2009 03:51:49 +0000 (19:51 -0800)]
add script_command_run helper
Eliminates duplicated code in script_command and handle_unknown_command.
Fixes bug with duplicated help output generated by placeholder commands.
Zachary T Welch [Wed, 25 Nov 2009 03:13:03 +0000 (19:13 -0800)]
encapsulate and re-use log capture, retval setup
Factors log capture while running script commands, eliminating
duplicated code between script_command and jim_capture. Factors
setting a command's Jim "retval" into a new helper as well.
Using these new helpers in the new unknown command handler's
fixes possible regressions caused by these bits being missing.
Zachary T Welch [Wed, 25 Nov 2009 06:18:28 +0000 (22:18 -0800)]
combine help and usage command handlers
Remove duplicated handler code by checking the running command name.
Zachary T Welch [Mon, 23 Nov 2009 20:00:31 +0000 (12:00 -0800)]
improve usage and help command output
Rewrite formatting code in C, removing last remenants of TCL help code.
Sinificantly improves the readability by using smarter indent and wrap.
Zachary T Welch [Mon, 23 Nov 2009 20:16:27 +0000 (12:16 -0800)]
allow scripts to update usage information
The add_usage_text command uses the same C handler, which was updated
to support its new polymorphic role. This patch updates the two script
commands that needed this support: 'find' and 'script'.
Zachary T Welch [Tue, 24 Nov 2009 18:58:32 +0000 (10:58 -0800)]
httpd: use register_commands()
Updates httpd_start() to use register_commands() for 'readform' and
'writeform' commands. Adds server/httpd.h to export the new signatures
for this function (and httpd_stop), which allows removing the obsoleted
declarations inside openocd.c.
Zachary T Welch [Mon, 23 Nov 2009 23:03:04 +0000 (15:03 -0800)]
add jim_handler to command_registration
Adding jim_handler field to command_registration allows removing the
register_jim helper. All command registrations now go through the
register_command{,s}() functions.
Zachary T Welch [Mon, 23 Nov 2009 23:01:12 +0000 (15:01 -0800)]
refactor command_new to use command_registration
Save stack space: use a struct. Makes it easier to add new parameters.
Zachary T Welch [Mon, 23 Nov 2009 16:24:02 +0000 (08:24 -0800)]
remove register_commands from etm_capture_driver
Converts callback to an array of command_registration records.
Moves oocd_trace driver definition to end of file to eliminate
useless forward declaration.
Zachary T Welch [Mon, 23 Nov 2009 16:17:01 +0000 (08:17 -0800)]
remove target_type register_command callback
Uses chaining of command_registration structures to eliminate all
target_type register_callback routines. Exports the command_handler
registration arrays for those target types that are used by others.
Zachary T Welch [Mon, 23 Nov 2009 15:43:06 +0000 (07:43 -0800)]
xscale: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:06 +0000 (07:43 -0800)]
trace: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:06 +0000 (07:43 -0800)]
target_request: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:06 +0000 (07:43 -0800)]
target: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:06 +0000 (07:43 -0800)]
oocd_trace: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:06 +0000 (07:43 -0800)]
etm_dummy: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:06 +0000 (07:43 -0800)]
etm: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:06 +0000 (07:43 -0800)]
etb: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:06 +0000 (07:43 -0800)]
cortex_m3: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:06 +0000 (07:43 -0800)]
cortex_a8: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:06 +0000 (07:43 -0800)]
armv7m: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:05 +0000 (07:43 -0800)]
armv7a: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:05 +0000 (07:43 -0800)]
armv4_5: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:05 +0000 (07:43 -0800)]
arm9tdmi: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:05 +0000 (07:43 -0800)]
arm966e: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:05 +0000 (07:43 -0800)]
arm926ejs: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:05 +0000 (07:43 -0800)]
arm920t: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:05 +0000 (07:43 -0800)]
arm7_9_common: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:05 +0000 (07:43 -0800)]
arm720t: use register_commands()
Zachary T Welch [Mon, 23 Nov 2009 15:43:05 +0000 (07:43 -0800)]
arm11: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 14:24:19 +0000 (06:24 -0800)]
remove nand_controller->register_callbacks
Replace flash_driver callback with pointer to command_registration.
Eliminates all related routines and allows drivers to omit commands.
Zachary T Welch [Sun, 22 Nov 2009 14:12:04 +0000 (06:12 -0800)]
remove flash_driver->register_callbacks
Replace flash_driver callback with pointer to command_registration.
Eliminates all related routines and allows drivers to omit commands.
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
tms470: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
str9xpec: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
str9x: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
str7x: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
stm32x: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
stellaris: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
pic32mx: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
nand: use register_commands()
Eliminates 'nand_cmd' global variable.
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
mflash: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
lpc3180_nand_controller: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
lpc2900: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
lpc2000: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
flash: use register_commands()
Eliminates 'flash_cmd' global variable.
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
ecos: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
cfi: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
avrf: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
at91sam7: use register_commands()
Zachary T Welch [Sun, 22 Nov 2009 12:13:56 +0000 (04:13 -0800)]
at91sam3: use register_commands()
Zachary T Welch [Sat, 21 Nov 2009 06:01:59 +0000 (22:01 -0800)]
remove register_callbacks from jtag interface
Changes the jtag_interface->register_callbacks field to a list of
commands to be registered. Changes callback to invocation of
register_commands() with that command registration list. Removes all
JTAG interface driver register_command callback functions, which the
previous commits had converted into identical calls.
Zachary T Welch [Sat, 21 Nov 2009 05:06:28 +0000 (21:06 -0800)]
vsllink: use register_commands()
Use register_commands() with command registration array.
Zachary T Welch [Sat, 21 Nov 2009 05:02:28 +0000 (21:02 -0800)]
jtag: use register_commands()
Use register commands with command registration array.
Zachary T Welch [Sat, 21 Nov 2009 05:00:23 +0000 (21:00 -0800)]
presto: use register_commands()
Use register_commands() with command registration array.
Zachary T Welch [Sat, 21 Nov 2009 04:17:52 +0000 (20:17 -0800)]
parport: use register_commands()
Use register_commands() with a command registration array.
Zachary T Welch [Sat, 21 Nov 2009 04:12:21 +0000 (20:12 -0800)]
jlink: use register_commands()
Use register_commands() with command registration array.
Zachary T Welch [Sat, 21 Nov 2009 04:11:58 +0000 (20:11 -0800)]
gw16012: use register_commands()
Use register_commands() with command registration array.
Zachary T Welch [Sat, 21 Nov 2009 04:06:50 +0000 (20:06 -0800)]
ft2232: use register_commands()
Use register_commands() with a command registration array.
Zachary T Welch [Sat, 21 Nov 2009 03:58:07 +0000 (19:58 -0800)]
at91rm9200: use register_commands()
Use register_commands() with command registration array.
---
This module was broken by previous changes, but no one has complained.
Are there still users for this modules?
Zachary T Welch [Sat, 21 Nov 2009 03:56:02 +0000 (19:56 -0800)]
arm-jtag-ew: use register_commands()
Uses register_commands() with command registration array.
Zachary T Welch [Sat, 21 Nov 2009 03:53:28 +0000 (19:53 -0800)]
amt_jtagaccel: use register_commands()
Use register_commands() with command_registration array.
Zachary T Welch [Mon, 23 Nov 2009 17:30:02 +0000 (09:30 -0800)]
pld: use static registration instead of callback
Remove register_callbacks from pld_device structure, using an array
of command_registration records instead.
Zachary T Welch [Sun, 22 Nov 2009 09:50:22 +0000 (01:50 -0800)]
pld: use register_commands()
Updates core PLD and virtex2 commands to use register_commands().
Zachary T Welch [Sun, 22 Nov 2009 09:11:18 +0000 (01:11 -0800)]
{,x}svf: use register_commands()
Use register_commands() for registering {,x}svf commands.
Zachary T Welch [Sat, 21 Nov 2009 22:42:05 +0000 (14:42 -0800)]
server: use register_commands
Converts server directory to use new command registration paradigm.
Zachary T Welch [Fri, 20 Nov 2009 23:52:18 +0000 (15:52 -0800)]
log: use register_commands()
Use register_commands() for logging callbacks. Improve help and add
proper usage.
Zachary T Welch [Fri, 20 Nov 2009 23:47:08 +0000 (15:47 -0800)]
ioutil: use register_commands()
Use table instead of individual calls. Add proper usage information.
Zachary T Welch [Sat, 21 Nov 2009 00:58:45 +0000 (16:58 -0800)]
openocd: use register_commands()
Use register_commands() for top-level version and init command.
Zachary T Welch [Sat, 21 Nov 2009 23:52:12 +0000 (15:52 -0800)]
demonstrate chaining with foo commands
Use the new command registration chaining capabilities to eliminate
the foo_register_commands helper, folding its remaining command
handler setup into the hello_command_handlers registration array.
Zachary T Welch [Sat, 21 Nov 2009 21:49:00 +0000 (13:49 -0800)]
hello: use register_commands()
Use new register_commands() with command registration table.
Zachary T Welch [Sun, 22 Nov 2009 03:55:50 +0000 (19:55 -0800)]
rewrite 'unknown' command dispatching in C
Rewrite the magical 'unknown' command in C as a Jim handler, allowing
it to dispatch commands to any level in the tree.