From: kruland2607 <kruland2607@180e2498-e6e9-4542-8430-84ac67f01cd8>
Date: Wed, 13 Jun 2012 16:28:03 +0000 (+0000)
Subject: Make some usability improvements to the internal file browser.  Don't cd when changin... 
X-Git-Tag: upstream/12.09^2~185
X-Git-Url: https://git.gag.com/?a=commitdiff_plain;h=7bb2c5fc2148847fa6f9f5e442e97d061edcc4dc;p=debian%2Fopenrocket

Make some usability improvements to the internal file browser.  Don't cd when changing the preferred base directory (touching star).  Don't put star on root & .. directories.

git-svn-id: https://openrocket.svn.sourceforge.net/svnroot/openrocket/trunk@774 180e2498-e6e9-4542-8430-84ac67f01cd8
---

diff --git a/android/src/net/sf/openrocket/android/filebrowser/SimpleFileBrowser.java b/android/src/net/sf/openrocket/android/filebrowser/SimpleFileBrowser.java
index 1ebebfc4..493efbe6 100644
--- a/android/src/net/sf/openrocket/android/filebrowser/SimpleFileBrowser.java
+++ b/android/src/net/sf/openrocket/android/filebrowser/SimpleFileBrowser.java
@@ -161,7 +161,7 @@ public class SimpleFileBrowser extends SherlockListActivity {
 		final File file = path.get(position);
 		if (file.isDirectory()) {
 			if (file.canRead())
-				getDir(path.get(position));
+				getDir(file);
 			else {
 				new AlertDialog.Builder(this).setIcon(R.drawable.or_launcher)
 				.setTitle("[" + file.getName() + "] folder can't be read!")
@@ -244,13 +244,10 @@ public class SimpleFileBrowser extends SherlockListActivity {
 				}
 			}
 
-			// Set the "base directory" thing.
+			// Set the "favorite directory" thing.
 			{
 				ImageView v = (ImageView) (convertView.findViewById(R.id.filebrowser_list_item_homeicon));
-				if ( !file.isDirectory() ) {
-					v.setVisibility(View.INVISIBLE);
-					v.setClickable(false);
-				} else {
+				if ( file.isDirectory() && hasUp && position > 1 ) {
 					v.setVisibility(View.VISIBLE);
 					if ( baseDirName.equals( file.getAbsolutePath() ) )  {
 						v.setSelected(true);
@@ -259,6 +256,9 @@ public class SimpleFileBrowser extends SherlockListActivity {
 						v.setClickable(true);
 						v.setOnClickListener( new ChangeBaseDirectory(file.getAbsolutePath()));
 					}
+				} else {
+					v.setVisibility(View.INVISIBLE);
+					v.setClickable(false);
 				}
 			}
 			return convertView;
@@ -279,7 +279,7 @@ public class SimpleFileBrowser extends SherlockListActivity {
 				SharedPreferences pref = PreferenceManager.getDefaultSharedPreferences(SimpleFileBrowser.this);
 				baseDirName = dirname;
 				pref.edit().putString(baseDirPrefKey, dirname).apply();
-				SimpleFileBrowser.this.getDir(new File(dirname));
+				((BaseAdapter)SimpleFileBrowser.this.getListAdapter()).notifyDataSetChanged();
 			}
 		}