From: David Brownell <dbrownell@users.sourceforge.net>
Date: Fri, 15 Jan 2010 20:53:26 +0000 (-0800)
Subject: ARM DPM: disable some nyet-ready breakpoint code
X-Git-Url: https://git.gag.com/?a=commitdiff_plain;h=6c4a643d632c6cff647c5099bd450d1e417903ea;p=fw%2Fopenocd

ARM DPM: disable some nyet-ready breakpoint code

Until we manage breakpoints at runtime (patches not ready for 0.4)
the only way this code should touch them is to disable them at server
startup (a previous debug session may have left them active).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---

diff --git a/src/target/arm_dpm.c b/src/target/arm_dpm.c
index 0908ca92d..4bd22ffbf 100644
--- a/src/target/arm_dpm.c
+++ b/src/target/arm_dpm.c
@@ -341,13 +341,21 @@ int arm_dpm_write_dirty_registers(struct arm_dpm *dpm, bool bpwp)
 	if (retval != ERROR_OK)
 		goto done;
 
-	/* enable/disable hardware breakpoints */
-	for (unsigned i = 0; i < dpm->nbp; i++) {
-		struct dpm_bp *dbp = dpm->dbp + i;
-		struct breakpoint *bp = dbp->bp;
+	/* If we're managing hardware breakpoints for this core, enable
+	 * or disable them as requested.
+	 *
+	 * REVISIT We don't yet manage them for ANY cores.  Eventually
+	 * we should be able to assume we handle them; but until then,
+	 * cope with the hand-crafted breakpoint code.
+	 */
+	if (0) {
+		for (unsigned i = 0; i < dpm->nbp; i++) {
+			struct dpm_bp *dbp = dpm->dbp + i;
+			struct breakpoint *bp = dbp->bp;
 
-		retval = dpm_maybe_update_bpwp(dpm, bpwp, &dbp->bpwp,
-				bp ? &bp->set : NULL);
+			retval = dpm_maybe_update_bpwp(dpm, bpwp, &dbp->bpwp,
+					bp ? &bp->set : NULL);
+		}
 	}
 
 	/* enable/disable watchpoints */