From: Tomas Vanek Date: Thu, 29 Oct 2020 18:57:20 +0000 (+0100) Subject: gdb_server: fix clang static analyzer warning X-Git-Url: https://git.gag.com/?a=commitdiff_plain;h=49b7099def030accbceb9a92782fb389d04e8e09;p=fw%2Fopenocd gdb_server: fix clang static analyzer warning Warning: line 373, column 15 Assigned value is garbage or undefined Most probably a false warning, building the hex string byte per byte seems too complicated for static analyze. Change malloc to calloc to silence the warning. Change-Id: I746d43fa51abf05582ccf2680ed72dc557798a7a Signed-off-by: Tomas Vanek Reviewed-on: http://openocd.zylin.com/5905 Reviewed-by: Antonio Borneo Tested-by: jenkins Reviewed-by: Jonathan McDowell --- diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c index c36966554..1a209a769 100644 --- a/src/server/gdb_server.c +++ b/src/server/gdb_server.c @@ -1332,7 +1332,7 @@ static int gdb_get_register_packet(struct connection *connection, } } - reg_packet = malloc(DIV_ROUND_UP(reg_list[reg_num]->size, 8) * 2 + 1); /* plus one for string termination null */ + reg_packet = calloc(DIV_ROUND_UP(reg_list[reg_num]->size, 8) * 2 + 1, 1); /* plus one for string termination null */ gdb_str_to_target(target, reg_packet, reg_list[reg_num]);