From: Tomas Vanek <vanekt@fbl.cz>
Date: Wed, 10 Nov 2021 11:46:42 +0000 (+0100)
Subject: target/arm_dap: fix memory leak in error path of dap_create()
X-Git-Url: https://git.gag.com/?a=commitdiff_plain;h=3eef83e4bd2b112b98d73f8b0947af93c193e0ef;p=fw%2Fopenocd

target/arm_dap: fix memory leak in error path of dap_create()

Change-Id: I91fa5910670161b62a76fc834b6394c5a6c05395
Suggested-by: Antonio Borneo <borneo.antonio@gmail.com>
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: https://review.openocd.org/c/openocd/+/6685
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
---

diff --git a/src/target/arm_dap.c b/src/target/arm_dap.c
index 94edfc09d..18e77b50f 100644
--- a/src/target/arm_dap.c
+++ b/src/target/arm_dap.c
@@ -267,8 +267,11 @@ static int dap_create(struct jim_getopt_info *goi)
 		dap_commands[0].chain = NULL;
 
 	e = register_commands_with_data(cmd_ctx, NULL, dap_commands, dap);
-	if (e != ERROR_OK)
+	if (e != ERROR_OK) {
+		free(dap->name);
+		free(dap);
 		return JIM_ERR;
+	}
 
 	list_add_tail(&dap->lh, &all_dap);