From: Tomas Vanek <vanekt@fbl.cz>
Date: Thu, 29 Oct 2020 19:41:54 +0000 (+0100)
Subject: jtag/tcl: fix memory leak in error return
X-Git-Url: https://git.gag.com/?a=commitdiff_plain;h=3099d52d78ce3703cefa0a066a879fb95fd047d3;p=fw%2Fopenocd

jtag/tcl: fix memory leak in error return

Clang static analyzer reported:
Warning:	line 196, column 3
Potential leak of memory pointed to by 'fields'

Free allocated memory pointed by 'fields' and fields[i].in_value

Change-Id: I0b3935d9a235544afc03e39a4648319047e65815
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/5906
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Tested-by: jenkins
Reviewed-by: Jonathan McDowell <noodles-openocd@earth.li>
---

diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c
index 153a98e1b..2fa162e56 100644
--- a/src/jtag/tcl.c
+++ b/src/jtag/tcl.c
@@ -194,6 +194,11 @@ static int Jim_Command_drscan(Jim_Interp *interp, int argc, Jim_Obj *const *args
 	retval = jtag_execute_queue();
 	if (retval != ERROR_OK) {
 		Jim_SetResultString(interp, "drscan: jtag execute failed", -1);
+
+		for (i = 0; i < field_count; i++)
+			free(fields[i].in_value);
+		free(fields);
+
 		return JIM_ERR;
 	}