From: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Date: Sat, 28 Sep 2013 14:07:14 +0000 (+0200)
Subject: jtag/tcl: Fix double free in jtag newtap argument parsing
X-Git-Url: https://git.gag.com/?a=commitdiff_plain;h=2a0ed1ee7f2d0402cbadd93c8d3019bdb5f9370e;p=fw%2Fopenocd

jtag/tcl: Fix double free in jtag newtap argument parsing

Found when grepping for void* casts. I'm pretty sure there are about
*picking a number out of the blue* 0.31 bugs per pointer cast in OpenOCD.

Verified by valgrind, i.e.:
valgrind openocd -f interface/jtagkey.cfg -c "jtag newtap dummy cpu -irlen foo"

Change-Id: Idc12e8f18036cc908fdb572828fa46563be14242
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1665
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
---

diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c
index d0020cd37..227222ef4 100644
--- a/src/jtag/tcl.c
+++ b/src/jtag/tcl.c
@@ -467,7 +467,6 @@ static int jim_newtap_ir_param(Jim_Nvp *n, Jim_GetOptInfo *goi,
 	if (e != JIM_OK) {
 		Jim_SetResultFormatted(goi->interp,
 			"option: %s bad parameter", n->name);
-		free((void *)pTap->dotted_name);
 		return e;
 	}
 	switch (n->value) {