aarch64: reduce debug output to improve legibility

Suppress some very verbose LOG_DEBUG's that are not really useful
any more.

Change-Id: I67f10ba9510a9e34a027f378f4b62b8901ddc8a4
Signed-off-by: Matthias Welwarsky <matthias.welwarsky@sysgo.com>
Reviewed-on: http://openocd.zylin.com/3984
Tested-by: jenkins
Reviewed-by: Paul Fertser <fercerpav@gmail.com>

diff --git a/src/target/aarch64.c b/src/target/aarch64.c
index 7bd3d3c80dad40bde1ebb119cdad296a601004a1..d3ed57c5d8a38015cc3792517bc09821ee5ab8e3 100644 (file)
--- a/src/target/aarch64.c
+++ b/src/target/aarch64.c
@@ -1333,9 +1333,6 @@ static int aarch64_write_apb_ap_memory(struct target *target,
        uint32_t dscr;
        uint8_t *tmp_buff = NULL;
 
-       LOG_DEBUG("Writing APB-AP memory address 0x%" PRIx64 " size %"  PRIu32 " count %"  PRIu32,
-                         address, size, count);
-
        if (target->state != TARGET_HALTED) {
                LOG_WARNING("target not halted");
                return ERROR_TARGET_NOT_HALTED;
@@ -1484,9 +1481,6 @@ static int aarch64_read_apb_ap_memory(struct target *target,
        uint8_t *u8buf_ptr;
        uint32_t value;
 
-       LOG_DEBUG("Reading APB-AP memory address 0x%" TARGET_PRIxADDR " size %" PRIu32 " count %"  PRIu32,
-                         address, size, count);
-
        if (target->state != TARGET_HALTED) {
                LOG_WARNING("target not halted");
                return ERROR_TARGET_NOT_HALTED;
@@ -1634,8 +1628,6 @@ static int aarch64_read_phys_memory(struct target *target,
        uint32_t count, uint8_t *buffer)
 {
        int retval = ERROR_COMMAND_SYNTAX_ERROR;
-       LOG_DEBUG("Reading memory at real address 0x%" TARGET_PRIxADDR "; size %" PRId32 "; count %" PRId32,
-               address, size, count);
 
        if (count && buffer) {
                /* read memory through APB-AP */
@@ -1653,10 +1645,6 @@ static int aarch64_read_memory(struct target *target, target_addr_t address,
        int mmu_enabled = 0;
        int retval;
 
-       /* aarch64 handles unaligned memory access */
-       LOG_DEBUG("Reading memory at address 0x%" TARGET_PRIxADDR "; size %" PRId32 "; count %" PRId32, address,
-               size, count);
-
        /* determine if MMU was enabled on target stop */
        retval = aarch64_mmu(target, &mmu_enabled);
        if (retval != ERROR_OK)
@@ -1680,9 +1668,6 @@ static int aarch64_write_phys_memory(struct target *target,
 {
        int retval = ERROR_COMMAND_SYNTAX_ERROR;
 
-       LOG_DEBUG("Writing memory to real address 0x%" TARGET_PRIxADDR "; size %" PRId32 "; count %" PRId32, address,
-               size, count);
-
        if (count && buffer) {
                /* write memory through APB-AP */
                retval = aarch64_mmu_modify(target, 0);
@@ -1700,10 +1685,6 @@ static int aarch64_write_memory(struct target *target, target_addr_t address,
        int mmu_enabled = 0;
        int retval;
 
-       /* aarch64 handles unaligned memory access */
-       LOG_DEBUG("Writing memory at address 0x%" TARGET_PRIxADDR "; size %" PRId32
-                 "; count %" PRId32, address, size, count);
-
        /* determine if MMU was enabled on target stop */
        retval = aarch64_mmu(target, &mmu_enabled);
        if (retval != ERROR_OK)

diff --git a/src/target/armv8.c b/src/target/armv8.c
index 94a0e8e8d439e7986fa6ca3394dc092fd5e981b3..7ae8cc9ebeeb3e849ceed6bb928f3c302f03e262 100644 (file)
--- a/src/target/armv8.c
+++ b/src/target/armv8.c
@@ -1086,9 +1086,6 @@ static int armv8_get_core_reg32(struct reg *reg)
        struct reg *reg64;
        int retval;
 
-       LOG_DEBUG("reg.name:%s number:%i arm.num:%i value:0x%08" PRIx64,
-                       reg->name, reg->number, armv8_reg->num, buf_get_u64(reg->value, 0, 32));
-
        /* get the corresponding Aarch64 register */
        reg64 = cache->reg_list + armv8_reg->num;
        if (reg64->valid) {

diff --git a/src/target/armv8_dpm.c b/src/target/armv8_dpm.c
index acfd1bcdf8d510b8d73f9d3a3ff1284de80925e6..56e2eb8fef5e7f0ec995bee57338dc9750fd8032 100644 (file)
--- a/src/target/armv8_dpm.c
+++ b/src/target/armv8_dpm.c
@@ -71,7 +71,6 @@ enum arm_state armv8_dpm_get_core_state(struct arm_dpm *dpm)
 
 static int dpmv8_write_dcc(struct armv8_common *armv8, uint32_t data)
 {
-       LOG_DEBUG("write DCC 0x%08" PRIx32, data);
        return mem_ap_write_u32(armv8->debug_ap,
                                armv8->debug_base + CPUV8_DBG_DTRRX, data);
 }
@@ -79,7 +78,6 @@ static int dpmv8_write_dcc(struct armv8_common *armv8, uint32_t data)
 static int dpmv8_write_dcc_64(struct armv8_common *armv8, uint64_t data)
 {
        int ret;
-       LOG_DEBUG("write DCC 0x%016" PRIx64, data);
        ret = mem_ap_write_u32(armv8->debug_ap,
                               armv8->debug_base + CPUV8_DBG_DTRRX, data);
        if (ret == ERROR_OK)
@@ -116,7 +114,6 @@ static int dpmv8_read_dcc(struct armv8_common *armv8, uint32_t *data,
                                            data);
        if (retval != ERROR_OK)
                return retval;
-       LOG_DEBUG("read DCC 0x%08" PRIx32, *data);
 
        if (dscr_p)
                *dscr_p = dscr;
@@ -161,7 +158,6 @@ static int dpmv8_read_dcc_64(struct armv8_common *armv8, uint64_t *data,
                return retval;
 
        *data = *(uint32_t *)data | (uint64_t)higher << 32;
-       LOG_DEBUG("read DCC 0x%16.16" PRIx64, *data);
 
        if (dscr_p)
                *dscr_p = dscr;
@@ -220,8 +216,6 @@ static int dpmv8_exec_opcode(struct arm_dpm *dpm,
        uint32_t dscr = dpm->dscr;
        int retval;
 
-       LOG_DEBUG("exec opcode 0x%08" PRIx32, opcode);
-
        if (p_dscr)
                dscr = *p_dscr;