target/hla_target: fix clang static analyzer warning

Added an error msg in case of no memory

Change-Id: I7a7d266ca4aa1e4a0ff02a2d1cc672a3cd2746c3
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/4882
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

diff --git a/src/target/hla_target.c b/src/target/hla_target.c
index 4bf7bdc4de3496749de3ec04ec02297249028edf..4f97eb95c58deffbd7ac41c45058e92a070a9cf1 100644 (file)
--- a/src/target/hla_target.c
+++ b/src/target/hla_target.c
@@ -366,12 +366,14 @@ static int adapter_target_create(struct target *target,
 {
        LOG_DEBUG("%s", __func__);
        struct adiv5_private_config *pc = target->private_config;
-       struct cortex_m_common *cortex_m = calloc(1, sizeof(struct cortex_m_common));
-       if (!cortex_m)
-               return ERROR_COMMAND_SYNTAX_ERROR;
-
        if (pc != NULL && pc->ap_num > 0) {
                LOG_ERROR("hla_target: invalid parameter -ap-num (> 0)");
+               return ERROR_COMMAND_SYNTAX_ERROR;
+       }
+
+       struct cortex_m_common *cortex_m = calloc(1, sizeof(struct cortex_m_common));
+       if (cortex_m == NULL) {
+               LOG_ERROR("No memory creating target");
                return ERROR_FAIL;
        }