arm_semihosting: fix two dead assignments

Clang scan-build complains for two dead assignments:
	Value stored to 'r' is never read

Use the variable in the following line, instead of re-computing
the pointer.

Change-Id: I5d4069872be9da85fb28bbe0a82020b90f1efe46
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/6589
Tested-by: jenkins

diff --git a/src/target/arm_semihosting.c b/src/target/arm_semihosting.c
index 1e5b5e25206f9ce75fad57bafd8cbfdc8c436f51..792474acf0de7eb66a5b3cadce4f20ddaf45f2bf 100644 (file)
--- a/src/target/arm_semihosting.c
+++ b/src/target/arm_semihosting.c
@@ -315,7 +315,7 @@ int arm_semihosting(struct target *target, int *retval)
                                return 0;
                } else if (arm->core_state == ARM_STATE_ARM) {
                        r = arm->pc;
-                       pc = buf_get_u32(arm->pc->value, 0, 32);
+                       pc = buf_get_u32(r->value, 0, 32);
 
                        /* A32 instruction => check for HLT 0xF000 (0xE10F0070) */
                        uint32_t insn = 0;
@@ -330,7 +330,7 @@ int arm_semihosting(struct target *target, int *retval)
                                return 0;
                } else if (arm->core_state == ARM_STATE_THUMB) {
                        r = arm->pc;
-                       pc = buf_get_u32(arm->pc->value, 0, 32);
+                       pc = buf_get_u32(r->value, 0, 32);
 
                        /* T32 instruction => check for HLT 0x3C (0xBABC) */
                        uint16_t insn = 0;