]> git.gag.com Git - fw/openocd/commitdiff
target/aarch64: fix minor stepping issue with gdb
authorTarek BOCHKATI <tarek.bouchkati@gmail.com>
Mon, 9 Dec 2019 11:35:01 +0000 (12:35 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Thu, 12 Mar 2020 09:45:36 +0000 (09:45 +0000)
when using step command from gdb the step happens without any issue,
but aarch64_step call explicitly aarch64_poll which consumes the
status change to HALTED, so it does not inform gdb that the step has
finished.

by removing this call, all is back to normal and openocd could inform gdb
that the step has finished.

Change-Id: I9366aecd20f7d52259b050b8653189b67d9299d0
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-on: http://openocd.zylin.com/5354
Tested-by: jenkins
Reviewed-by: Muhammad Omair Javaid <omair.javaid@linaro.org>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
src/target/aarch64.c

index 7acb4726abbe7486f256b89e9efd7c9faf9bb9b2..4d3d9819e856b6ed498c80c942f33f7617186048 100644 (file)
@@ -1176,7 +1176,7 @@ static int aarch64_step(struct target *target, int current, target_addr_t addres
        if (saved_retval != ERROR_OK)
                return saved_retval;
 
-       return aarch64_poll(target);
+       return ERROR_OK;
 }
 
 static int aarch64_restore_context(struct target *target, bool bpwp)