Use parse_uint in handle_reg_command to ensure reg number parses properly.
authorzwelch <zwelch@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Sat, 13 Jun 2009 00:32:54 +0000 (00:32 +0000)
committerzwelch <zwelch@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Sat, 13 Jun 2009 00:32:54 +0000 (00:32 +0000)
git-svn-id: svn://svn.berlios.de/openocd/trunk@2226 b42882b7-edfa-0310-969c-e2dbd0fdcd60

src/target/target.c

index b8ee7ab937d93c5747346310795517dce5aa10f5..13c0842ff9ce791a08c2b5b3c01f1889564118b0 100644 (file)
@@ -1704,16 +1704,19 @@ static int handle_reg_command(struct command_context_s *cmd_ctx, char *cmd, char
        /* access a single register by its ordinal number */
        if ((args[0][0] >= '0') && (args[0][0] <= '9'))
        {
-               int num = strtoul(args[0], NULL, 0);
-               reg_cache_t *cache = target->reg_cache;
+               unsigned num;
+               int retval = parse_uint(args[0], &num);
+               if (ERROR_OK != retval)
+                       return ERROR_COMMAND_SYNTAX_ERROR;
 
+               reg_cache_t *cache = target->reg_cache;
                count = 0;
                while(cache)
                {
                        int i;
                        for (i = 0; i < cache->num_regs; i++)
                        {
-                               if (count++ == num)
+                               if (count++ == (int)num)
                                {
                                        reg = &cache->reg_list[i];
                                        break;