]> git.gag.com Git - fw/openocd/commitdiff
target/lakemont: fix dead assignment
authorAntonio Borneo <borneo.antonio@gmail.com>
Wed, 22 Sep 2021 17:14:29 +0000 (19:14 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Mon, 25 Oct 2021 16:10:04 +0000 (16:10 +0000)
Clang scan-build complains for a dead assignment:
Value stored to 'tapstatus' is never read

Remove the assignment and add a comment to point for a potential
removal of the line.

Change-Id: Iad2fdc7e6faf650e24cc086ee74c745acb0d1c73
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/6591
Tested-by: jenkins
src/target/lakemont.c

index 576956e31319c141754500bc9b985a78a3625b4b..e46ee5cf83f09d29cd9170835e6c4212d2b336d2 100644 (file)
@@ -1070,7 +1070,8 @@ int lakemont_step(struct target *t, int current,
        LOG_DEBUG("EFLAGS [TF] [RF] bits set=0x%08" PRIx32 ", PMCR=0x%08" PRIx32 ", EIP=0x%08" PRIx32,
                        eflags, pmcr, eip);
 
-       tapstatus = get_tapstatus(t);
+       /* Returned value unused. Can this line be removed? */
+       get_tapstatus(t);
 
        t->debug_reason = DBG_REASON_SINGLESTEP;
        t->state = TARGET_DEBUG_RUNNING;