Makefile: drop warning suppression on win build

Commit dcdf71c21b99 ("- fix signed/unsigned build errors under
win32. Thanks Zach Welch <zw@superlucidity.net>") in 2009 prevents
gcc warnings on sign/unsigned comparisons while building for Win
on folders 'helper' and 'server'.
In 2011, commit b69119668ed8 ("RTOS Thread awareness support wip")
uses the same method on the new folder 'rtos'.

In mean time, all the incorrect sign/unsigned comparisons has been
fixed and no warning is present with the default -Wextra flag that
implies -Wsign-compare.
The comment:
	# FD_* macros are sloppy with their signs on MinGW32 platform
seems linked to some old implementation of MinGW32 include file
that doesn't apply on current versions.

Remove the obsolete hacks to suppress the warnings.

Change-Id: I76dba9e54a647d3b9fbf1b7e9ae1844e3d7adc9a
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/6254
Tested-by: jenkins
Reviewed-by: Xiaofan Chen <xiaofanc@gmail.com>

diff --git a/src/helper/Makefile.am b/src/helper/Makefile.am
index 0d886843ce7f69779711d86372e71195864a6013..c1aeebf0000d3cde92eb4079fd35b24d36af51ed 100644 (file)
--- a/src/helper/Makefile.am
+++ b/src/helper/Makefile.am
@@ -30,12 +30,6 @@ noinst_LTLIBRARIES += %D%/libhelper.la
        %D%/jep106.inc \
        %D%/jim-nvp.h
 
-%C%_libhelper_la_CFLAGS = $(AM_CFLAGS)
-if IS_MINGW
-# FD_* macros are sloppy with their signs on MinGW32 platform
-%C%_libhelper_la_CFLAGS += -Wno-sign-compare
-endif
-
 STARTUP_TCL_SRCS += %D%/startup.tcl
 EXTRA_DIST += \
        %D%/bin2char.sh \

diff --git a/src/rtos/Makefile.am b/src/rtos/Makefile.am
index 49cb830e5aedbe09fa58a2f48c4f369b7106dec7..f09ac21a2efed2c40247bcb2d594bc6676dee6fe 100644 (file)
--- a/src/rtos/Makefile.am
+++ b/src/rtos/Makefile.am
@@ -31,10 +31,3 @@ noinst_LTLIBRARIES += %D%/librtos.la
        %D%/rtos_riot_stackings.h \
        %D%/rtos_ucos_iii_stackings.h \
        %D%/nuttx_header.h
-
-%C%_librtos_la_CFLAGS = $(AM_CFLAGS)
-
-if IS_MINGW
-# FD_* macros are sloppy with their signs on MinGW32 platform
-%C%_librtos_la_CFLAGS += -Wno-sign-compare
-endif

diff --git a/src/server/Makefile.am b/src/server/Makefile.am
index 5f7469a8495db91f793037aa88f2e3046ea5fd7d..fb5248bfdecedca5bc717fa9f46f97c3b4292ebb 100644 (file)
--- a/src/server/Makefile.am
+++ b/src/server/Makefile.am
@@ -14,10 +14,4 @@ noinst_LTLIBRARIES += %D%/libserver.la
        %D%/ipdbg.c \
        %D%/ipdbg.h
 
-%C%_libserver_la_CFLAGS = $(AM_CFLAGS)
-if IS_MINGW
-# FD_* macros are sloppy with their signs on MinGW32 platform
-%C%_libserver_la_CFLAGS += -Wno-sign-compare
-endif
-
 STARTUP_TCL_SRCS += %D%/startup.tcl