In particular -f and -s options may contains paths that can easily
exceed the (old) 128 bytes buffer.
Change-Id: Ifc198536549f50663e8e588519bb9ef75dcd172c
Signed-off-by: Cristian Maglie <c.maglie@bug.st>
Reviewed-on: http://openocd.zylin.com/2241
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
int parse_cmdline_args(struct command_context *cmd_ctx, int argc, char *argv[])
{
int c;
int parse_cmdline_args(struct command_context *cmd_ctx, int argc, char *argv[])
{
int c;
- char command_buffer[128];
while (1) {
/* getopt_long stores the option index here. */
while (1) {
/* getopt_long stores the option index here. */
break;
case 'f': /* --file | -f */
{
break;
case 'f': /* --file | -f */
{
- snprintf(command_buffer, 128, "script {%s}", optarg);
- add_config_command(command_buffer);
+ char *command = alloc_printf("script {%s}", optarg);
+ add_config_command(command);
+ free(command);
break;
}
case 's': /* --search | -s */
add_script_search_dir(optarg);
break;
case 'd': /* --debug | -d */
break;
}
case 's': /* --search | -s */
add_script_search_dir(optarg);
break;
case 'd': /* --debug | -d */
- if (optarg)
- snprintf(command_buffer, 128, "debug_level %s", optarg);
- else
- snprintf(command_buffer, 128, "debug_level 3");
- command_run_line(cmd_ctx, command_buffer);
+ {
+ char *command = alloc_printf("debug_level %s", optarg ? optarg : "3");
+ command_run_line(cmd_ctx, command);
+ free(command);
case 'l': /* --log_output | -l */
if (optarg) {
case 'l': /* --log_output | -l */
if (optarg) {
- snprintf(command_buffer, 128, "log_output %s", optarg);
- command_run_line(cmd_ctx, command_buffer);
+ char *command = alloc_printf("log_output %s", optarg);
+ command_run_line(cmd_ctx, command);
+ free(command);
}
break;
case 'c': /* --command | -c */
}
break;
case 'c': /* --command | -c */