hla: API: specify that read_reg/write_reg use regsel as parameter
authorAntonio Borneo <borneo.antonio@gmail.com>
Sun, 25 Oct 2020 13:59:13 +0000 (14:59 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sun, 15 Nov 2020 21:07:14 +0000 (21:07 +0000)
commitbe631eed16bd9ef2b735fd64650ca7283d2ca361
treef6edffb6d89314527cdb1d3e6ec11735d641b650
parent62394a6b1c25ac92630a4828ec1b5d70acfe6e0f
hla: API: specify that read_reg/write_reg use regsel as parameter

The API of hla have been defined from ST-Link basic operations.
By chance, all the current implementation of hla (st-link, ti-icdi
and nulink) share the same way to handle the parameter 'num' of
the API read_reg() and write_reg(), that is simply using it to
initialize the field REGSEL (bits [6:0]) of armv7m Debug Core
Register Selector Register (DCRSR).

Add a comment in the API definition to highlight this, in case it
get used by a further hla implementation, then rename as 'regsel'
the 'num' parameter.

Change-Id: I4b6a2c7d78b4fc4de2b9b2bdba065414b15c6ba3
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5882
Reviewed-by: Edward Fewell <edwardfewell@hotmail.com>
Tested-by: jenkins
Reviewed-by: Zale Yu
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
src/jtag/drivers/nulink_usb.c
src/jtag/drivers/stlink_usb.c
src/jtag/drivers/ti_icdi_usb.c
src/jtag/hla/hla_layout.h