flash/nor/cfi: fix uninitialized write-mem pointer
authorMischa Studer <mischa.studer@csa.ch>
Wed, 24 Feb 2021 12:24:51 +0000 (13:24 +0100)
committerTomas Vanek <vanekt@fbl.cz>
Wed, 24 Mar 2021 17:14:22 +0000 (17:14 +0000)
commitb5889776339eb1a3106cc4639b43d9c58b573ec6
treeb5c1f95296c22d0d8b1c2baa350fc163724ed798
parent6448f70e0940d051eb4847231480e4805e99966a
flash/nor/cfi: fix uninitialized write-mem pointer

In flash/nor/cfi.c:835 struct cfi_info is allocated by malloc(). As
write-mem was uninitialized the pointer pointed to an out of range
address, which led to a segmentation fault and crashed openocd.
This happened during flash-command of an external flash-bank, using
cfi.
Use calloc() instead.
While on it check for NULL return and remove unnecessary initialzation.

Change-Id: I0e2ffb90559afe7f090837023428dcc06b2e29f6
Signed-off-by: Mischa Studer <mischa.studer@csa.ch>
Reviewed-on: http://openocd.zylin.com/6070
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
src/flash/nor/cfi.c