]> git.gag.com Git - fw/openocd/commit
target: fix crash with jimtcl 0.78
authorAntonio Borneo <borneo.antonio@gmail.com>
Fri, 14 Feb 2020 13:35:51 +0000 (14:35 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Thu, 12 Mar 2020 10:03:57 +0000 (10:03 +0000)
commit939febeccafc885d3869ce94c688aaf724f2eccd
tree21f134ab6659cfb8d1b709311911f56a9e56efd5
parent44967a9e07ff01a01a96757f302c053553cff35e
target: fix crash with jimtcl 0.78

The jimtcl commit 41c5ff1809f5 ("jim.c: Fix Object leak in zlib
support") https://repo.or.cz/jimtcl.git/commit/41c5ff1809f5
makes Jim_SetResultFormatted() freeing the parameters that have
zero refcount.

OpenOCD commit 559d08c19ed8 ("jim tests: use installed") adds the
only code instance in OpenOCD that first passes a zero refcount
object to Jim_SetResultFormatted() and then frees it.
By switching jimtcl version to 0.78 or newer this causes a crash
of OpenOCD.
To trigger the crash in a telnet session, check that the current
target is running and type:
[target current] arp_waitstate halted 1

Remove the call to Jim_FreeNewObj() after the call to
Jim_SetResultFormatted().

Change-Id: I5f5a8bca96a0e8466ff7b789fe578ea9785fa550
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5453
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
src/target/target.c