]> git.gag.com Git - fw/openocd/commit
keep-alive: drop link with log framework
authorAntonio Borneo <borneo.antonio@gmail.com>
Mon, 31 Jan 2022 09:51:49 +0000 (10:51 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 19 Mar 2022 09:10:39 +0000 (09:10 +0000)
commit4e5dbecd9b1ac780181e04f8b51a4cd133c4cdbe
treec968d4deab52cb34a034ec87881d50d94eacb6c1
parent5c26fd7ab8916d25cb876487d39ec45e3c936d55
keep-alive: drop link with log framework

OpenOCD implements the GDB keep-alive by sending empty strings as
output for GDB client. This has been implemented as part of the
log framework, creating an odd dependency.

Move the keep-alive notifications out of log framework.
For the moment, keep keep_alive() inside log.c, but it should be
moved in server.c

This should also fix an old issue with KDE Konsole when tab alert
for activity is enabled. The empty strings is sent to all the
connections, including telnet, and causes the tab running OpenOCD
telnet to continuously show activity even when no new text is
printed. Anyway, I cannot replicate this issue anymore.

Change-Id: Iebb00b00fb74b3c9665d9e1ddd3c055275bfbd43
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/6840
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
src/helper/log.c
src/server/gdb_server.c
src/server/server.c
src/server/server.h