]> git.gag.com Git - fw/openocd/commit
drivers/jlink: fix calculate_swo_prescaler formula
authorAdrian Negreanu <adrian.negreanu@nxp.com>
Mon, 7 Sep 2020 19:36:10 +0000 (22:36 +0300)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sun, 27 Sep 2020 16:40:12 +0000 (17:40 +0100)
commit051e80812b1b3bb4deabef272c12bb95f10748da
tree59d3261f22b6998a5be30cd10d9a41202e2c3c0d
parent35e580373a77438f2832974b1f0dc36863dc3f03
drivers/jlink: fix calculate_swo_prescaler formula

a) TPIU_ACPR is defined as:
SWO_baudrate = TRACECLKIN/(TPIU_ACPR +1)

b) TPIU_ACPR is set by armv7m_trace_tpiu_config()
target_write_u32(target, TPIU_ACPR, Prescaler-1), so
TPIU_ACPR = Prescaler-1

Replacing TPIU_ACPR in a), we get:
SWO_baudrate = TRACECLKIN/Prescaler, so

c) Prescaler = TRACECLKIN/SWO_baudrate

The Prescaler calculated by calculate_swo_prescaler() is greater by 1:
Prescaler = TRACECLKIN/SWO_baudrate + 1

The second problem is that even in situations when
an exact baudrate match is possible,
the resulting TRACECLKIN/Prescaler already has a 3% deviation.

For example, TRACECLKIN=88000000, SWO_baudrate=500000,
calculate_swo_prescaler will return Prescaler=171.
The correct value should be Prescaler=176 (TPIU_ACPR=175).

Might be related to https://sourceforge.net/p/openocd/tickets/263/

Change-Id: Ib4d6df6e34685a9be4c2995cb500b2411c76e39b
Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>
Reviewed-on: http://openocd.zylin.com/5807
Tested-by: jenkins
Reviewed-by: Marc Schink <dev@zapb.de>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
src/jtag/drivers/jlink.c