X-Git-Url: https://git.gag.com/?a=blobdiff_plain;f=src%2FSDCCval.c;h=6a0095016df7888cb417d2f73b62ae103b09f24d;hb=830f8429290c5ab30fe839957c7f62af51f482c9;hp=3b711c542394f3e45221643addc746e70f04d0d7;hpb=eadbf2f4a849754ca3715733827b1e9c6e5ae8a1;p=fw%2Fsdcc diff --git a/src/SDCCval.c b/src/SDCCval.c index 3b711c54..6a009501 100644 --- a/src/SDCCval.c +++ b/src/SDCCval.c @@ -27,6 +27,7 @@ #include #include #include +#include #include "newalloc.h" int cNestLevel; @@ -56,7 +57,8 @@ newiList (int type, void *ilist) nilist = Safe_alloc (sizeof (initList)); nilist->type = type; - nilist->lineno = yylineno; + nilist->lineno = mylineno; + nilist->filename = currFname; switch (type) { @@ -102,37 +104,37 @@ convertIListToConstList(initList *src, literalList **lList) { initList *iLoop; literalList *head, *last, *newL; - + head = last = NULL; - + if (!src || src->type != INIT_DEEP) { - return FALSE; + return FALSE; } - + iLoop = src->init.deep; - + while (iLoop) { if (iLoop->type != INIT_NODE) { return FALSE; } - - if (!IS_AST_LIT_VALUE(decorateType(resolveSymbols(iLoop->init.node)))) + + if (!IS_AST_LIT_VALUE(decorateType(resolveSymbols(iLoop->init.node), RESULT_TYPE_NONE))) { return FALSE; } iLoop = iLoop->next; } - + // We've now established that the initializer list contains only literal values. - + iLoop = src->init.deep; while (iLoop) { double val = AST_LIT_VALUE(iLoop->init.node); - + if (last && last->literalValue == val) { last->count++; @@ -143,7 +145,7 @@ convertIListToConstList(initList *src, literalList **lList) newL->literalValue = val; newL->count = 1; newL->next = NULL; - + if (last) { last->next = newL; @@ -156,12 +158,12 @@ convertIListToConstList(initList *src, literalList **lList) } iLoop = iLoop->next; } - - if (!head) + + if (!head) { return FALSE; } - + *lList = head; return TRUE; } @@ -170,17 +172,17 @@ literalList * copyLiteralList(literalList *src) { literalList *head, *prev, *newL; - + head = prev = NULL; - + while (src) { newL = Safe_alloc(sizeof(literalList)); - + newL->literalValue = src->literalValue; newL->count = src->count; newL->next = NULL; - + if (prev) { prev->next = newL; @@ -192,7 +194,7 @@ copyLiteralList(literalList *src) prev = newL; src = src->next; } - + return head; } @@ -228,7 +230,7 @@ copyIlist (initList * src) /*------------------------------------------------------------------*/ /* list2int - converts the first element of the list to value */ /*------------------------------------------------------------------*/ -double +double list2int (initList * val) { initList *i = val; @@ -268,19 +270,28 @@ list2expr (initList * ilist) /*------------------------------------------------------------------*/ /* resolveIvalSym - resolve symbols in initial values */ /*------------------------------------------------------------------*/ -void -resolveIvalSym (initList * ilist) +void +resolveIvalSym (initList * ilist, sym_link * type) { + RESULT_TYPE resultType; + if (!ilist) return; if (ilist->type == INIT_NODE) - ilist->init.node = decorateType (resolveSymbols (ilist->init.node)); + { + if (IS_PTR (type)) + resultType = RESULT_TYPE_INT; + else + resultType = getResultTypeFromType (getSpec (type)); + ilist->init.node = decorateType (resolveSymbols (ilist->init.node), + resultType); + } if (ilist->type == INIT_DEEP) - resolveIvalSym (ilist->init.deep); + resolveIvalSym (ilist->init.deep, type); - resolveIvalSym (ilist->next); + resolveIvalSym (ilist->next, type); } /*-----------------------------------------------------------------*/ @@ -304,22 +315,26 @@ symbolVal (symbol * sym) } if (*sym->rname) - sprintf (val->name, "%s", sym->rname); + { + SNPRINTF (val->name, sizeof(val->name), "%s", sym->rname); + } else - sprintf (val->name, "_%s", sym->name); - + { + SNPRINTF (val->name, sizeof(val->name), "_%s", sym->name); + } return val; } +#if defined(REDUCE_LITERALS) /*--------------------------------------------------------------------*/ /* cheapestVal - convert a val to the cheapest as possible value */ /*--------------------------------------------------------------------*/ -value *cheapestVal (value *val) { - long sval=0; - unsigned long uval=0; +static value *cheapestVal (value *val) { + TYPE_DWORD sval=0; + TYPE_UDWORD uval=0; - if (IS_FLOAT(val->type) || IS_CHAR(val->type)) + if (IS_FLOAT(val->type) || IS_FIXED(val->type) || IS_CHAR(val->type)) return val; if (SPEC_LONG(val->type)) { @@ -339,35 +354,73 @@ value *cheapestVal (value *val) { if (SPEC_USIGN(val->type)) { if (uval<=0xffff) { SPEC_LONG(val->type)=0; - SPEC_CVAL(val->type).v_uint = uval; - } - if (uval<=0xff) { - SPEC_NOUN(val->type)=V_CHAR; + SPEC_CVAL(val->type).v_uint = (TYPE_UWORD)uval; + if (uval<=0xff) { + SPEC_NOUN(val->type)=V_CHAR; + } } } else { // not unsigned if (sval<0) { if (sval>=-32768) { SPEC_LONG(val->type)=0; - SPEC_CVAL(val->type).v_int = sval & 0xffff; - } - if (sval>=-128) { - SPEC_NOUN(val->type)=V_CHAR; - SPEC_CVAL(val->type).v_int &= 0xff; + SPEC_CVAL(val->type).v_int = (TYPE_WORD)sval; + if (sval>=-128) { + SPEC_NOUN(val->type)=V_CHAR; + } } } else { // sval>=0 - SPEC_USIGN(val->type)=1; - if (sval<=65535) { + if (sval<=32767) { SPEC_LONG(val->type)=0; - SPEC_CVAL(val->type).v_int = sval; - } - if (sval<=255) { - SPEC_NOUN(val->type)=V_CHAR; + SPEC_CVAL(val->type).v_int = (TYPE_WORD)sval; + if (sval<=127) { + SPEC_NOUN(val->type)=V_CHAR; + } } } } return val; } +#else + +static value *cheapestVal (value *val) +{ + if (IS_FLOAT (val->type) || IS_FIXED (val->type) || IS_CHAR (val->type)) + return val; + + /* - signed/unsigned must not be changed. + - long must not be changed. + + the only possible reduction is from signed int to signed char, + because it's automatically promoted back to signed int. + + a reduction from unsigned int to unsigned char is a bug, + because an _unsigned_ char is promoted to _signed_ int! */ + if (IS_INT(val->type) && + !SPEC_USIGN(val->type) && + !SPEC_LONG(val->type) && + SPEC_CVAL(val->type).v_int >= -128 && + SPEC_CVAL(val->type).v_int < 0) + + { + SPEC_NOUN(val->type) = V_CHAR; + } + /* 'unsigned char' promotes to 'signed int', so that we can + reduce it the other way */ + if (IS_INT(val->type) && + !SPEC_USIGN(val->type) && + !SPEC_LONG(val->type) && + SPEC_CVAL(val->type).v_int >= 0 && + SPEC_CVAL(val->type).v_int <= 255) + + { + SPEC_NOUN(val->type) = V_CHAR; + SPEC_USIGN(val->type) = 1; + } + return (val); +} +#endif + /*-----------------------------------------------------------------*/ /* valueFromLit - creates a value from a literal */ /*-----------------------------------------------------------------*/ @@ -376,13 +429,13 @@ valueFromLit (double lit) { char buffer[50]; - if ((((long) lit) - lit) == 0) + if ((((TYPE_DWORD) lit) - lit) == 0) { - sprintf (buffer, "%ld", (long) lit); + SNPRINTF (buffer, sizeof(buffer), "%d", (TYPE_DWORD) lit); return constVal (buffer); } - sprintf (buffer, "%f", lit); + SNPRINTF (buffer, sizeof(buffer), "%f", lit); return constFloatVal (buffer); } @@ -401,8 +454,7 @@ constFloatVal (char *s) return constVal ("0"); } - val->type = val->etype = newLink (); - val->type->class = SPECIFIER; + val->type = val->etype = newLink (SPECIFIER); SPEC_NOUN (val->type) = V_FLOAT; SPEC_SCLS (val->type) = S_LITERAL; SPEC_CVAL (val->type).v_float = sval; @@ -410,6 +462,29 @@ constFloatVal (char *s) return val; } +/*-----------------------------------------------------------------*/ +/* constFixed16x16Val - converts a FIXED16X16 constant to value */ +/*-----------------------------------------------------------------*/ +value * +constFixed16x16Val (char *s) +{ + value *val = newValue (); + double sval; + + if (sscanf (s, "%lf", &sval) != 1) + { + werror (E_INVALID_FLOAT_CONST, s); + return constVal ("0"); + } + + val->type = val->etype = newLink (SPECIFIER); + SPEC_NOUN (val->type) = V_FLOAT; + SPEC_SCLS (val->type) = S_LITERAL; + SPEC_CVAL (val->type).v_fixed16x16 = fixed16x16FromDouble ( sval ); + + return val; +} + /*-----------------------------------------------------------------*/ /* constVal - converts an INTEGER constant into a cheapest value */ /*-----------------------------------------------------------------*/ @@ -417,18 +492,15 @@ value *constVal (char *s) { value *val; short hex = 0, octal = 0; - char scanFmt[10]; - int scI = 0; - long sval; + double dval; val = newValue (); /* alloc space for value */ - val->type = val->etype = newLink (); /* create the spcifier */ - val->type->class = SPECIFIER; + val->type = val->etype = newLink (SPECIFIER); /* create the spcifier */ SPEC_SCLS (val->type) = S_LITERAL; - // let's start with an unsigned char + // let's start with a signed char SPEC_NOUN (val->type) = V_CHAR; - SPEC_USIGN (val->type) = 1; + SPEC_USIGN (val->type) = 0; hex = ((strchr (s, 'x') || strchr (s, 'X')) ? 1 : 0); @@ -436,68 +508,99 @@ value *constVal (char *s) if (!hex && *s == '0' && *(s + 1)) octal = 1; - /* create the scan string */ - scanFmt[scI++] = '%'; - - scanFmt[scI++] = 'l'; - - if (octal) - scanFmt[scI++] = 'o'; - else if (hex) - scanFmt[scI++] = 'x'; - else - scanFmt[scI++] = 'd'; - - scanFmt[scI++] = '\0'; - - sscanf (s, scanFmt, &sval); + errno = 0; + if (hex || octal) { + unsigned long sval; + sval = strtoul (s, NULL, 0); + dval=sval; + if (errno) { + dval = 4294967295.0; + werror (W_INVALID_INT_CONST, s, dval); + } + } else { + sscanf (s, "%lf", &dval); + } /* Setup the flags first */ - /* set the _long flag if 'lL' is found */ - if (strchr (s, 'l') || strchr (s, 'L')) - SPEC_LONG (val->type) = 1; + /* set the unsigned flag if 'uU' is found */ + if (strchr (s, 'u') || strchr (s, 'U')) { + SPEC_USIGN (val->type) = 1; + } - if (sval<0) { // "-28u" will still be signed and negative - SPEC_USIGN (val->type) = 0; - if (sval<-32768) { // check if we have to promote to long - SPEC_NOUN (val->type) = V_INT; - SPEC_LONG (val->type) = 1; - } else { - if (sval<-128) { // check if we have to promote to int - SPEC_NOUN (val->type) = V_INT; - } - } + /* set the b_long flag if 'lL' is found */ + if (strchr (s, 'l') || strchr (s, 'L')) { + SPEC_NOUN (val->type) = V_INT; + SPEC_LONG (val->type) = 1; } else { - if (sval>0xffff) { // check if we have to promote to long - SPEC_NOUN (val->type) = V_INT; - SPEC_LONG (val->type) = 1; - } else { - if (sval>0xff) { // check if we have to promote to int - SPEC_NOUN (val->type) = V_INT; + if (dval<0) { // "-28u" will still be signed and negative + if (dval<-128) { // check if we have to promote to int + SPEC_NOUN (val->type) = V_INT; + } + if (dval<-32768) { // check if we have to promote to long int + SPEC_LONG (val->type) = 1; + } + } else { // >=0 + if (dval>0xff || /* check if we have to promote to int */ + SPEC_USIGN (val->type)) { /* if it's unsigned, we can't use unsigned + char. After an integral promotion it will + be a signed int; this certainly isn't what + the programer wants */ + SPEC_NOUN (val->type) = V_INT; + } + else { /* store char's always as unsigned; this helps other optimizations */ + SPEC_USIGN (val->type) = 1; + } + if (dval>0xffff && SPEC_USIGN (val->type)) { // check if we have to promote to long + SPEC_LONG (val->type) = 1; + } + else if (dval>0x7fff && !SPEC_USIGN (val->type)) { // check if we have to promote to long int + if ((hex || octal) && /* hex or octal constants may be stored in unsigned type */ + dval<=0xffff) { + SPEC_USIGN (val->type) = 1; + } else { + SPEC_LONG (val->type) = 1; + if (dval>0x7fffffff) { + SPEC_USIGN (val->type) = 1; + } + } } } } + /* check for out of range */ + if (dval<-2147483648.0) { + dval = -2147483648.0; + werror (W_INVALID_INT_CONST, s, dval); + } + if (dval>2147483647.0 && !SPEC_USIGN (val->type)) { + dval = 2147483647.0; + werror (W_INVALID_INT_CONST, s, dval); + } + if (dval>4294967295.0) { + dval = 4294967295.0; + werror (W_INVALID_INT_CONST, s, dval); + } + if (SPEC_LONG (val->type)) { if (SPEC_USIGN (val->type)) { - SPEC_CVAL (val->type).v_ulong = sval; + SPEC_CVAL (val->type).v_ulong = (TYPE_UDWORD)dval; } else { - SPEC_CVAL (val->type).v_long = sval; + SPEC_CVAL (val->type).v_long = (TYPE_DWORD)dval; } } else { if (SPEC_USIGN (val->type)) { - SPEC_CVAL (val->type).v_uint = sval; + SPEC_CVAL (val->type).v_uint = (TYPE_UWORD)dval; } else { - SPEC_CVAL (val->type).v_int = sval; + SPEC_CVAL (val->type).v_int = (TYPE_WORD)dval; } } @@ -513,12 +616,12 @@ unsigned char hexEscape(char **src) { char *s ; unsigned long value ; - + (*src)++ ; /* Skip over the 'x' */ s = *src ; /* Save for error detection */ - + value = strtol (*src, src, 16); - + if (s == *src) { // no valid hex found werror(E_INVALID_HEX); @@ -556,9 +659,9 @@ unsigned char octalEscape (char **str) { return value; } -/*! +/*! /fn int copyStr (char *dest, char *src) - + Copies a source string to a dest buffer interpreting escape sequences and special characters @@ -568,7 +671,7 @@ unsigned char octalEscape (char **str) { */ -int +int copyStr (char *dest, char *src) { @@ -617,7 +720,7 @@ copyStr (char *dest, char *src) src-- ; break; - case 'x': + case 'x': *dest++ = hexEscape(&src) ; src-- ; break ; @@ -659,10 +762,9 @@ strVal (char *s) val = newValue (); /* get a new one */ /* get a declarator */ - val->type = newLink (); + val->type = newLink (DECLARATOR); DCL_TYPE (val->type) = ARRAY; - val->type->next = val->etype = newLink (); - val->etype->class = SPECIFIER; + val->type->next = val->etype = newLink (SPECIFIER); SPEC_NOUN (val->etype) = V_CHAR; SPEC_SCLS (val->etype) = S_LITERAL; @@ -752,7 +854,7 @@ copyValue (value * src) dest = newValue (); dest->sym = copySymbol (src->sym); - strcpy (dest->name, src->name); + strncpyz (dest->name, src->name, SDCC_NAME_MAX); dest->type = (src->type ? copyLinkChain (src->type) : NULL); dest->etype = (src->type ? getSpec (dest->type) : NULL); @@ -766,12 +868,10 @@ value * charVal (char *s) { value *val; -// unsigned uValue ; val = newValue (); - val->type = val->etype = newLink (); - val->type->class = SPECIFIER; + val->type = val->etype = newLink (SPECIFIER); SPEC_NOUN (val->type) = V_CHAR; SPEC_USIGN(val->type) = 1; SPEC_SCLS (val->type) = S_LITERAL; @@ -784,37 +884,37 @@ charVal (char *s) switch (*s) { case 'n': - SPEC_CVAL (val->type).v_int = '\n'; + SPEC_CVAL (val->type).v_uint = '\n'; break; case 't': - SPEC_CVAL (val->type).v_int = '\t'; + SPEC_CVAL (val->type).v_uint = '\t'; break; case 'v': - SPEC_CVAL (val->type).v_int = '\v'; + SPEC_CVAL (val->type).v_uint = '\v'; break; case 'b': - SPEC_CVAL (val->type).v_int = '\b'; + SPEC_CVAL (val->type).v_uint = '\b'; break; case 'r': - SPEC_CVAL (val->type).v_int = '\r'; + SPEC_CVAL (val->type).v_uint = '\r'; break; case 'f': - SPEC_CVAL (val->type).v_int = '\f'; + SPEC_CVAL (val->type).v_uint = '\f'; break; case 'a': - SPEC_CVAL (val->type).v_int = '\a'; + SPEC_CVAL (val->type).v_uint = '\a'; break; case '\\': - SPEC_CVAL (val->type).v_int = '\\'; + SPEC_CVAL (val->type).v_uint = '\\'; break; case '\?': - SPEC_CVAL (val->type).v_int = '\?'; + SPEC_CVAL (val->type).v_uint = '\?'; break; case '\'': - SPEC_CVAL (val->type).v_int = '\''; + SPEC_CVAL (val->type).v_uint = '\''; break; case '\"': - SPEC_CVAL (val->type).v_int = '\"'; + SPEC_CVAL (val->type).v_uint = '\"'; break; case '0' : @@ -856,9 +956,9 @@ valFromType (sym_link * type) } /*------------------------------------------------------------------*/ -/* floatFromVal - value to unsinged integer conversion */ +/* floatFromVal - value to double float conversion */ /*------------------------------------------------------------------*/ -double +double floatFromVal (value * val) { if (!val) @@ -878,6 +978,9 @@ floatFromVal (value * val) if (SPEC_NOUN (val->etype) == V_FLOAT) return (double) SPEC_CVAL (val->etype).v_float; + if (SPEC_NOUN (val->etype) == V_FIXED16X16) + return (double) doubleFromFixed16x16( SPEC_CVAL (val->etype).v_fixed16x16 ); + if (SPEC_LONG (val->etype)) { if (SPEC_USIGN (val->etype)) @@ -885,20 +988,34 @@ floatFromVal (value * val) else return (double) SPEC_CVAL (val->etype).v_long; } - - if (SPEC_NOUN(val->etype)==V_INT) { + + if (SPEC_NOUN (val->etype) == V_INT) { if (SPEC_USIGN (val->etype)) return (double) SPEC_CVAL (val->etype).v_uint; else return (double) SPEC_CVAL (val->etype).v_int; - } else { // SPEC_NOUN==V_CHAR + } + + if (SPEC_NOUN (val->etype) == V_CHAR) { if (SPEC_USIGN (val->etype)) - return (double) ((unsigned char)SPEC_CVAL (val->etype).v_uint); + return (double) (unsigned char)SPEC_CVAL (val->etype).v_uint; else - return (double) ((signed char)SPEC_CVAL (val->etype).v_int); + return (double) (signed char)SPEC_CVAL (val->etype).v_int; } -} + if (IS_BITVAR(val->etype)) { + return (double) SPEC_CVAL (val->etype).v_uint; + } + + if (SPEC_NOUN (val->etype) == V_VOID) { + return (double) SPEC_CVAL (val->etype).v_ulong; + } + + // we are lost ! + werror (E_INTERNAL_ERROR, __FILE__, __LINE__, + "floatFromVal: unknown value"); + return 0; +} /*------------------------------------------------------------------*/ /* valUnaryPM - does the unary +/- operation on a constant */ @@ -909,6 +1026,8 @@ valUnaryPM (value * val) /* depending on type */ if (SPEC_NOUN (val->etype) == V_FLOAT) SPEC_CVAL (val->etype).v_float = -1.0 * SPEC_CVAL (val->etype).v_float; + if (SPEC_NOUN (val->etype) == V_FIXED16X16) + SPEC_CVAL (val->etype).v_fixed16x16 = -SPEC_CVAL (val->etype).v_fixed16x16; else { if (SPEC_LONG (val->etype)) @@ -924,13 +1043,16 @@ valUnaryPM (value * val) SPEC_CVAL (val->etype).v_uint = 0-SPEC_CVAL (val->etype).v_uint; else SPEC_CVAL (val->etype).v_int = -SPEC_CVAL (val->etype).v_int; - if (SPEC_NOUN (val->etype)==V_CHAR) { - SPEC_CVAL (val->etype).v_uint &= 0xff; - } } } // -(unsigned 3) now really is signed SPEC_USIGN(val->etype)=0; + // -(unsigned char)135 now really is an int + if (SPEC_NOUN(val->etype) == V_CHAR) { + if (SPEC_CVAL(val->etype).v_int < -128) { + SPEC_NOUN(val->etype) = V_INT; + } + } return val; } @@ -954,10 +1076,13 @@ valComplement (value * val) SPEC_CVAL (val->etype).v_uint = ~SPEC_CVAL (val->etype).v_uint; else SPEC_CVAL (val->etype).v_int = ~SPEC_CVAL (val->etype).v_int; - if (SPEC_NOUN (val->etype)==V_CHAR) { - SPEC_CVAL (val->etype).v_uint &= 0xff; - } + if (SPEC_NOUN(val->etype) == V_CHAR) + if ( SPEC_CVAL(val->etype).v_int < -128 + || SPEC_CVAL(val->etype).v_int > 127) + SPEC_NOUN(val->etype) = V_INT; } + // ~(unsigned 3) now really is signed + SPEC_USIGN(val->etype)=0; return val; } @@ -981,9 +1106,6 @@ valNot (value * val) SPEC_CVAL (val->etype).v_uint = !SPEC_CVAL (val->etype).v_uint; else SPEC_CVAL (val->etype).v_int = !SPEC_CVAL (val->etype).v_int; - if (SPEC_NOUN (val->etype)==V_CHAR) { - SPEC_CVAL (val->etype).v_uint &= 0xff; - } } return val; } @@ -998,38 +1120,41 @@ valMult (value * lval, value * rval) /* create a new value */ val = newValue (); - val->type = val->etype = newLink (); - val->type->class = SPECIFIER; - SPEC_NOUN (val->type) = (IS_FLOAT (lval->etype) || - IS_FLOAT (rval->etype) ? V_FLOAT : V_INT); - SPEC_SCLS (val->type) = S_LITERAL; /* will remain literal */ - SPEC_USIGN (val->type) = (SPEC_USIGN (lval->etype) & SPEC_USIGN (rval->etype)); - SPEC_LONG (val->type) = (SPEC_LONG (lval->etype) | SPEC_LONG (rval->etype)); + val->type = val->etype = computeType (lval->etype, + rval->etype, + RESULT_TYPE_INT, + '*'); + SPEC_SCLS (val->etype) = S_LITERAL; /* will remain literal */ if (IS_FLOAT (val->type)) SPEC_CVAL (val->type).v_float = floatFromVal (lval) * floatFromVal (rval); else + if (IS_FIXED16X16 (val->type)) + SPEC_CVAL (val->type).v_fixed16x16 = fixed16x16FromDouble(floatFromVal (lval) * floatFromVal (rval)); + /* signed and unsigned mul are the same, as long as the precision of the + result isn't bigger than the precision of the operands. */ + else if (SPEC_LONG (val->type)) + SPEC_CVAL (val->type).v_ulong = (TYPE_UDWORD) floatFromVal (lval) * + (TYPE_UDWORD) floatFromVal (rval); + else if (SPEC_USIGN (val->type)) /* unsigned int */ { - if (SPEC_LONG (val->type)) - { - if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_ulong = (unsigned long) floatFromVal (lval) * - (unsigned long) floatFromVal (rval); - else - SPEC_CVAL (val->type).v_long = (long) floatFromVal (lval) * - (long) floatFromVal (rval); - } - else - { - if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_uint = (unsigned) floatFromVal (lval) * - (unsigned) floatFromVal (rval); - else - SPEC_CVAL (val->type).v_int = (int) floatFromVal (lval) * - (int) floatFromVal (rval); - } + TYPE_UDWORD ul = (TYPE_UWORD) floatFromVal (lval) * + (TYPE_UWORD) floatFromVal (rval); + + SPEC_CVAL (val->type).v_uint = (TYPE_UWORD) ul; + if (ul != (TYPE_UWORD) ul) + werror (W_INT_OVL); } - return cheapestVal(val); + else /* signed int */ + { + TYPE_DWORD l = (TYPE_WORD) floatFromVal (lval) * + (TYPE_WORD) floatFromVal (rval); + + SPEC_CVAL (val->type).v_int = (TYPE_WORD) l; + if (l != (TYPE_WORD) l) + werror (W_INT_OVL); + } + return cheapestVal (val); } /*------------------------------------------------------------------*/ @@ -1048,40 +1173,36 @@ valDiv (value * lval, value * rval) /* create a new value */ val = newValue (); - val->type = val->etype = newLink(); - val->type->class = SPECIFIER; - SPEC_NOUN (val->type) = (IS_FLOAT (lval->etype) || - IS_FLOAT (rval->etype) ? V_FLOAT : V_INT); - SPEC_SCLS (val->etype) = S_LITERAL; - SPEC_USIGN (val->type) = (SPEC_USIGN (lval->etype) & SPEC_USIGN (rval->etype)); - SPEC_LONG (val->type) = (SPEC_LONG (lval->etype) | SPEC_LONG (rval->etype)); + val->type = val->etype = computeType (lval->etype, + rval->etype, + RESULT_TYPE_INT, + '/'); + SPEC_SCLS (val->etype) = S_LITERAL; /* will remain literal */ if (IS_FLOAT (val->type)) SPEC_CVAL (val->type).v_float = floatFromVal (lval) / floatFromVal (rval); else + if (IS_FIXED16X16 (val->type)) + SPEC_CVAL (val->type).v_fixed16x16 = fixed16x16FromDouble( floatFromVal (lval) / floatFromVal (rval) ); + else if (SPEC_LONG (val->type)) { - if (SPEC_LONG (val->type)) - { - if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_ulong = - (unsigned long) floatFromVal (lval) / - (unsigned long) floatFromVal (rval); - else - SPEC_CVAL (val->type).v_long = (long) floatFromVal (lval) / - (long) floatFromVal (rval); - } + if (SPEC_USIGN (val->type)) + SPEC_CVAL (val->type).v_ulong = (TYPE_UDWORD) floatFromVal (lval) / + (TYPE_UDWORD) floatFromVal (rval); else - { - if (SPEC_USIGN (val->type)) { - SPEC_CVAL (val->type).v_uint = (unsigned) floatFromVal (lval) / - (unsigned) floatFromVal (rval); - } else { - SPEC_CVAL (val->type).v_int = (int) floatFromVal (lval) / - (int) floatFromVal (rval); - } - } + SPEC_CVAL (val->type).v_long = (TYPE_DWORD) floatFromVal (lval) / + (TYPE_DWORD) floatFromVal (rval); } - return cheapestVal(val); + else + { + if (SPEC_USIGN (val->type)) + SPEC_CVAL (val->type).v_uint = (TYPE_UWORD) floatFromVal (lval) / + (TYPE_UWORD) floatFromVal (rval); + else + SPEC_CVAL (val->type).v_int = (TYPE_WORD) floatFromVal (lval) / + (TYPE_WORD) floatFromVal (rval); + } + return cheapestVal (val); } /*------------------------------------------------------------------*/ @@ -1093,35 +1214,32 @@ valMod (value * lval, value * rval) value *val; /* create a new value */ - val = newValue (); - val->type = val->etype = newLink (); - val->type->class = SPECIFIER; - SPEC_NOUN (val->type) = V_INT; /* type is int */ - SPEC_SCLS (val->type) = S_LITERAL; /* will remain literal */ - SPEC_USIGN (val->type) = (SPEC_USIGN (lval->etype) & SPEC_USIGN (rval->etype)); - SPEC_LONG (val->type) = (SPEC_LONG (lval->etype) | SPEC_LONG (rval->etype)); + val = newValue(); + val->type = val->etype = computeType (lval->etype, + rval->etype, + RESULT_TYPE_INT, + '%'); + SPEC_SCLS (val->etype) = S_LITERAL; /* will remain literal */ if (SPEC_LONG (val->type)) { if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_ulong = (unsigned long) floatFromVal (lval) % - (unsigned long) floatFromVal (rval); + SPEC_CVAL (val->type).v_ulong = (TYPE_UDWORD) floatFromVal (lval) % + (TYPE_UDWORD) floatFromVal (rval); else - SPEC_CVAL (val->type).v_long = (unsigned long) floatFromVal (lval) % - (unsigned long) floatFromVal (rval); + SPEC_CVAL (val->type).v_long = (TYPE_DWORD) floatFromVal (lval) % + (TYPE_DWORD) floatFromVal (rval); } else { - if (SPEC_USIGN (val->type)) { - SPEC_CVAL (val->type).v_uint = (unsigned) floatFromVal (lval) % - (unsigned) floatFromVal (rval); - } else { - SPEC_CVAL (val->type).v_int = (unsigned) floatFromVal (lval) % - (unsigned) floatFromVal (rval); - } + if (SPEC_USIGN (val->type)) + SPEC_CVAL (val->type).v_uint = (TYPE_UWORD) floatFromVal (lval) % + (TYPE_UWORD) floatFromVal (rval); + else + SPEC_CVAL (val->type).v_int = (TYPE_WORD) floatFromVal (lval) % + (TYPE_WORD) floatFromVal (rval); } - - return cheapestVal(val); + return cheapestVal (val); } /*------------------------------------------------------------------*/ @@ -1133,44 +1251,37 @@ valPlus (value * lval, value * rval) value *val; /* create a new value */ - val = newValue (); - val->type = val->etype = newLink (); - val->type->class = SPECIFIER; - SPEC_NOUN (val->type) = (IS_FLOAT (lval->etype) || - IS_FLOAT (rval->etype) ? V_FLOAT : V_INT); - SPEC_SCLS (val->type) = S_LITERAL; /* will remain literal */ - SPEC_USIGN (val->type) = - SPEC_USIGN (lval->etype) && - SPEC_USIGN (rval->etype) && - (floatFromVal(lval)+floatFromVal(rval))>=0; - - SPEC_LONG (val->type) = (SPEC_LONG (lval->etype) | SPEC_LONG (rval->etype)); + val = newValue(); + val->type = val->etype = computeType (lval->etype, + rval->etype, + RESULT_TYPE_INT, + '+'); + SPEC_SCLS (val->etype) = S_LITERAL; /* will remain literal */ if (IS_FLOAT (val->type)) SPEC_CVAL (val->type).v_float = floatFromVal (lval) + floatFromVal (rval); else + if (IS_FIXED16X16 (val->type)) + SPEC_CVAL (val->type).v_fixed16x16 = fixed16x16FromDouble( floatFromVal (lval) + floatFromVal (rval) ); + else if (SPEC_LONG (val->type)) { - if (SPEC_LONG (val->type)) - { - if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_ulong = (unsigned long) floatFromVal (lval) + - (unsigned long) floatFromVal (rval); - else - SPEC_CVAL (val->type).v_long = (long) floatFromVal (lval) + - (long) floatFromVal (rval); - } + if (SPEC_USIGN (val->type)) + SPEC_CVAL (val->type).v_ulong = (TYPE_UDWORD) floatFromVal (lval) + + (TYPE_UDWORD) floatFromVal (rval); else - { - if (SPEC_USIGN (val->type)) { - SPEC_CVAL (val->type).v_uint = (unsigned) floatFromVal (lval) + - (unsigned) floatFromVal (rval); - } else { - SPEC_CVAL (val->type).v_int = (int) floatFromVal (lval) + - (int) floatFromVal (rval); - } - } + SPEC_CVAL (val->type).v_long = (TYPE_DWORD) floatFromVal (lval) + + (TYPE_DWORD) floatFromVal (rval); } - return cheapestVal(val); + else + { + if (SPEC_USIGN (val->type)) + SPEC_CVAL (val->type).v_uint = (TYPE_UWORD) floatFromVal (lval) + + (TYPE_UWORD) floatFromVal (rval); + else + SPEC_CVAL (val->type).v_int = (TYPE_WORD) floatFromVal (lval) + + (TYPE_WORD) floatFromVal (rval); + } + return cheapestVal (val); } /*------------------------------------------------------------------*/ @@ -1182,46 +1293,37 @@ valMinus (value * lval, value * rval) value *val; /* create a new value */ - val = newValue (); - val->type = val->etype = newLink (); - val->type->class = SPECIFIER; - SPEC_NOUN (val->type) = (IS_FLOAT (lval->etype) || - IS_FLOAT (rval->etype) ? V_FLOAT : V_INT); - SPEC_SCLS (val->type) = S_LITERAL; /* will remain literal */ - SPEC_USIGN (val->type) = - SPEC_USIGN (lval->etype) && - SPEC_USIGN (rval->etype) && - (floatFromVal(lval)-floatFromVal(rval))>=0; - - SPEC_LONG (val->type) = (SPEC_LONG (lval->etype) | SPEC_LONG (rval->etype)); + val = newValue(); + val->type = val->etype = computeType (lval->etype, + rval->etype, + RESULT_TYPE_INT, + '-'); + SPEC_SCLS (val->etype) = S_LITERAL; /* will remain literal */ if (IS_FLOAT (val->type)) SPEC_CVAL (val->type).v_float = floatFromVal (lval) - floatFromVal (rval); else + if (IS_FIXED16X16 (val->type)) + SPEC_CVAL (val->type).v_fixed16x16 = fixed16x16FromDouble( floatFromVal (lval) - floatFromVal (rval) ); + else if (SPEC_LONG (val->type)) { - if (SPEC_LONG (val->type)) - { - if (SPEC_USIGN (val->type)) { - SPEC_CVAL (val->type).v_ulong = - (unsigned long) floatFromVal (lval) - - (unsigned long) floatFromVal (rval); - } else { - SPEC_CVAL (val->type).v_long = (long) floatFromVal (lval) - - (long) floatFromVal (rval); - } - } + if (SPEC_USIGN (val->type)) + SPEC_CVAL (val->type).v_ulong = (TYPE_UDWORD) floatFromVal (lval) - + (TYPE_UDWORD) floatFromVal (rval); else - { - if (SPEC_USIGN (val->type)) { - SPEC_CVAL (val->type).v_uint = (unsigned) floatFromVal (lval) - - (unsigned) floatFromVal (rval); - } else { - SPEC_CVAL (val->type).v_int = (int) floatFromVal (lval) - - (int) floatFromVal (rval); - } - } + SPEC_CVAL (val->type).v_long = (TYPE_DWORD) floatFromVal (lval) - + (TYPE_DWORD) floatFromVal (rval); } - return cheapestVal(val); + else + { + if (SPEC_USIGN (val->type)) + SPEC_CVAL (val->type).v_uint = (TYPE_UWORD) floatFromVal (lval) - + (TYPE_UWORD) floatFromVal (rval); + else + SPEC_CVAL (val->type).v_int = (TYPE_WORD) floatFromVal (lval) - + (TYPE_WORD) floatFromVal (rval); + } + return cheapestVal (val); } /*------------------------------------------------------------------*/ @@ -1233,37 +1335,53 @@ valShift (value * lval, value * rval, int lr) value *val; /* create a new value */ - val = newValue (); - val->type = val->etype = newIntLink (); - SPEC_SCLS (val->type) = S_LITERAL; /* will remain literal */ - SPEC_USIGN (val->type) = (SPEC_USIGN (lval->etype) & SPEC_USIGN (rval->etype)); - SPEC_LONG (val->type) = (SPEC_LONG (lval->etype) | SPEC_LONG (rval->etype)); + val = newValue(); + val->type = val->etype = computeType (lval->etype, + NULL, + RESULT_TYPE_INT, + 'S'); + SPEC_SCLS (val->etype) = S_LITERAL; /* will remain literal */ + + if (getSize (val->type) * 8 <= (TYPE_UDWORD) floatFromVal (rval) && + /* left shift */ + (lr || + /* right shift and unsigned */ + (!lr && SPEC_USIGN (rval->type)))) + { + werror (W_SHIFT_CHANGED, (lr ? "left" : "right")); + } if (SPEC_LONG (val->type)) { if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_ulong = lr ? - (unsigned long) floatFromVal (lval) << (unsigned long) floatFromVal (rval) : \ - (unsigned long) floatFromVal (lval) >> (unsigned long) floatFromVal (rval); + { + SPEC_CVAL (val->type).v_ulong = lr ? + (TYPE_UDWORD) floatFromVal (lval) << (TYPE_UDWORD) floatFromVal (rval) : \ + (TYPE_UDWORD) floatFromVal (lval) >> (TYPE_UDWORD) floatFromVal (rval); + } else - SPEC_CVAL (val->type).v_long = lr ? - (long) floatFromVal (lval) << (long) floatFromVal (rval) : \ - (long) floatFromVal (lval) >> (long) floatFromVal (rval); + { + SPEC_CVAL (val->type).v_long = lr ? + (TYPE_DWORD) floatFromVal (lval) << (TYPE_UDWORD) floatFromVal (rval) : \ + (TYPE_DWORD) floatFromVal (lval) >> (TYPE_UDWORD) floatFromVal (rval); + } } else { - if (SPEC_USIGN (val->type)) { - SPEC_CVAL (val->type).v_uint = lr ? - (unsigned) floatFromVal (lval) << (unsigned) floatFromVal (rval) :\ - (unsigned) floatFromVal (lval) >> (unsigned) floatFromVal (rval); - } else { - SPEC_CVAL (val->type).v_int = lr ? - (int) floatFromVal (lval) << (int) floatFromVal (rval) : \ - (int) floatFromVal (lval) >> (int) floatFromVal (rval); - } + if (SPEC_USIGN (val->type)) + { + SPEC_CVAL (val->type).v_uint = lr ? + (TYPE_UWORD) floatFromVal (lval) << (TYPE_UDWORD) floatFromVal (rval) : \ + (TYPE_UWORD) floatFromVal (lval) >> (TYPE_UDWORD) floatFromVal (rval); + } + else + { + SPEC_CVAL (val->type).v_int = lr ? + (TYPE_WORD) floatFromVal (lval) << (TYPE_UDWORD) floatFromVal (rval) : \ + (TYPE_WORD) floatFromVal (lval) >> (TYPE_UDWORD) floatFromVal (rval); + } } - - return cheapestVal(val); + return cheapestVal (val); } /*------------------------------------------------------------------*/ @@ -1301,11 +1419,70 @@ valCompare (value * lval, value * rval, int ctype) break; case EQ_OP: - SPEC_CVAL (val->type).v_int = floatFromVal (lval) == floatFromVal (rval); + if (SPEC_NOUN(lval->type) == V_FLOAT || + SPEC_NOUN(rval->type) == V_FLOAT) + { + SPEC_CVAL (val->type).v_int = floatFromVal (lval) == floatFromVal (rval); + } + else + if (SPEC_NOUN(lval->type) == V_FIXED16X16 || + SPEC_NOUN(rval->type) == V_FIXED16X16) + { + SPEC_CVAL (val->type).v_int = floatFromVal (lval) == floatFromVal (rval); + } + else + { + /* integrals: ignore signedness */ + TYPE_UDWORD l, r; + + l = (TYPE_UDWORD) floatFromVal (lval); + r = (TYPE_UDWORD) floatFromVal (rval); + /* In order to correctly compare 'signed int' and 'unsigned int' it's + neccessary to strip them to 16 bit. + Literals are reduced to their cheapest type, therefore left and + right might have different types. It's neccessary to find a + common type: int (used for char too) or long */ + if (!IS_LONG (lval->etype) && + !IS_LONG (rval->etype)) + { + r = (TYPE_UWORD) r; + l = (TYPE_UWORD) l; + } + SPEC_CVAL (val->type).v_int = l == r; + } break; - case NE_OP: - SPEC_CVAL (val->type).v_int = floatFromVal (lval) != floatFromVal (rval); + if (SPEC_NOUN(lval->type) == V_FLOAT || + SPEC_NOUN(rval->type) == V_FLOAT) + { + SPEC_CVAL (val->type).v_int = floatFromVal (lval) != floatFromVal (rval); + } + else + if (SPEC_NOUN(lval->type) == V_FIXED16X16 || + SPEC_NOUN(rval->type) == V_FIXED16X16) + { + SPEC_CVAL (val->type).v_int = floatFromVal (lval) != floatFromVal (rval); + } + else + { + /* integrals: ignore signedness */ + TYPE_UDWORD l, r; + + l = (TYPE_UDWORD) floatFromVal (lval); + r = (TYPE_UDWORD) floatFromVal (rval); + /* In order to correctly compare 'signed int' and 'unsigned int' it's + neccessary to strip them to 16 bit. + Literals are reduced to their cheapest type, therefore left and + right might have different types. It's neccessary to find a + common type: int (used for char too) or long */ + if (!IS_LONG (lval->etype) && + !IS_LONG (rval->etype)) + { + r = (TYPE_UWORD) r; + l = (TYPE_UWORD) l; + } + SPEC_CVAL (val->type).v_int = l != r; + } break; } @@ -1323,8 +1500,9 @@ valBitwise (value * lval, value * rval, int op) /* create a new value */ val = newValue (); - val->type = copyLinkChain (lval->type); + val->type = computeType (lval->etype, rval->etype, RESULT_TYPE_CHAR, op); val->etype = getSpec (val->type); + SPEC_SCLS (val->etype) = S_LITERAL; switch (op) { @@ -1332,19 +1510,19 @@ valBitwise (value * lval, value * rval, int op) if (SPEC_LONG (val->type)) { if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_ulong = (unsigned long) floatFromVal (lval) & - (unsigned long) floatFromVal (rval); + SPEC_CVAL (val->type).v_ulong = (TYPE_UDWORD) floatFromVal (lval) & + (TYPE_UDWORD) floatFromVal (rval); else - SPEC_CVAL (val->type).v_long = (long) floatFromVal (lval) & - (long) floatFromVal (rval); + SPEC_CVAL (val->type).v_long = (TYPE_DWORD) floatFromVal (lval) & + (TYPE_DWORD) floatFromVal (rval); } else { if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_uint = (unsigned) floatFromVal (lval) & - (unsigned) floatFromVal (rval); + SPEC_CVAL (val->type).v_uint = (TYPE_UWORD) floatFromVal (lval) & + (TYPE_UWORD) floatFromVal (rval); else - SPEC_CVAL (val->type).v_int = (int) floatFromVal (lval) & (int) floatFromVal (rval); + SPEC_CVAL (val->type).v_int = (TYPE_WORD) floatFromVal (lval) & (TYPE_WORD) floatFromVal (rval); } break; @@ -1352,20 +1530,20 @@ valBitwise (value * lval, value * rval, int op) if (SPEC_LONG (val->type)) { if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_ulong = (unsigned long) floatFromVal (lval) | - (unsigned long) floatFromVal (rval); + SPEC_CVAL (val->type).v_ulong = (TYPE_UDWORD) floatFromVal (lval) | + (TYPE_UDWORD) floatFromVal (rval); else - SPEC_CVAL (val->type).v_long = (long) floatFromVal (lval) | - (long) floatFromVal (rval); + SPEC_CVAL (val->type).v_long = (TYPE_DWORD) floatFromVal (lval) | + (TYPE_DWORD) floatFromVal (rval); } else { if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_uint = (unsigned) floatFromVal (lval) | - (unsigned) floatFromVal (rval); + SPEC_CVAL (val->type).v_uint = (TYPE_UWORD) floatFromVal (lval) | + (TYPE_UWORD) floatFromVal (rval); else SPEC_CVAL (val->type).v_int = - (int) floatFromVal (lval) | (int) floatFromVal (rval); + (TYPE_WORD) floatFromVal (lval) | (TYPE_WORD) floatFromVal (rval); } break; @@ -1374,20 +1552,20 @@ valBitwise (value * lval, value * rval, int op) if (SPEC_LONG (val->type)) { if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_ulong = (unsigned long) floatFromVal (lval) ^ - (unsigned long) floatFromVal (rval); + SPEC_CVAL (val->type).v_ulong = (TYPE_UDWORD) floatFromVal (lval) ^ + (TYPE_UDWORD) floatFromVal (rval); else - SPEC_CVAL (val->type).v_long = (long) floatFromVal (lval) ^ - (long) floatFromVal (rval); + SPEC_CVAL (val->type).v_long = (TYPE_DWORD) floatFromVal (lval) ^ + (TYPE_DWORD) floatFromVal (rval); } else { if (SPEC_USIGN (val->type)) - SPEC_CVAL (val->type).v_uint = (unsigned) floatFromVal (lval) ^ - (unsigned) floatFromVal (rval); + SPEC_CVAL (val->type).v_uint = (TYPE_UWORD) floatFromVal (lval) ^ + (TYPE_UWORD) floatFromVal (rval); else SPEC_CVAL (val->type).v_int = - (int) floatFromVal (lval) ^ (int) floatFromVal (rval); + (TYPE_WORD) floatFromVal (lval) ^ (TYPE_WORD) floatFromVal (rval); } break; } @@ -1408,7 +1586,7 @@ valLogicAndOr (value * lval, value * rval, int op) val->type = val->etype = newCharLink (); val->type->class = SPECIFIER; SPEC_SCLS (val->type) = S_LITERAL; /* will remain literal */ - SPEC_USIGN (val->type) = 0; + SPEC_USIGN (val->type) = 1; switch (op) { @@ -1432,53 +1610,65 @@ value * valCastLiteral (sym_link * dtype, double fval) { value *val; + TYPE_UDWORD l = (TYPE_UDWORD)fval; if (!dtype) return NULL; val = newValue (); - val->etype = getSpec (val->type = copyLinkChain (dtype)); + if (dtype) + val->etype = getSpec (val->type = copyLinkChain (dtype)); + else + { + val->etype = val->type = newLink (SPECIFIER); + SPEC_NOUN (val->etype) = V_VOID; + } SPEC_SCLS (val->etype) = S_LITERAL; + /* if it is not a specifier then we can assume that */ /* it will be an unsigned long */ - if (!IS_SPEC (val->type)) - { - SPEC_CVAL (val->etype).v_ulong = (unsigned long) fval; + if (!IS_SPEC (val->type)) { + SPEC_CVAL (val->etype).v_ulong = l; return val; - } + } if (SPEC_NOUN (val->etype) == V_FLOAT) - SPEC_CVAL (val->etype).v_float = fval; - else - { - if (SPEC_LONG (val->etype)) - { + SPEC_CVAL (val->etype).v_float = fval; + else if (SPEC_NOUN (val->etype) == V_FIXED16X16) + SPEC_CVAL (val->etype).v_fixed16x16 = fixed16x16FromDouble( fval ); + else if (SPEC_NOUN (val->etype) == V_BIT || + SPEC_NOUN (val->etype) == V_SBIT) + SPEC_CVAL (val->etype).v_uint = l ? 1 : 0; + else if (SPEC_NOUN (val->etype) == V_BITFIELD) + SPEC_CVAL (val->etype).v_uint = l & + (0xffffu >> (16 - SPEC_BLEN (val->etype))); + else if (SPEC_NOUN (val->etype) == V_CHAR) { + if (SPEC_USIGN (val->etype)) + SPEC_CVAL (val->etype).v_uint= (TYPE_UBYTE) l; + else + SPEC_CVAL (val->etype).v_int = (TYPE_BYTE) l; + } else { + if (SPEC_LONG (val->etype)) { if (SPEC_USIGN (val->etype)) - SPEC_CVAL (val->etype).v_ulong = (unsigned long) fval; + SPEC_CVAL (val->etype).v_ulong = (TYPE_UDWORD) l; else - SPEC_CVAL (val->etype).v_long = (long) fval; - } - else - { + SPEC_CVAL (val->etype).v_long = (TYPE_DWORD) l; + } else { if (SPEC_USIGN (val->etype)) - SPEC_CVAL (val->etype).v_uint = (unsigned short)fval; + SPEC_CVAL (val->etype).v_uint = (TYPE_UWORD)l; else - SPEC_CVAL (val->etype).v_int = (short)fval; - if (SPEC_NOUN (val->etype)==V_CHAR) { - SPEC_CVAL (val->etype).v_uint &= 0xff; - } - } - } + SPEC_CVAL (val->etype).v_int = (TYPE_WORD)l; + } + } return val; } /*------------------------------------------------------------------*/ /* getNelements - determines # of elements from init list */ /*------------------------------------------------------------------*/ -int +int getNelements (sym_link * type, initList * ilist) { - sym_link *etype = getSpec (type); int i; if (!ilist) @@ -1489,13 +1679,13 @@ getNelements (sym_link * type, initList * ilist) /* if type is a character array and there is only one (string) initialiser then get the length of the string */ - if (IS_ARRAY (type) && IS_CHAR (etype) && !ilist->next) + if (IS_ARRAY (type) && IS_CHAR (type->next) && !ilist->next) { ast *iast = ilist->init.node; value *v = (iast->type == EX_VALUE ? iast->opval.val : NULL); if (!v) { - werror (W_INIT_WRONG); + werror (E_CONST_EXPECTED); return 0; } @@ -1512,7 +1702,6 @@ getNelements (sym_link * type, initList * ilist) i++; ilist = ilist->next; } - return i; } @@ -1550,19 +1739,20 @@ valForArray (ast * arrExpr) val = newValue (); if (!lval) - sprintf (buffer, "%s", AST_SYMBOL (arrExpr->left)->rname); + { + SNPRINTF (buffer, sizeof(buffer), "%s", AST_SYMBOL (arrExpr->left)->rname); + } else - sprintf (buffer, "%s", lval->name); + { + SNPRINTF (buffer, sizeof(buffer), "%s", lval->name); + } - sprintf (val->name, "(%s + %d)", buffer, + SNPRINTF (val->name, sizeof(val->name), "(%s + %d)", buffer, (int) AST_LIT_VALUE (arrExpr->right) * size); - val->type = newLink (); + val->type = newLink (DECLARATOR); if (SPEC_SCLS (arrExpr->left->etype) == S_CODE) - { - DCL_TYPE (val->type) = CPOINTER; - DCL_PTR_CONST (val->type) = port->mem.code_ro; - } + DCL_TYPE (val->type) = CPOINTER; else if (SPEC_SCLS (arrExpr->left->etype) == S_XDATA) DCL_TYPE (val->type) = FPOINTER; else if (SPEC_SCLS (arrExpr->left->etype) == S_XSTACK) @@ -1573,7 +1763,7 @@ valForArray (ast * arrExpr) DCL_TYPE (val->type) = EEPPOINTER; else DCL_TYPE (val->type) = POINTER; - val->type->next = arrExpr->left->ftype; + val->type->next = arrExpr->left->ftype->next; val->etype = getSpec (val->type); return val; } @@ -1617,19 +1807,20 @@ valForStructElem (ast * structT, ast * elemT) val = newValue (); if (!lval) - sprintf (buffer, "%s", AST_SYMBOL (structT)->rname); + { + SNPRINTF(buffer, sizeof(buffer), "%s", AST_SYMBOL (structT)->rname); + } else - sprintf (buffer, "%s", lval->name); + { + SNPRINTF (buffer, sizeof(buffer), "%s", lval->name); + } - sprintf (val->name, "(%s + %d)", buffer, + SNPRINTF (val->name, sizeof(val->name), "(%s + %d)", buffer, (int) sym->offset); - val->type = newLink (); + val->type = newLink (DECLARATOR); if (SPEC_SCLS (structT->etype) == S_CODE) - { - DCL_TYPE (val->type) = CPOINTER; - DCL_PTR_CONST (val->type) = port->mem.code_ro; - } + DCL_TYPE (val->type) = CPOINTER; else if (SPEC_SCLS (structT->etype) == S_XDATA) DCL_TYPE (val->type) = FPOINTER; else if (SPEC_SCLS (structT->etype) == S_XSTACK) @@ -1661,7 +1852,7 @@ valForCastAggr (ast * aexpr, sym_link * type, ast * cnst, int op) val = newValue (); - sprintf (val->name, "(%s %c %d)", + SNPRINTF (val->name, sizeof(val->name), "(%s %c %d)", AST_SYMBOL (aexpr)->rname, op, getSize (type->next) * (int) AST_LIT_VALUE (cnst)); @@ -1684,7 +1875,7 @@ valForCastArr (ast * aexpr, sym_link * type) val = newValue (); - sprintf (val->name, "(%s)", + SNPRINTF (val->name, sizeof(val->name), "(%s)", AST_SYMBOL (aexpr)->rname); val->type = type;