X-Git-Url: https://git.gag.com/?a=blobdiff_plain;f=src%2FSDCCast.c;h=8e20910cf1c505dae56081cc9e485c210bbe0a52;hb=67613b6eceb41c8a242c2556a0f59311adb0b388;hp=d0ba0c9b26fbabd151b9d0e13e3657df77f0574f;hpb=feddd68be35917362867a364ba8c51b7986cd67b;p=fw%2Fsdcc diff --git a/src/SDCCast.c b/src/SDCCast.c index d0ba0c9b..8e20910c 100644 --- a/src/SDCCast.c +++ b/src/SDCCast.c @@ -84,6 +84,7 @@ newAst_ (unsigned type) ex->level = NestLevel; ex->block = currBlockno; ex->initMode = inInitMode; + ex->seqPoint = seqPointNo; return ex; } @@ -273,6 +274,52 @@ ast *removeIncDecOps (ast * tree) { return tree; } +/*-----------------------------------------------------------------*/ +/* removePreIncDecOps: remove for side effects in *_ASSIGN's */ +/* "*++s += 3" -> "*++s = *++s + 3" */ +/*-----------------------------------------------------------------*/ +ast *removePreIncDecOps (ast * tree) { + + // traverse the tree and remove pre-inc/dec ops + + if (!tree) + return NULL; + + if (tree->type == EX_OP && + (tree->opval.op == INC_OP || tree->opval.op == DEC_OP)) { + if (tree->right) + tree=tree->right; + } + + tree->left=removePreIncDecOps(tree->left); + tree->right=removePreIncDecOps(tree->right); + + return tree; +} + +/*-----------------------------------------------------------------*/ +/* removePostIncDecOps: remove for side effects in *_ASSIGN's */ +/* "*s++ += 3" -> "*s++ = *s++ + 3" */ +/*-----------------------------------------------------------------*/ +ast *removePostIncDecOps (ast * tree) { + + // traverse the tree and remove pre-inc/dec ops + + if (!tree) + return NULL; + + if (tree->type == EX_OP && + (tree->opval.op == INC_OP || tree->opval.op == DEC_OP)) { + if (tree->left) + tree=tree->left; + } + + tree->left=removePostIncDecOps(tree->left); + tree->right=removePostIncDecOps(tree->right); + + return tree; +} + /*-----------------------------------------------------------------*/ /* hasSEFcalls - returns TRUE if tree has a function call */ /*-----------------------------------------------------------------*/ @@ -297,7 +344,7 @@ hasSEFcalls (ast * tree) /*-----------------------------------------------------------------*/ /* isAstEqual - compares two asts & returns 1 if they are equal */ /*-----------------------------------------------------------------*/ -int +static int isAstEqual (ast * t1, ast * t2) { if (!t1 && !t2) @@ -383,7 +430,8 @@ resolveSymbols (ast * tree) tree->trueLabel->name))) tree->trueLabel = csym; else - werror (E_LABEL_UNDEF, tree->trueLabel->name); + werrorfl (tree->filename, tree->lineno, E_LABEL_UNDEF, + tree->trueLabel->name); } if (tree->falseLabel) @@ -393,7 +441,8 @@ resolveSymbols (ast * tree) tree->falseLabel->name))) tree->falseLabel = csym; else - werror (E_LABEL_UNDEF, tree->falseLabel->name); + werrorfl (tree->filename, tree->lineno, E_LABEL_UNDEF, + tree->falseLabel->name); } } @@ -408,7 +457,8 @@ resolveSymbols (ast * tree) tree->opval.val->sym->name); if (!csym) - werror (E_LABEL_UNDEF, tree->opval.val->sym->name); + werrorfl (tree->filename, tree->lineno, E_LABEL_UNDEF, + tree->opval.val->sym->name); else tree->opval.val->sym = csym; @@ -447,7 +497,9 @@ resolveSymbols (ast * tree) tree->opval.val->sym->etype = newIntLink (); tree->opval.val->etype = tree->opval.val->etype; tree->opval.val->type = tree->opval.val->sym->type; - werror (W_IMPLICIT_FUNC, tree->opval.val->sym->name); + werrorfl (tree->filename, tree->lineno, W_IMPLICIT_FUNC, + tree->opval.val->sym->name); + //tree->opval.val->sym->undefined = 1; allocVariables (tree->opval.val->sym); } else @@ -592,37 +644,48 @@ reverseParms (ast * ptree) /* processParms - makes sure the parameters are okay and do some */ /* processing with them */ /*-----------------------------------------------------------------*/ -int -processParms (ast * func, +static int +processParms (ast *func, value *defParm, - ast * actParm, - int *parmNumber, // unused, although updated + ast *actParm, + int *parmNumber, /* unused, although updated */ bool rightmost) { + RESULT_TYPE resultType; + sym_link *functype; + /* if none of them exist */ if (!defParm && !actParm) return 0; - if (defParm) { - if (getenv("DEBUG_SANITY")) { - fprintf (stderr, "processParms: %s ", defParm->name); + if (defParm) + { + if (getenv("DEBUG_SANITY")) + { + fprintf (stderr, "processParms: %s ", defParm->name); + } + /* make sure the type is complete and sane */ + checkTypeSanity(defParm->etype, defParm->name); } - /* make sure the type is complete and sane */ - checkTypeSanity(defParm->etype, defParm->name); - } + if (IS_CODEPTR (func->ftype)) + functype = func->ftype->next; + else + functype = func->ftype; + /* if the function is being called via a pointer & */ /* it has not been defined a reentrant then we cannot */ /* have parameters */ - if (func->type != EX_VALUE && !IFFUNC_ISREENT (func->ftype) && !options.stackAuto) + if (func->type != EX_VALUE && !IFFUNC_ISREENT (functype) && !options.stackAuto) { werror (W_NONRENT_ARGS); + fatalError++; return 1; } /* if defined parameters ended but actual parameters */ /* exist and this is not defined as a variable arg */ - if (!defParm && actParm && !IFFUNC_HASVARARGS(func->ftype)) + if (!defParm && actParm && !IFFUNC_HASVARARGS(functype)) { werror (E_TOO_MANY_PARMS); return 1; @@ -635,13 +698,43 @@ processParms (ast * func, return 1; } - if (IS_VOID(actParm->ftype)) { - werror (E_VOID_VALUE_USED); - return 1; - } + /* if this is a PARAM node then match left & right */ + if (actParm->type == EX_OP && actParm->opval.op == PARAM) + { + actParm->decorated = 1; + return (processParms (func, defParm, + actParm->left, parmNumber, FALSE) || + processParms (func, defParm ? defParm->next : NULL, + actParm->right, parmNumber, rightmost)); + } + else if (defParm) /* not vararg */ + { + /* If we have found a value node by following only right-hand links, + * then we know that there are no more values after us. + * + * Therefore, if there are more defined parameters, the caller didn't + * supply enough. + */ + if (rightmost && defParm->next) + { + werror (E_TOO_FEW_PARMS); + return 1; + } + } + + /* decorate parameter */ + resultType = defParm ? getResultTypeFromType (defParm->etype) : + RESULT_TYPE_NONE; + actParm = decorateType (actParm, resultType); + + if (IS_VOID(actParm->ftype)) + { + werror (E_VOID_VALUE_USED); + return 1; + } /* If this is a varargs function... */ - if (!defParm && actParm && IFFUNC_HASVARARGS(func->ftype)) + if (!defParm && actParm && IFFUNC_HASVARARGS(functype)) { ast *newType = NULL; sym_link *ftype; @@ -654,25 +747,12 @@ processParms (ast * func, } ftype = actParm->ftype; - - /* If it's a small integer, upcast to int. */ + + /* If it's a char, upcast to int. */ if (IS_INTEGRAL (ftype) && (getSize (ftype) < (unsigned) INTSIZE)) { - if (IS_AST_OP(actParm) && - (actParm->opval.op == LEFT_OP || - actParm->opval.op == '*' || - actParm->opval.op == '+' || - actParm->opval.op == '-') && - actParm->right) { - // we should cast an operand instead of the result - actParm->decorated = 0; - actParm->left = newNode( CAST, newAst_LINK(newIntLink()), - actParm->left); - actParm = decorateType(actParm); - } else { - newType = newAst_LINK(INTTYPE); - } + newType = newAst_LINK(INTTYPE); } if (IS_PTR(ftype) && !IS_GENPTR(ftype)) @@ -686,74 +766,53 @@ processParms (ast * func, newType = newAst_LINK (copyLinkChain (ftype)); DCL_TYPE (newType->opval.lnk) = port->unqualified_pointer; } + if (newType) { /* cast required; change this op to a cast. */ - ast *parmCopy = decorateType(resolveSymbols (copyAst (actParm))); + ast *parmCopy = resolveSymbols (copyAst (actParm)); actParm->type = EX_OP; actParm->opval.op = CAST; actParm->left = newType; actParm->right = parmCopy; - decorateType (actParm); - } - else if (actParm->type == EX_OP && actParm->opval.op == PARAM) - { - return (processParms (func, NULL, actParm->left, parmNumber, FALSE) || - processParms (func, NULL, actParm->right, parmNumber, rightmost)); + actParm->decorated = 0; /* force typechecking */ + decorateType (actParm, RESULT_TYPE_NONE); } return 0; - } + } /* vararg */ /* if defined parameters ended but actual has not & */ /* reentrant */ if (!defParm && actParm && - (options.stackAuto || IFFUNC_ISREENT (func->ftype))) + (options.stackAuto || IFFUNC_ISREENT (functype))) return 0; resolveSymbols (actParm); - /* if this is a PARAM node then match left & right */ - if (actParm->type == EX_OP && actParm->opval.op == PARAM) - { - return (processParms (func, defParm, actParm->left, parmNumber, FALSE) || - processParms (func, defParm->next, actParm->right, parmNumber, rightmost)); - } - else + + /* the parameter type must be at least castable */ + if (compareType (defParm->type, actParm->ftype) == 0) { - /* If we have found a value node by following only right-hand links, - * then we know that there are no more values after us. - * - * Therefore, if there are more defined parameters, the caller didn't - * supply enough. - */ - if (rightmost && defParm->next) - { - werror (E_TOO_FEW_PARMS); - return 1; - } + werror (E_INCOMPAT_TYPES); + printFromToType (actParm->ftype, defParm->type); + return 1; } - /* the parameter type must be at least castable */ - if (compareType (defParm->type, actParm->ftype) == 0) { - werror (E_INCOMPAT_TYPES); - printFromToType (actParm->ftype, defParm->type); - return 1; - } - /* if the parameter is castable then add the cast */ if (compareType (defParm->type, actParm->ftype) < 0) { - ast *pTree = decorateType(resolveSymbols (copyAst (actParm))); + ast *pTree; + resultType = getResultTypeFromType (defParm->etype); + pTree = resolveSymbols (copyAst (actParm)); + /* now change the current one to a cast */ actParm->type = EX_OP; actParm->opval.op = CAST; actParm->left = newAst_LINK (defParm->type); actParm->right = pTree; - actParm->etype = defParm->etype; - actParm->ftype = defParm->type; - actParm->decorated=0; /* force typechecking */ - decorateType (actParm); + actParm->decorated = 0; /* force typechecking */ + decorateType (actParm, resultType); } /* make a copy and change the regparm type to the defined parm */ @@ -763,6 +822,7 @@ processParms (ast * func, (*parmNumber)++; return 0; } + /*-----------------------------------------------------------------*/ /* createIvalType - generates ival for basic types */ /*-----------------------------------------------------------------*/ @@ -775,8 +835,8 @@ createIvalType (ast * sym, sym_link * type, initList * ilist) if (ilist->type == INIT_DEEP) ilist = ilist->init.deep; - iExpr = decorateType (resolveSymbols (list2expr (ilist))); - return decorateType (newNode ('=', sym, iExpr)); + iExpr = decorateType (resolveSymbols (list2expr (ilist)), RESULT_CHECK); + return decorateType (newNode ('=', sym, iExpr), RESULT_CHECK); } /*-----------------------------------------------------------------*/ @@ -806,13 +866,14 @@ createIvalStruct (ast * sym, sym_link * type, initList * ilist) break; sflds->implicit = 1; lAst = newNode (PTR_OP, newNode ('&', sym, NULL), newAst_VALUE (symbolVal (sflds))); - lAst = decorateType (resolveSymbols (lAst)); - rast = decorateType (resolveSymbols (createIval (lAst, sflds->type, iloop, rast))); + lAst = decorateType (resolveSymbols (lAst), RESULT_CHECK); + rast = decorateType (resolveSymbols (createIval (lAst, sflds->type, iloop, rast)), RESULT_CHECK); } if (iloop) { - werror (W_EXCESS_INITIALIZERS, "struct", - sym->opval.val->sym->name, sym->opval.val->sym->lineDef); + werrorfl (sym->opval.val->sym->fileDef, sym->opval.val->sym->lineDef, + W_EXCESS_INITIALIZERS, "struct", + sym->opval.val->sym->name); } return rast; @@ -836,9 +897,9 @@ createIvalArray (ast * sym, sym_link * type, initList * ilist) if (IS_CHAR (type->next)) if ((rast = createIvalCharPtr (sym, type, - decorateType (resolveSymbols (list2expr (ilist)))))) + decorateType (resolveSymbols (list2expr (ilist)), RESULT_CHECK)))) - return decorateType (resolveSymbols (rast)); + return decorateType (resolveSymbols (rast), RESULT_CHECK); /* not the special case */ if (ilist->type != INIT_DEEP) @@ -854,7 +915,7 @@ createIvalArray (ast * sym, sym_link * type, initList * ilist) { ast *aSym; - aSym = decorateType (resolveSymbols(sym)); + aSym = decorateType (resolveSymbols(sym), RESULT_CHECK); rast = newNode(ARRAYINIT, aSym, NULL); rast->values.constlist = literalL; @@ -871,8 +932,9 @@ createIvalArray (ast * sym, sym_link * type, initList * ilist) // Array size was specified, and we have more initializers than needed. char *name=sym->opval.val->sym->name; int lineno=sym->opval.val->sym->lineDef; + char *filename=sym->opval.val->sym->fileDef; - werror (W_EXCESS_INITIALIZERS, "array", name, lineno); + werrorfl (filename, lineno, W_EXCESS_INITIALIZERS, "array", name); } } else @@ -882,7 +944,7 @@ createIvalArray (ast * sym, sym_link * type, initList * ilist) ast *aSym; aSym = newNode ('[', sym, newAst_VALUE (valueFromLit ((float) (size++)))); - aSym = decorateType (resolveSymbols (aSym)); + aSym = decorateType (resolveSymbols (aSym), RESULT_CHECK); rast = createIval (aSym, type->next, iloop, rast); iloop = (iloop ? iloop->next : NULL); if (!iloop) @@ -897,7 +959,8 @@ createIvalArray (ast * sym, sym_link * type, initList * ilist) // there has to be a better way char *name=sym->opval.val->sym->name; int lineno=sym->opval.val->sym->lineDef; - werror (W_EXCESS_INITIALIZERS, "array", name, lineno); + char *filename=sym->opval.val->sym->fileDef; + werrorfl (filename, lineno, W_EXCESS_INITIALIZERS, "array", name); break; } @@ -910,7 +973,7 @@ createIvalArray (ast * sym, sym_link * type, initList * ilist) DCL_ELEM (type) = size; } - return decorateType (resolveSymbols (rast)); + return decorateType (resolveSymbols (rast), RESULT_CHECK); } @@ -939,8 +1002,18 @@ createIvalCharPtr (ast * sym, sym_link * type, ast * iexpr) /* to the array element */ char *s = SPEC_CVAL (iexpr->etype).v_char; int i = 0; + int size = getSize (iexpr->ftype); + int symsize = getSize (type); + + if (size>symsize) + { + if (size>(symsize+1)) + werrorfl (iexpr->filename, iexpr->lineno, W_EXCESS_INITIALIZERS, + "string", sym->opval.val->sym->name); + size = symsize; + } - while (*s) + for (i=0;itype == INIT_DEEP) ilist = ilist->init.deep; - iexpr = decorateType (resolveSymbols (list2expr (ilist))); + iexpr = decorateType (resolveSymbols (list2expr (ilist)), RESULT_CHECK); /* if character pointer */ if (IS_CHAR (type->next)) @@ -1018,9 +1084,9 @@ createIval (ast * sym, sym_link * type, initList * ilist, ast * wid) rast = createIvalType (sym, type, ilist); if (wid) - return decorateType (resolveSymbols (newNode (NULLOP, wid, rast))); + return decorateType (resolveSymbols (newNode (NULLOP, wid, rast)), RESULT_CHECK); else - return decorateType (resolveSymbols (rast)); + return decorateType (resolveSymbols (rast), RESULT_CHECK); } /*-----------------------------------------------------------------*/ @@ -1047,7 +1113,7 @@ gatherAutoInit (symbol * autoChain) /* resolve the symbols in the ival */ if (sym->ival) - resolveIvalSym (sym->ival); + resolveIvalSym (sym->ival, sym->type); /* if this is a static variable & has an */ /* initial value the code needs to be lifted */ @@ -1068,8 +1134,9 @@ gatherAutoInit (symbol * autoChain) work = initAggregates (sym, sym->ival, NULL); } else { if (getNelements(sym->type, sym->ival)>1) { - werror (W_EXCESS_INITIALIZERS, "scalar", - sym->name, sym->lineDef); + werrorfl (sym->fileDef, sym->lineDef, + W_EXCESS_INITIALIZERS, "scalar", + sym->name); } work = newNode ('=', newAst_VALUE (symbolVal (newSym)), list2expr (sym->ival)); @@ -1103,8 +1170,9 @@ gatherAutoInit (symbol * autoChain) work = initAggregates (sym, sym->ival, NULL); } else { if (getNelements(sym->type, sym->ival)>1) { - werror (W_EXCESS_INITIALIZERS, "scalar", - sym->name, sym->lineDef); + werrorfl (sym->fileDef, sym->lineDef, + W_EXCESS_INITIALIZERS, "scalar", + sym->name); } work = newNode ('=', newAst_VALUE (symbolVal (sym)), list2expr (sym->ival)); @@ -1148,12 +1216,14 @@ stringToSymbol (value * val) static int charLbl = 0; symbol *sym; set *sp; + int size; // have we heard this before? for (sp=statsg->syms; sp; sp=sp->next) { sym=sp->item; - if (sym->isstrlit && - !strcmp(SPEC_CVAL(sym->etype).v_char, SPEC_CVAL(val->etype).v_char)) { + size = getSize (sym->type); + if (sym->isstrlit && size == getSize (val->type) && + !memcmp(SPEC_CVAL(sym->etype).v_char, SPEC_CVAL(val->etype).v_char, size)) { // yes, this is old news. Don't publish it again. sym->isstrlit++; // but raise the usage count return symbolVal(sym); @@ -1232,7 +1302,7 @@ bool constExprTree (ast *cexpr) { return TRUE; } - cexpr = decorateType (resolveSymbols (cexpr)); + cexpr = decorateType (resolveSymbols (cexpr), RESULT_CHECK); switch (cexpr->type) { @@ -1296,7 +1366,7 @@ bool constExprTree (ast *cexpr) { value * constExprValue (ast * cexpr, int check) { - cexpr = decorateType (resolveSymbols (cexpr)); + cexpr = decorateType (resolveSymbols (cexpr), RESULT_CHECK); /* if this is not a constant then */ if (!IS_LITERAL (cexpr->ftype)) @@ -1532,7 +1602,7 @@ astHasSymbol (ast * tree, symbol * sym) else return FALSE; } - + return astHasSymbol (tree->left, sym) || astHasSymbol (tree->right, sym); } @@ -1684,7 +1754,7 @@ isConformingBody (ast * pbody, symbol * sym, ast * body) case '?': case ':': case SIZEOF: /* evaluate wihout code generation */ - + if (IS_AST_SYM_VALUE (pbody->left) && isSymbolEqual (AST_SYMBOL (pbody->left), sym)) return FALSE; @@ -1720,7 +1790,7 @@ isConformingBody (ast * pbody, symbol * sym, ast * body) if (astHasVolatile (pbody->left)) return FALSE; - + if (astHasDeref(pbody->right)) return FALSE; return isConformingBody (pbody->left, sym, body) && @@ -1889,7 +1959,7 @@ reverseLoop (ast * loop, symbol * sym, ast * init, ast * end) rloop)))); rloop->lineno=init->lineno; - return decorateType (rloop); + return decorateType (rloop, RESULT_CHECK); } @@ -1943,15 +2013,167 @@ searchLitOp (ast *tree, ast **parent, const char *ops) } /*-----------------------------------------------------------------*/ -/* decorateType - compute type for this tree also does type checking */ -/* this is done bottom up, since type have to flow upwards */ -/* it also does constant folding, and paramater checking */ +/* getResultFromType */ +/*-----------------------------------------------------------------*/ +RESULT_TYPE +getResultTypeFromType (sym_link *type) +{ + /* type = getSpec (type); */ + if (IS_BIT (type)) + return RESULT_TYPE_BIT; + if (IS_BITFIELD (type)) + { + int blen = SPEC_BLEN (type); + + if (blen <= 1) + return RESULT_TYPE_BIT; + if (blen <= 8) + return RESULT_TYPE_CHAR; + return RESULT_TYPE_INT; + } + if (IS_CHAR (type)) + return RESULT_TYPE_CHAR; + if ( IS_INT (type) + && !IS_LONG (type)) + return RESULT_TYPE_INT; + return RESULT_TYPE_OTHER; +} + +/*-----------------------------------------------------------------*/ +/* addCast - adds casts to a type specified by RESULT_TYPE */ /*-----------------------------------------------------------------*/ +static ast * +addCast (ast *tree, RESULT_TYPE resultType, bool upcast) +{ + sym_link *newLink; + bool upCasted = FALSE; + + switch (resultType) + { + case RESULT_TYPE_NONE: + /* char: promote to int */ + if (!upcast || + getSize (tree->etype) >= INTSIZE) + return tree; + newLink = newIntLink(); + upCasted = TRUE; + break; + case RESULT_TYPE_CHAR: + if (getSize (tree->etype) <= 1) + return tree; + newLink = newCharLink(); + break; + case RESULT_TYPE_INT: +#if 0 + if (getSize (tree->etype) > INTSIZE) + { + /* warn ("Loosing significant digits"); */ + return; + } +#endif + /* char: promote to int */ + if (!upcast || + getSize (tree->etype) >= INTSIZE) + return tree; + newLink = newIntLink(); + upCasted = TRUE; + break; + case RESULT_TYPE_OTHER: + if (!upcast) + return tree; + /* return type is long, float: promote char to int */ + if (getSize (tree->etype) >= INTSIZE) + return tree; + newLink = newIntLink(); + upCasted = TRUE; + break; + default: + return tree; + } + tree->decorated = 0; + tree = newNode (CAST, newAst_LINK (newLink), tree); + tree->lineno = tree->right->lineno; + /* keep unsigned type during cast to smaller type, + but not when promoting from char to int */ + if (!upCasted) + SPEC_USIGN (tree->left->opval.lnk) = IS_UNSIGNED (tree->right->etype) ? 1 : 0; + return decorateType (tree, resultType); +} + +/*-----------------------------------------------------------------*/ +/* resultTypePropagate - decides if resultType can be propagated */ +/*-----------------------------------------------------------------*/ +static RESULT_TYPE +resultTypePropagate (ast *tree, RESULT_TYPE resultType) +{ + switch (tree->opval.op) + { + case '=': + case '?': + case ':': + case '|': + case '^': + case '*': + case '+': + case '-': + case LABEL: + return resultType; + case '&': + if (!tree->right) + /* can be unary */ + return RESULT_TYPE_NONE; + else + return resultType; + case IFX: + return RESULT_TYPE_IFX; + default: + return RESULT_TYPE_NONE; + } +} + +/*-----------------------------------------------------------------*/ +/* getLeftResultType - gets type from left branch for propagation */ +/*-----------------------------------------------------------------*/ +static RESULT_TYPE +getLeftResultType (ast *tree, RESULT_TYPE resultType) +{ + switch (tree->opval.op) + { + case '=': + case CAST: + if (IS_PTR (LTYPE (tree))) + return RESULT_TYPE_NONE; + else + return getResultTypeFromType (LETYPE (tree)); + case RETURN: + if (IS_PTR (currFunc->type->next)) + return RESULT_TYPE_NONE; + else + return getResultTypeFromType (currFunc->type->next); + case '[': + if (!IS_ARRAY (LTYPE (tree))) + return resultType; + if (DCL_ELEM (LTYPE (tree)) > 0 && DCL_ELEM (LTYPE (tree)) <= 256) + return RESULT_TYPE_CHAR; + return resultType; + default: + return resultType; + } +} + +/*--------------------------------------------------------------------*/ +/* decorateType - compute type for this tree, also does type checking.*/ +/* This is done bottom up, since type has to flow upwards. */ +/* resultType flows top-down and forces e.g. char-arithmetik, if the */ +/* result is a char and the operand(s) are int's. */ +/* It also does constant folding, and parameter checking. */ +/*--------------------------------------------------------------------*/ ast * -decorateType (ast * tree) +decorateType (ast * tree, RESULT_TYPE resultType) { int parmNumber; sym_link *p; + RESULT_TYPE resultTypeProp; if (!tree) return tree; @@ -1983,7 +2205,7 @@ decorateType (ast * tree) /*------------------------------------------------------------------*/ /*----------------------------*/ - /* leaf has been reached */ +/* leaf has been reached */ /*----------------------------*/ lineno=tree->lineno; /* if this is of type value */ @@ -2047,10 +2269,71 @@ decorateType (ast * tree) { ast *dtl, *dtr; - dtl = decorateType (tree->left); - /* delay right side for '?' operator since conditional macro expansions might - rely on this */ - dtr = (tree->opval.op == '?' ? tree->right : decorateType (tree->right)); + #if 0 + if (tree->opval.op == NULLOP || tree->opval.op == BLOCK) + { + if (tree->left && tree->left->type == EX_OPERAND + && (tree->left->opval.op == INC_OP + || tree->left->opval.op == DEC_OP) + && tree->left->left) + { + tree->left->right = tree->left->left; + tree->left->left = NULL; + } + if (tree->right && tree->right->type == EX_OPERAND + && (tree->right->opval.op == INC_OP + || tree->right->opval.op == DEC_OP) + && tree->right->left) + { + tree->right->right = tree->right->left; + tree->right->left = NULL; + } + } + #endif + + /* Before decorating the left branch we've to decide in dependence + upon tree->opval.op, if resultType can be propagated */ + resultTypeProp = resultTypePropagate (tree, resultType); + + if (tree->opval.op == '?') + dtl = decorateType (tree->left, RESULT_TYPE_IFX); + else + dtl = decorateType (tree->left, resultTypeProp); + + /* if an array node, we may need to swap branches */ + if (tree->opval.op == '[') + { + /* determine which is the array & which the index */ + if ((IS_ARRAY (RTYPE (tree)) || IS_PTR (RTYPE (tree))) && + IS_INTEGRAL (LTYPE (tree))) + { + ast *tempTree = tree->left; + tree->left = tree->right; + tree->right = tempTree; + } + } + + /* After decorating the left branch there's type information available + in tree->left->?type. If the op is e.g. '=' we extract the type + information from there and propagate it to the right branch. */ + resultTypeProp = getLeftResultType (tree, resultTypeProp); + + switch (tree->opval.op) + { + case '?': + /* delay right side for '?' operator since conditional macro + expansions might rely on this */ + dtr = tree->right; + break; + case CALL: + /* decorate right side for CALL (parameter list) in processParms(); + there is resultType available */ + dtr = tree->right; + break; + default: + dtr = decorateType (tree->right, resultTypeProp); + break; + } /* this is to take care of situations when the tree gets rewritten */ @@ -2060,26 +2343,6 @@ decorateType (ast * tree) tree->right = dtr; if ((dtl && dtl->isError) || (dtr && dtr->isError)) return tree; - - if (IS_AST_OP(tree) && - (tree->opval.op == CAST || tree->opval.op == '=') && - (getSize(LTYPE(tree)) > getSize(RTYPE(tree))) && - (getSize(RTYPE(tree)) < (unsigned) INTSIZE)) { - // this is a cast/assign to a bigger type - if (IS_AST_OP(tree->right) && - IS_INTEGRAL(tree->right->ftype) && - (tree->right->opval.op == LEFT_OP || - tree->right->opval.op == '*' || - tree->right->opval.op == '+' || - tree->right->opval.op == '-') && - tree->right->right) { - // we should cast an operand instead of the result - tree->right->decorated = 0; - tree->right->left = newNode( CAST, newAst_LINK(newIntLink()), - tree->right->left); - tree->right = decorateType(tree->right); - } - } } /* depending on type of operator do */ @@ -2092,15 +2355,6 @@ decorateType (ast * tree) /*----------------------------*/ case '[': - /* determine which is the array & which the index */ - if ((IS_ARRAY (RTYPE (tree)) || IS_PTR (RTYPE (tree))) && IS_INTEGRAL (LTYPE (tree))) - { - - ast *tempTree = tree->left; - tree->left = tree->right; - tree->right = tempTree; - } - /* first check if this is a array or a pointer */ if ((!IS_ARRAY (LTYPE (tree))) && (!IS_PTR (LTYPE (tree)))) { @@ -2121,6 +2375,17 @@ decorateType (ast * tree) werror (E_LVALUE_REQUIRED, "array access"); goto errorTreeReturn; } + + if (IS_LITERAL (RTYPE (tree))) + { + int arrayIndex = (int) floatFromVal (valFromType (RETYPE (tree))); + int arraySize = DCL_ELEM (LTYPE (tree)); + if (arraySize && arrayIndex >= arraySize) + { + werror (W_IDX_OUT_OF_BOUNDS, arrayIndex, arraySize); + } + } + RRVAL (tree) = 1; COPYTYPE (TTYPE (tree), TETYPE (tree), LTYPE (tree)->next); return tree; @@ -2168,6 +2433,7 @@ decorateType (ast * tree) /* adjust the storage class */ switch (DCL_TYPE(tree->left->ftype)) { case POINTER: + SPEC_SCLS(TETYPE(tree)) = S_DATA; break; case FPOINTER: SPEC_SCLS(TETYPE(tree)) = S_XDATA; @@ -2176,6 +2442,7 @@ decorateType (ast * tree) SPEC_SCLS(TETYPE(tree)) = S_CODE; break; case GPOINTER: + SPEC_SCLS (TETYPE (tree)) = 0; break; case PPOINTER: SPEC_SCLS(TETYPE(tree)) = S_XSTACK; @@ -2187,11 +2454,17 @@ decorateType (ast * tree) SPEC_SCLS(TETYPE(tree)) = S_EEPROM; break; case UPOINTER: + SPEC_SCLS (TETYPE (tree)) = 0; + break; case ARRAY: case FUNCTION: break; } + /* This breaks with extern declarations, bitfields, and perhaps other */ + /* cases (gcse). Let's leave this optimization disabled for now and */ + /* ponder if there's a safe way to do this. -- EEP */ + #if 0 if (IS_ADDRESS_OF_OP (tree->left) && IS_AST_SYM_VALUE(tree->left->left) && SPEC_ABSA (AST_SYMBOL (tree->left->left)->etype)) { @@ -2224,7 +2497,8 @@ decorateType (ast * tree) tree->left = NULL; tree->right = NULL; } - + #endif + return tree; /*------------------------------------------------------------------*/ @@ -2285,11 +2559,15 @@ decorateType (ast * tree) ast *otree = optimizeGetHbit (tree); if (otree != tree) - return decorateType (otree); + return decorateType (otree, RESULT_CHECK); } - TTYPE (tree) = - computeType (LTYPE (tree), RTYPE (tree)); + tree->left = addCast (tree->left, resultType, FALSE); + tree->right = addCast (tree->right, resultType, FALSE); + TTYPE (tree) = computeType (LTYPE (tree), + RTYPE (tree), + resultType, + tree->opval.op); TETYPE (tree) = getSpec (TTYPE (tree)); /* if left is a literal exchange left & right */ @@ -2313,11 +2591,12 @@ decorateType (ast * tree) litTree->left = tree->right; tree->right = tTree; /* both operands in tTree are literal now */ - decorateType (parent); + decorateType (parent, RESULT_CHECK); } } LRVAL (tree) = RRVAL (tree) = 1; + return tree; } @@ -2333,7 +2612,7 @@ decorateType (ast * tree) goto errorTreeReturn; } - if (SPEC_SCLS (tree->left->etype) == S_REGISTER) + if (LETYPE(tree) && SPEC_SCLS (tree->left->etype) == S_REGISTER) { werror (E_ILLEGAL_ADDR, "address of register variable"); goto errorTreeReturn; @@ -2356,7 +2635,9 @@ decorateType (ast * tree) werror (E_LVALUE_REQUIRED, "address of"); goto errorTreeReturn; } - if (SPEC_SCLS (tree->left->etype) == S_CODE) + if (!LETYPE (tree)) + DCL_TYPE (p) = POINTER; + else if (SPEC_SCLS (tree->left->etype) == S_CODE) DCL_TYPE (p) = CPOINTER; else if (SPEC_SCLS (tree->left->etype) == S_XDATA) DCL_TYPE (p) = FPOINTER; @@ -2409,13 +2690,11 @@ decorateType (ast * tree) { ast *wtree = optimizeRRCRLC (tree); if (wtree != tree) - return decorateType (wtree); + return decorateType (wtree, RESULT_CHECK); wtree = optimizeSWAP (tree); if (wtree != tree) - return decorateType (wtree); - - // fall through + return decorateType (wtree, RESULT_CHECK); } /* if left is a literal exchange left & right */ @@ -2439,9 +2718,11 @@ decorateType (ast * tree) litTree->left = tree->right; tree->right = tTree; /* both operands in tTree are literal now */ - decorateType (parent); + decorateType (parent, RESULT_CHECK); } } + /* fall through */ + /*------------------------------------------------------------------*/ /*----------------------------*/ /* bitwise xor */ @@ -2483,7 +2764,8 @@ decorateType (ast * tree) /* if right is a literal and */ /* we can find a 2nd literal in a xor-tree then */ /* rearrange the tree */ - if (IS_LITERAL (RTYPE (tree))) + if (IS_LITERAL (RTYPE (tree)) && + tree->opval.op == '^') /* the same source is used by 'bitwise or' */ { ast *parent; ast *litTree = searchLitOp (tree, &parent, "^"); @@ -2493,14 +2775,20 @@ decorateType (ast * tree) litTree->left = tree->right; tree->right = tTree; /* both operands in litTree are literal now */ - decorateType (parent); + decorateType (parent, RESULT_CHECK); } } LRVAL (tree) = RRVAL (tree) = 1; + tree->left = addCast (tree->left, resultType, FALSE); + tree->right = addCast (tree->right, resultType, FALSE); TETYPE (tree) = getSpec (TTYPE (tree) = computeType (LTYPE (tree), - RTYPE (tree))); + RTYPE (tree), + resultType, + tree->opval.op)); + + return tree; /*------------------------------------------------------------------*/ /*----------------------------*/ @@ -2526,9 +2814,12 @@ decorateType (ast * tree) } LRVAL (tree) = RRVAL (tree) = 1; + TETYPE (tree) = getSpec (TTYPE (tree) = computeType (LTYPE (tree), - RTYPE (tree))); + RTYPE (tree), + resultType, + tree->opval.op)); /* if right is a literal and */ /* left is also a division by a literal then */ @@ -2548,15 +2839,15 @@ decorateType (ast * tree) litTree->right->lineno = tree->lineno; tree->right->opval.val = constVal ("1"); - decorateType (parent); + decorateType (parent, RESULT_CHECK); } else { /* litTree->left is literal: no gcse possible. - We can't call decorateType(parent), because + We can't call decorateType(parent, RESULT_CHECK), because this would cause an infinit loop. */ parent->decorated = 1; - decorateType (litTree); + decorateType (litTree, RESULT_CHECK); } } } @@ -2593,7 +2884,9 @@ decorateType (ast * tree) LRVAL (tree) = RRVAL (tree) = 1; TETYPE (tree) = getSpec (TTYPE (tree) = computeType (LTYPE (tree), - RTYPE (tree))); + RTYPE (tree), + resultType, + tree->opval.op)); return tree; /*------------------------------------------------------------------*/ @@ -2621,6 +2914,36 @@ decorateType (ast * tree) } TTYPE (tree) = copyLinkChain (LTYPE (tree)->next); TETYPE (tree) = getSpec (TTYPE (tree)); + /* adjust the storage class */ + switch (DCL_TYPE(tree->left->ftype)) { + case POINTER: + SPEC_SCLS(TETYPE(tree)) = S_DATA; + break; + case FPOINTER: + SPEC_SCLS(TETYPE(tree)) = S_XDATA; + break; + case CPOINTER: + SPEC_SCLS(TETYPE(tree)) = S_CODE; + break; + case GPOINTER: + SPEC_SCLS (TETYPE (tree)) = 0; + break; + case PPOINTER: + SPEC_SCLS(TETYPE(tree)) = S_XSTACK; + break; + case IPOINTER: + SPEC_SCLS(TETYPE(tree)) = S_IDATA; + break; + case EEPPOINTER: + SPEC_SCLS(TETYPE(tree)) = S_EEPROM; + break; + case UPOINTER: + SPEC_SCLS (TETYPE (tree)) = 0; + break; + case ARRAY: + case FUNCTION: + break; + } return tree; } @@ -2668,20 +2991,18 @@ decorateType (ast * tree) litTree->left = tree->right; tree->right = tTree; /* both operands in litTree are literal now */ - decorateType (parent); + decorateType (parent, RESULT_CHECK); } } LRVAL (tree) = RRVAL (tree) = 1; + tree->left = addCast (tree->left, resultType, FALSE); + tree->right = addCast (tree->right, resultType, FALSE); TETYPE (tree) = getSpec (TTYPE (tree) = - computeType (LTYPE (tree), - RTYPE (tree))); - - /* promote result to int if left & right are char - this will facilitate hardware multiplies 8bit x 8bit = 16bit */ - if (IS_CHAR(LETYPE(tree)) && IS_CHAR(RETYPE(tree))) { - SPEC_NOUN(TETYPE(tree)) = V_INT; - } + computeType (LTYPE (tree), + RTYPE (tree), + resultType, + tree->opval.op)); return tree; @@ -2693,7 +3014,7 @@ decorateType (ast * tree) /* if unary plus */ if (!tree->right) { - if (!IS_INTEGRAL (LTYPE (tree))) + if (!IS_ARITHMETIC (LTYPE (tree))) { werror (E_UNARY_OP, '+'); goto errorTreeReturn; @@ -2800,7 +3121,7 @@ decorateType (ast * tree) tree->opval.op = '-'; } } - decorateType (parent); + decorateType (parent, RESULT_CHECK); } } @@ -2810,9 +3131,16 @@ decorateType (ast * tree) TETYPE (tree) = getSpec (TTYPE (tree) = LTYPE (tree)); else - TETYPE (tree) = getSpec (TTYPE (tree) = - computeType (LTYPE (tree), - RTYPE (tree))); + { + tree->left = addCast (tree->left, resultType, TRUE); + tree->right = addCast (tree->right, resultType, TRUE); + TETYPE (tree) = getSpec (TTYPE (tree) = + computeType (LTYPE (tree), + RTYPE (tree), + resultType, + tree->opval.op)); + } + return tree; /*------------------------------------------------------------------*/ @@ -2909,9 +3237,15 @@ decorateType (ast * tree) TETYPE (tree) = getSpec (TTYPE (tree) = LTYPE (tree)); else - TETYPE (tree) = getSpec (TTYPE (tree) = - computeType (LTYPE (tree), - RTYPE (tree))); + { + tree->left = addCast (tree->left, resultType, TRUE); + tree->right = addCast (tree->right, resultType, TRUE); + TETYPE (tree) = getSpec (TTYPE (tree) = + computeType (LTYPE (tree), + RTYPE (tree), + resultType, + tree->opval.op)); + } LRVAL (tree) = RRVAL (tree) = 1; @@ -2952,7 +3286,7 @@ decorateType (ast * tree) tree->right = tTree; } } - decorateType (litParent); + decorateType (litParent, RESULT_CHECK); } } return tree; @@ -3051,28 +3385,44 @@ decorateType (ast * tree) return tree; } + LRVAL (tree) = RRVAL (tree) = 1; + if (tree->opval.op == LEFT_OP) + { + tree->left = addCast (tree->left, resultType, TRUE); + TETYPE (tree) = getSpec (TTYPE (tree) = + computeType (LTYPE (tree), + NULL, + resultType, + tree->opval.op)); + } + else /* RIGHT_OP */ + { + /* no promotion necessary */ + TTYPE (tree) = TETYPE (tree) = copyLinkChain (LTYPE (tree)); + if (IS_LITERAL (TTYPE (tree))) + SPEC_SCLS (TTYPE (tree)) &= ~S_LITERAL; + } + /* if only the right side is a literal & we are shifting more than size of the left operand then zero */ if (IS_LITERAL (RTYPE (tree)) && - ((unsigned) floatFromVal (valFromType (RETYPE (tree)))) >= - (getSize (LTYPE (tree)) * 8)) + ((TYPE_UDWORD) floatFromVal (valFromType (RETYPE (tree)))) >= + (getSize (TETYPE (tree)) * 8)) { if (tree->opval.op==LEFT_OP || - (tree->opval.op==RIGHT_OP && SPEC_USIGN(LETYPE(tree)))) { - lineno=tree->lineno; - werror (W_SHIFT_CHANGED, - (tree->opval.op == LEFT_OP ? "left" : "right")); - tree->type = EX_VALUE; - tree->left = tree->right = NULL; - tree->opval.val = constVal ("0"); - TETYPE (tree) = TTYPE (tree) = tree->opval.val->type; - return tree; - } + (tree->opval.op==RIGHT_OP && SPEC_USIGN(LETYPE(tree)))) + { + lineno=tree->lineno; + werror (W_SHIFT_CHANGED, + (tree->opval.op == LEFT_OP ? "left" : "right")); + tree->type = EX_VALUE; + tree->left = tree->right = NULL; + tree->opval.val = constVal ("0"); + TETYPE (tree) = TTYPE (tree) = tree->opval.val->type; + return tree; + } } - LRVAL (tree) = RRVAL (tree) = 1; - TTYPE (tree) = TETYPE (tree) = copyLinkChain (LTYPE (tree)); - if (IS_LITERAL (TTYPE (tree))) - SPEC_SCLS (TTYPE (tree)) &= ~S_LITERAL; + return tree; /*------------------------------------------------------------------*/ @@ -3090,6 +3440,23 @@ decorateType (ast * tree) /* make sure the type is complete and sane */ checkTypeSanity(LETYPE(tree), "(cast)"); + /* If code memory is read only, then pointers to code memory */ + /* implicitly point to constants -- make this explicit */ + { + sym_link *t = LTYPE(tree); + while (t && t->next) + { + if (IS_CODEPTR(t) && port->mem.code_ro) + { + if (IS_SPEC(t->next)) + SPEC_CONST (t->next) = 1; + else + DCL_PTR_CONST (t->next) = 1; + } + t = t->next; + } + } + #if 0 /* if the right is a literal replace the tree */ if (IS_LITERAL (RETYPE (tree))) { @@ -3166,7 +3533,7 @@ decorateType (ast * tree) tree->opval.val = valCastLiteral ( LTYPE (tree), element->offset - + floatFromVal (valFromType (RETYPE (tree->right->left->left))) + + floatFromVal (valFromType (RTYPE (tree->right->left->left))) ); TTYPE (tree) = tree->opval.val->type; @@ -3179,7 +3546,8 @@ decorateType (ast * tree) /* if the right is a literal replace the tree */ if (IS_LITERAL (RETYPE (tree))) { - if (IS_PTR (LTYPE (tree)) && !IS_GENPTR (LTYPE (tree)) ) { + #if 0 + if (IS_PTR (LTYPE (tree)) && !IS_GENPTR (LTYPE (tree)) ) { /* rewrite (type *)litaddr as &temp and define type at litaddr temp @@ -3202,7 +3570,7 @@ decorateType (ast * tree) sym->cdef = 1; sym->isref = 1; SPEC_STAT (sym->etype) = 1; - SPEC_ADDR(sym->etype) = floatFromVal (valFromType (RETYPE (tree))); + SPEC_ADDR(sym->etype) = floatFromVal (valFromType (RTYPE (tree))); SPEC_ABSA(sym->etype) = 1; addSym (SymbolTab, sym, sym->name, 0, 0, 0); allocGlobal (sym); @@ -3216,11 +3584,12 @@ decorateType (ast * tree) TLVAL (newTree) = 1; return newTree; } + #endif if (!IS_PTR (LTYPE (tree))) { tree->type = EX_VALUE; tree->opval.val = valCastLiteral (LTYPE (tree), - floatFromVal (valFromType (RETYPE (tree)))); + floatFromVal (valFromType (RTYPE (tree)))); TTYPE (tree) = tree->opval.val->type; tree->left = NULL; tree->right = NULL; @@ -3265,8 +3634,8 @@ decorateType (ast * tree) IS_LITERAL (LTYPE (tree))) { tree->type = EX_VALUE; - tree->opval.val = valLogicAndOr (valFromType (LETYPE (tree)), - valFromType (RETYPE (tree)), + tree->opval.val = valLogicAndOr (valFromType (LTYPE (tree)), + valFromType (RTYPE (tree)), tree->opval.op); tree->right = tree->left = NULL; TETYPE (tree) = getSpec (TTYPE (tree) = @@ -3307,7 +3676,7 @@ decorateType (ast * tree) if (compareType (LTYPE (tree), RTYPE (tree)) == 0) { werror (E_COMPARE_OP); - fprintf (stderr, "comparring type "); + fprintf (stderr, "comparing type "); printTypeChain (LTYPE (tree), stderr); fprintf (stderr, "to type "); printTypeChain (RTYPE (tree), stderr); @@ -3333,17 +3702,35 @@ decorateType (ast * tree) } } /* if unsigned value < 0 then always false */ - /* if (unsigned value) > 0 then (unsigned value) */ - if (SPEC_USIGN(LETYPE(tree)) && IS_LITERAL(RTYPE(tree)) && - ((int) floatFromVal (valFromType (RETYPE (tree)))) == 0) { - - if (tree->opval.op == '<') { + /* if (unsigned value) > 0 then '(unsigned value) ? 1 : 0' */ + if (SPEC_USIGN(LETYPE(tree)) && + !IS_CHAR(LETYPE(tree)) && /* promotion to signed int */ + IS_LITERAL(RTYPE(tree)) && + ((int) floatFromVal (valFromType (RETYPE (tree)))) == 0) + { + if (tree->opval.op == '<') + { return tree->right; - } - if (tree->opval.op == '>') { - return tree->left; - } - } + } + if (tree->opval.op == '>') + { + if (resultType == RESULT_TYPE_IFX) + { + /* the parent is an ifx: */ + /* if (unsigned value) */ + return tree->left; + } + + /* (unsigned value) ? 1 : 0 */ + tree->opval.op = '?'; + tree->right = newNode (':', + newAst_VALUE (constVal ("1")), + tree->right); /* val 0 */ + tree->right->lineno = tree->lineno; + tree->right->left->lineno = tree->lineno; + decorateType (tree->right, RESULT_CHECK); + } + } /* if they are both literal then */ /* rewrite the tree */ if (IS_LITERAL (RTYPE (tree)) && @@ -3368,8 +3755,13 @@ decorateType (ast * tree) /*----------------------------*/ case SIZEOF: /* evaluate wihout code generation */ /* change the type to a integer */ + { + int size = getSize (tree->right->ftype); + SNPRINTF(buffer, sizeof(buffer), "%d", size); + if (!size && !IS_VOID(tree->right->ftype)) + werrorfl (tree->filename, tree->lineno, E_SIZEOF_INCOMPLETE_TYPE); + } tree->type = EX_VALUE; - SNPRINTF(buffer, sizeof(buffer), "%d", (getSize (tree->right->ftype))); tree->opval.val = constVal (buffer); tree->right = tree->left = NULL; TETYPE (tree) = getSpec (TTYPE (tree) = @@ -3458,20 +3850,22 @@ decorateType (ast * tree) /*----------------------------*/ case '?': /* the type is value of the colon operator (on the right) */ - assert(IS_COLON_OP(tree->right)); + assert (IS_COLON_OP (tree->right)); /* if already known then replace the tree : optimizer will do it but faster to do it here */ - if (IS_LITERAL (LTYPE(tree))) { - if ( ((int) floatFromVal (valFromType (LETYPE (tree)))) != 0) { - return decorateType(tree->right->left) ; - } else { - return decorateType(tree->right->right) ; - } - } else { - tree->right = decorateType(tree->right); - TTYPE (tree) = RTYPE(tree); + if (IS_LITERAL (LTYPE (tree))) + { + if (((int) floatFromVal (valFromType (LETYPE (tree)))) != 0) + return decorateType (tree->right->left, resultTypeProp); + else + return decorateType (tree->right->right, resultTypeProp); + } + else + { + tree->right = decorateType (tree->right, resultTypeProp); + TTYPE (tree) = RTYPE (tree); TETYPE (tree) = getSpec (TTYPE (tree)); - } + } return tree; case ':': @@ -3482,7 +3876,8 @@ decorateType (ast * tree) goto errorTreeReturn; } - TTYPE (tree) = computeType (LTYPE (tree), RTYPE (tree)); + TTYPE (tree) = computeType (LTYPE (tree), RTYPE (tree), + resultType, tree->opval.op); TETYPE (tree) = getSpec (TTYPE (tree)); return tree; @@ -3505,11 +3900,11 @@ decorateType (ast * tree) TETYPE (tree) = getSpec (TTYPE (tree) = LTYPE (tree)); if (!tree->initMode && IS_CONSTANT (LTYPE (tree))) - werror (E_CODE_WRITE, *tree->opval.op==MUL_ASSIGN ? "*=" : "/="); + werror (E_CODE_WRITE, tree->opval.op==MUL_ASSIGN ? "*=" : "/="); if (LRVAL (tree)) { - werror (E_LVALUE_REQUIRED, *tree->opval.op==MUL_ASSIGN ? "*=" : "/="); + werror (E_LVALUE_REQUIRED, tree->opval.op==MUL_ASSIGN ? "*=" : "/="); goto errorTreeReturn; } LLVAL (tree) = 1; @@ -3564,7 +3959,9 @@ decorateType (ast * tree) RRVAL (tree) = 1; TETYPE (tree) = getSpec (TTYPE (tree) = computeType (LTYPE (tree), - RTYPE (tree))); + RTYPE (tree), + RESULT_TYPE_NOPROM, + tree->opval.op)); if (!tree->initMode && IS_CONSTANT (LETYPE (tree))) werror (E_CODE_WRITE, "-="); @@ -3605,7 +4002,9 @@ decorateType (ast * tree) RRVAL (tree) = 1; TETYPE (tree) = getSpec (TTYPE (tree) = computeType (LTYPE (tree), - RTYPE (tree))); + RTYPE (tree), + RESULT_TYPE_NOPROM, + tree->opval.op)); if (!tree->initMode && IS_CONSTANT (LETYPE (tree))) werror (E_CODE_WRITE, "+="); @@ -3616,7 +4015,7 @@ decorateType (ast * tree) goto errorTreeReturn; } - tree->right = decorateType (newNode ('+', copyAst (tree->left), tree->right)); + tree->right = decorateType (newNode ('+', copyAst (tree->left), tree->right), RESULT_CHECK); tree->opval.op = '='; return tree; @@ -3678,26 +4077,45 @@ decorateType (ast * tree) /* function call */ /*----------------------------*/ case CALL: - parmNumber = 1; - - if (processParms (tree->left, - FUNC_ARGS(tree->left->ftype), - tree->right, &parmNumber, TRUE)) { - goto errorTreeReturn; - } + + /* undo any explicit pointer derefernce; PCALL will handle it instead */ + if (IS_FUNC (LTYPE (tree)) && tree->left->type == EX_OP) + { + if (tree->left->opval.op == '*' && !tree->left->right) + tree->left = tree->left->left; + } - if ((options.stackAuto || IFFUNC_ISREENT (LTYPE (tree))) && - !IFFUNC_ISBUILTIN(LTYPE(tree))) + /* require a function or pointer to function */ + if (!IS_FUNC (LTYPE (tree)) + && !(IS_CODEPTR (LTYPE (tree)) && IS_FUNC (LTYPE (tree)->next))) { - reverseParms (tree->right); + werrorfl (tree->filename, tree->lineno, E_FUNCTION_EXPECTED); + goto errorTreeReturn; } - if (IS_CODEPTR(LTYPE(tree))) { - TTYPE(tree) = LTYPE(tree)->next->next; - } else { - TTYPE(tree) = LTYPE(tree)->next; + { + sym_link *functype; + parmNumber = 1; + + if (IS_CODEPTR(LTYPE(tree))) + functype = LTYPE (tree)->next; + else + functype = LTYPE (tree); + + if (processParms (tree->left, FUNC_ARGS(functype), + tree->right, &parmNumber, TRUE)) { + goto errorTreeReturn; + } + + if ((options.stackAuto || IFFUNC_ISREENT (functype)) && + !IFFUNC_ISBUILTIN(functype)) + { + reverseParms (tree->right); + } + + TTYPE (tree) = functype->next; + TETYPE (tree) = getSpec (TTYPE (tree)); } - TETYPE (tree) = getSpec (TTYPE (tree)); return tree; /*------------------------------------------------------------------*/ @@ -3710,7 +4128,7 @@ decorateType (ast * tree) if (compareType (currFunc->type->next, RTYPE (tree)) == 0) { - werror (W_RETURN_MISMATCH); + werrorfl (tree->filename, tree->lineno, W_RETURN_MISMATCH); printFromToType (RTYPE(tree), currFunc->type->next); goto errorTreeReturn; } @@ -3719,17 +4137,18 @@ decorateType (ast * tree) && tree->right && !IS_VOID (RTYPE (tree))) { - werror (E_FUNC_VOID); + werrorfl (tree->filename, tree->lineno, E_FUNC_VOID); goto errorTreeReturn; } - /* if there is going to be a casing required then add it */ + /* if there is going to be a casting required then add it */ if (compareType (currFunc->type->next, RTYPE (tree)) < 0) { tree->right = decorateType (newNode (CAST, - newAst_LINK (copyLinkChain (currFunc->type->next)), - tree->right)); + newAst_LINK (copyLinkChain (currFunc->type->next)), + tree->right), + RESULT_CHECK); } RRVAL (tree) = 1; @@ -3754,7 +4173,7 @@ decorateType (ast * tree) /* the switch value must be an integer */ if (!IS_INTEGRAL (LTYPE (tree))) { - werror (E_SWITCH_NON_INTEGER); + werrorfl (tree->filename, tree->lineno, E_SWITCH_NON_INTEGER); goto errorTreeReturn; } LRVAL (tree) = 1; @@ -3778,9 +4197,9 @@ decorateType (ast * tree) /*----------------------------*/ case FOR: - decorateType (resolveSymbols (AST_FOR (tree, initExpr))); - decorateType (resolveSymbols (AST_FOR (tree, condExpr))); - decorateType (resolveSymbols (AST_FOR (tree, loopExpr))); + decorateType (resolveSymbols (AST_FOR (tree, initExpr)), RESULT_CHECK); + decorateType (resolveSymbols (AST_FOR (tree, condExpr)), RESULT_CHECK); + decorateType (resolveSymbols (AST_FOR (tree, loopExpr)), RESULT_CHECK); /* if the for loop is reversible then reverse it otherwise do what we normally @@ -3799,8 +4218,13 @@ decorateType (ast * tree) AST_FOR (tree, initExpr), AST_FOR (tree, condExpr), AST_FOR (tree, loopExpr), - tree->left)); + tree->left), RESULT_CHECK); } + case PARAM: + werror (E_INTERNAL_ERROR, __FILE__, __LINE__, + "node PARAM shouldn't be processed here"); + /* but in processParams() */ + return tree; default: TTYPE (tree) = TETYPE (tree) = NULL; return tree; @@ -3822,12 +4246,15 @@ value * sizeofOp (sym_link * type) { char buff[10]; + int size; /* make sure the type is complete and sane */ checkTypeSanity(type, "(sizeof)"); /* get the size and convert it to character */ - SNPRINTF (buff, sizeof(buff), "%d", getSize (type)); + SNPRINTF (buff, sizeof(buff), "%d", size = getSize (type)); + if (!size && !IS_VOID(type)) + werror (E_SIZEOF_INCOMPLETE_TYPE); /* now convert into value */ return constVal (buff); @@ -4011,22 +4438,22 @@ createCase (ast * swStat, ast * caseVal, ast * stmnt) /* then case is out of context */ if (!swStat) { - werror (E_CASE_CONTEXT); + werrorfl (caseVal->filename, caseVal->lineno, E_CASE_CONTEXT); return NULL; } - caseVal = decorateType (resolveSymbols (caseVal)); + caseVal = decorateType (resolveSymbols (caseVal), RESULT_CHECK); /* if not a constant then error */ if (!IS_LITERAL (caseVal->ftype)) { - werror (E_CASE_CONSTANT); + werrorfl (caseVal->filename, caseVal->lineno, E_CASE_CONSTANT); return NULL; } /* if not a integer than error */ if (!IS_INTEGRAL (caseVal->ftype)) { - werror (E_CASE_NON_INTEGER); + werrorfl (caseVal->filename, caseVal->lineno, E_CASE_NON_INTEGER); return NULL; } @@ -4049,6 +4476,12 @@ createCase (ast * swStat, ast * caseVal, ast * stmnt) { pval->next = caseVal->opval.val; } + else if ((int) floatFromVal (val) == cVal) + { + werrorfl (caseVal->filename, caseVal->lineno, E_DUPLICATE_LABEL, + "case"); + return NULL; + } else { /* we found a value greater than */ @@ -4081,7 +4514,7 @@ createCase (ast * swStat, ast * caseVal, ast * stmnt) /* createDefault - creates the parse tree for the default statement */ /*-----------------------------------------------------------------*/ ast * -createDefault (ast * swStat, ast * stmnt) +createDefault (ast * swStat, ast * defaultVal, ast * stmnt) { char defLbl[SDCC_NAME_MAX + 1]; @@ -4089,7 +4522,14 @@ createDefault (ast * swStat, ast * stmnt) /* then case is out of context */ if (!swStat) { - werror (E_CASE_CONTEXT); + werrorfl (defaultVal->filename, defaultVal->lineno, E_CASE_CONTEXT); + return NULL; + } + + if (swStat->values.switchVals.swDefault) + { + werrorfl (defaultVal->filename, defaultVal->lineno, E_DUPLICATE_LABEL, + "default"); return NULL; } @@ -4360,7 +4800,7 @@ optimizeGetHbit (ast * tree) && !port->hasExtBitOp(GETHBIT, getSize (TTYPE (tree->left->left)))) return tree; - return decorateType (newNode (GETHBIT, tree->left->left, NULL)); + return decorateType (newNode (GETHBIT, tree->left->left, NULL), RESULT_CHECK); } @@ -4627,7 +5067,7 @@ optimizeCompare (ast * root) break; } - return decorateType (optExpr); + return decorateType (optExpr, RESULT_CHECK); } vleft = (root->left->type == EX_VALUE ? @@ -4701,7 +5141,7 @@ optimizeCompare (ast * root) break; } } - return decorateType (resolveSymbols (optExpr)); + return decorateType (resolveSymbols (optExpr), RESULT_CHECK); } /* end-of-if of BITVAR */ noOptimize: @@ -4847,7 +5287,8 @@ createFunction (symbol * name, ast * body) SNPRINTF (name->rname, sizeof(name->rname), "%s%s", port->fun_prefix, name->name); body = resolveSymbols (body); /* resolve the symbols */ - body = decorateType (body); /* propagateType & do semantic checks */ + body = decorateType (body, RESULT_TYPE_NONE); /* propagateType & do semantic checks */ + ex = newAst_VALUE (symbolVal (name)); /* create name */ ex = newNode (FUNCTION, ex, body); @@ -4878,7 +5319,7 @@ createFunction (symbol * name, ast * body) { GcurMemmap = statsg; codeOutFile = statsg->oFile; - eBBlockFromiCode (iCodeFromAst (decorateType (resolveSymbols (staticAutos)))); + eBBlockFromiCode (iCodeFromAst (decorateType (resolveSymbols (staticAutos), RESULT_CHECK))); staticAutos = NULL; } @@ -5002,7 +5443,7 @@ void ast_print (ast * tree, FILE *outfile, int indent) fprintf(outfile,"%u", (TYPE_UDWORD) floatFromVal(tree->opval.val)); else fprintf(outfile,"%d", (TYPE_DWORD) floatFromVal(tree->opval.val)); - fprintf(outfile,", 0x%x, %g", (TYPE_UDWORD) floatFromVal(tree->opval.val), + fprintf(outfile,", 0x%x, %f", (TYPE_UDWORD) floatFromVal(tree->opval.val), floatFromVal(tree->opval.val)); } else if (tree->opval.val->sym) { /* if the undefined flag is set then give error message */ @@ -5396,7 +5837,7 @@ void ast_print (ast * tree, FILE *outfile, int indent) ast_print(tree->left,outfile,indent+2); ast_print(tree->right,outfile,indent+2); return ; - + /*------------------------------------------------------------------*/ /*----------------------------*/ /* assignment operators */ @@ -5614,3 +6055,29 @@ void PA(ast *t) { ast_print(t,stdout,0); } + + + +/*-----------------------------------------------------------------*/ +/* astErrors : returns non-zero if errors present in tree */ +/*-----------------------------------------------------------------*/ +int astErrors(ast *t) +{ + int errors=0; + + if (t) + { + if (t->isError) + errors++; + + if (t->type == EX_VALUE + && t->opval.val->sym + && t->opval.val->sym->undefined) + errors++; + + errors += astErrors(t->left); + errors += astErrors(t->right); + } + + return errors; +}