X-Git-Url: https://git.gag.com/?a=blobdiff_plain;f=server-src%2Fdriver.c;h=947e232fa1470c96d7401fe966dee52c05dcb704;hb=fd48f3e498442f0cbff5f3606c7c403d0566150e;hp=c9f53e45fc1a86f87ac46b9c2423f57f76d2670a;hpb=1194fb66aa28d9929c3f2bef3cc6c1c3f40a60a4;p=debian%2Famanda diff --git a/server-src/driver.c b/server-src/driver.c index c9f53e4..947e232 100644 --- a/server-src/driver.c +++ b/server-src/driver.c @@ -24,7 +24,7 @@ * file named AUTHORS, in the root directory of this distribution. */ /* - * $Id: driver.c,v 1.164 2006/03/22 15:07:08 martinea Exp $ + * $Id: driver.c 6512 2007-05-24 17:00:24Z ian $ * * controlling process for the Amanda backup system */ @@ -34,8 +34,6 @@ * tape. Probably not effective though, should do this in planner. */ -/*#define HOLD_DEBUG*/ - #include "amanda.h" #include "clock.h" #include "conffile.h" @@ -44,267 +42,379 @@ #include "holding.h" #include "infofile.h" #include "logfile.h" -#include "statfs.h" -#include "version.h" +#include "fsusage.h" #include "driverio.h" #include "server_util.h" - -static disklist_t waitq, runq, tapeq, roomq; +#include "timestamp.h" + +#define driver_debug(i, ...) do { \ + if ((i) <= debug_driver) { \ + dbprintf(__VA_ARGS__); \ + } \ +} while (0) + +#define hold_debug(i, ...) do { \ + if ((i) <= debug_holding) { \ + dbprintf(__VA_ARGS__); \ + } \ +} while (0) + +static disklist_t waitq; // dle waiting estimate result +static disklist_t runq; // dle waiting to be dumped to holding disk +static disklist_t directq; // dle waiting to be dumped directly to tape +static disklist_t tapeq; // dle on holding disk waiting to be written + // to tape +static disklist_t roomq; // dle waiting for more space on holding disk static int pending_aborts; static disk_t *taper_disk; static int degraded_mode; -static unsigned long reserved_space; -static unsigned long total_disksize; +static off_t reserved_space; +static off_t total_disksize; static char *dumper_program; static char *chunker_program; static int inparallel; static int nodump = 0; -static unsigned long tape_length, tape_left = 0; -static int current_tape = 1; +static off_t tape_length = (off_t)0; +static off_t tape_left = (off_t)0; +static int current_tape = 0; static int conf_taperalgo; static int conf_runtapes; static time_t sleep_time; static int idle_reason; -static char *datestamp; -static char *timestamp; +static char *driver_timestamp; +static char *hd_driver_timestamp; static am_host_t *flushhost = NULL; static int need_degraded=0; - +static holdalloc_t *holdalloc; +static int num_holdalloc; static event_handle_t *dumpers_ev_time = NULL; static event_handle_t *schedule_ev_read = NULL; - -static void allocate_bandwidth P((interface_t *ip, int kps)); -static int assign_holdingdisk P((assignedhd_t **holdp, disk_t *diskp)); -static void adjust_diskspace P((disk_t *diskp, cmd_t cmd)); -static void delete_diskspace P((disk_t *diskp)); -static assignedhd_t **build_diskspace P((char *destname)); -static int client_constrained P((disk_t *dp)); -static void deallocate_bandwidth P((interface_t *ip, int kps)); -static void dump_schedule P((disklist_t *qp, char *str)); -static int dump_to_tape P((disk_t *dp)); -static assignedhd_t **find_diskspace P((unsigned long size, int *cur_idle, - assignedhd_t *preferred)); -static int free_kps P((interface_t *ip)); -static unsigned long free_space P((void)); -static void dumper_result P((disk_t *dp)); -static void handle_dumper_result P((void *)); -static void handle_chunker_result P((void *)); -static void handle_dumpers_time P((void *)); -static void handle_taper_result P((void *)); -static void holdingdisk_state P((char *time_str)); -static dumper_t *idle_dumper P((void)); -static void interface_state P((char *time_str)); -static int num_busy_dumpers P((void)); -static int queue_length P((disklist_t q)); -static disklist_t read_flush P((void)); -static void read_schedule P((void *cookie)); -static void short_dump_state P((void)); -static void startaflush P((void)); -static void start_degraded_mode P((disklist_t *queuep)); -static void start_some_dumps P((disklist_t *rq)); -static void continue_port_dumps(); -static void update_failed_dump_to_tape P((disk_t *)); -#if 0 -static void dump_state P((const char *str)); -#endif -int main P((int main_argc, char **main_argv)); +static int conf_flush_threshold_dumped; +static int conf_flush_threshold_scheduled; +static int conf_taperflush; +static off_t flush_threshold_dumped; +static off_t flush_threshold_scheduled; +static off_t taperflush; +static int schedule_done; // 1 if we don't wait for a + // schedule from the planner +static int force_flush; // All dump are terminated, we + // must now respect taper_flush + +static int wait_children(int count); +static void wait_for_children(void); +static void allocate_bandwidth(netif_t *ip, unsigned long kps); +static int assign_holdingdisk(assignedhd_t **holdp, disk_t *diskp); +static void adjust_diskspace(disk_t *diskp, cmd_t cmd); +static void delete_diskspace(disk_t *diskp); +static assignedhd_t **build_diskspace(char *destname); +static int client_constrained(disk_t *dp); +static void deallocate_bandwidth(netif_t *ip, unsigned long kps); +static void dump_schedule(disklist_t *qp, char *str); +static void dump_to_tape(disk_t *dp); +static assignedhd_t **find_diskspace(off_t size, int *cur_idle, + assignedhd_t *preferred); +static unsigned long free_kps(netif_t *ip); +static off_t free_space(void); +static void dumper_chunker_result(disk_t *dp); +static void dumper_taper_result(disk_t *dp); +static void file_taper_result(disk_t *dp); +static void handle_dumper_result(void *); +static void handle_chunker_result(void *); +static void handle_dumpers_time(void *); +static void handle_taper_result(void *); + +static void holdingdisk_state(char *time_str); +static dumper_t *idle_dumper(void); +static void interface_state(char *time_str); +static int queue_length(disklist_t q); +static disklist_t read_flush(void); +static void read_schedule(void *cookie); +static void short_dump_state(void); +static void startaflush(void); +static void start_degraded_mode(disklist_t *queuep); +static void start_some_dumps(disklist_t *rq); +static void continue_port_dumps(void); +static void update_failed_dump(disk_t *); + +typedef enum { + TAPE_ACTION_NO_ACTION = 0, + TAPE_ACTION_NEW_TAPE = (1 << 0), + TAPE_ACTION_NO_NEW_TAPE = (1 << 1), + TAPE_ACTION_START_A_FLUSH = (1 << 2) +} TapeAction; + +static TapeAction tape_action(char **why_no_new_tape); static const char *idle_strings[] = { #define NOT_IDLE 0 - "not-idle", + T_("not-idle"), #define IDLE_NO_DUMPERS 1 - "no-dumpers", + T_("no-dumpers"), #define IDLE_START_WAIT 2 - "start-wait", + T_("start-wait"), #define IDLE_NO_HOLD 3 - "no-hold", + T_("no-hold"), #define IDLE_CLIENT_CONSTRAINED 4 - "client-constrained", -#define IDLE_NO_DISKSPACE 5 - "no-diskspace", -#define IDLE_TOO_LARGE 6 - "file-too-large", -#define IDLE_NO_BANDWIDTH 7 - "no-bandwidth", -#define IDLE_TAPER_WAIT 8 - "taper-wait", + T_("client-constrained"), +#define IDLE_NO_BANDWIDTH 5 + T_("no-bandwidth"), +#define IDLE_NO_DISKSPACE 6 + T_("no-diskspace") }; int -main(main_argc, main_argv) - int main_argc; - char **main_argv; +main( + int argc, + char ** argv) { disklist_t origq; disk_t *diskp; int dsk; dumper_t *dumper; char *newdir = NULL; - generic_fs_stats_t fs; + struct fs_usage fsusage; holdingdisk_t *hdp; - unsigned long malloc_hist_1, malloc_size_1; - unsigned long malloc_hist_2, malloc_size_2; + identlist_t il; unsigned long reserve = 100; - char *conffile; char *conf_diskfile; cmd_t cmd; int result_argc; - char *result_argv[MAX_ARGS+1]; + char **result_argv = NULL; char *taper_program; - amwait_t retstat; char *conf_tapetype; tapetype_t *tape; + char *line; + char hostname[1025]; + intmax_t kb_avail; + config_overrides_t *cfg_ovr = NULL; + char *cfg_opt = NULL; + holdalloc_t *ha, *ha_last; + + /* + * Configure program for internationalization: + * 1) Only set the message locale for now. + * 2) Set textdomain for all amanda related programs to "amanda" + * We don't want to be forced to support dozens of message catalogs. + */ + setlocale(LC_MESSAGES, "C"); + textdomain("amanda"); safe_fd(-1, 0); - setvbuf(stdout, (char *)NULL, _IOLBF, 0); - setvbuf(stderr, (char *)NULL, _IOLBF, 0); + setvbuf(stdout, (char *)NULL, (int)_IOLBF, 0); + setvbuf(stderr, (char *)NULL, (int)_IOLBF, 0); set_pname("driver"); + dbopen(DBG_SUBDIR_SERVER); + + atexit(wait_for_children); + /* Don't die when child closes pipe */ signal(SIGPIPE, SIG_IGN); - malloc_size_1 = malloc_inuse(&malloc_hist_1); - - erroutput_type = (ERR_AMANDALOG|ERR_INTERACTIVE); - set_logerror(logerror); + add_amanda_log_handler(amanda_log_stderr); + add_amanda_log_handler(amanda_log_trace_log); startclock(); - printf("%s: pid %ld executable %s version %s\n", - get_pname(), (long) getpid(), main_argv[0], version()); + cfg_ovr = extract_commandline_config_overrides(&argc, &argv); - if (main_argc > 1) { - config_name = stralloc(main_argv[1]); - config_dir = vstralloc(CONFIG_DIR, "/", config_name, "/", NULL); - if(main_argc > 2) { - if(strncmp(main_argv[2], "nodump", 6) == 0) { - nodump = 1; - } - } + if (argc > 1) + cfg_opt = argv[1]; + set_config_overrides(cfg_ovr); + config_init(CONFIG_INIT_EXPLICIT_NAME | CONFIG_INIT_USE_CWD, cfg_opt); - } else { - char my_cwd[STR_SIZE]; + conf_diskfile = config_dir_relative(getconf_str(CNF_DISKFILE)); + read_diskfile(conf_diskfile, &origq); + disable_skip_disk(&origq); + amfree(conf_diskfile); - if (getcwd(my_cwd, sizeof(my_cwd)) == NULL) { - error("cannot determine current working directory"); - } - config_dir = stralloc2(my_cwd, "/"); - if ((config_name = strrchr(my_cwd, '/')) != NULL) { - config_name = stralloc(config_name + 1); + if (config_errors(NULL) >= CFGERR_WARNINGS) { + config_print_errors(); + if (config_errors(NULL) >= CFGERR_ERRORS) { + g_critical(_("errors processing config file")); } } - safe_cd(); + log_add(L_INFO, "%s pid %ld", get_pname(), (long)getpid()); + g_printf(_("%s: pid %ld executable %s version %s\n"), + get_pname(), (long) getpid(), argv[0], VERSION); - conffile = stralloc2(config_dir, CONFFILE_NAME); - if(read_conffile(conffile)) { - error("errors processing config file \"%s\"", conffile); + if(argc > 2) { + if(strncmp(argv[2], "nodump", 6) == 0) { + nodump = 1; + } } - amfree(conffile); - amfree(datestamp); - datestamp = construct_datestamp(NULL); - timestamp = construct_timestamp(NULL); - log_add(L_START,"date %s", datestamp); + safe_cd(); /* do this *after* config_init */ + + check_running_as(RUNNING_AS_DUMPUSER); - taper_program = vstralloc(libexecdir, "/", "taper", versionsuffix(), NULL); - dumper_program = vstralloc(libexecdir, "/", "dumper", versionsuffix(), - NULL); - chunker_program = vstralloc(libexecdir, "/", "chunker", versionsuffix(), - NULL); + dbrename(get_config_name(), DBG_SUBDIR_SERVER); - conf_taperalgo = getconf_int(CNF_TAPERALGO); + amfree(driver_timestamp); + /* read timestamp from stdin */ + while ((line = agets(stdin)) != NULL) { + if (line[0] != '\0') + break; + amfree(line); + } + if ( line == NULL ) { + error(_("Did not get DATE line from planner")); + /*NOTREACHED*/ + } + driver_timestamp = alloc(15); + strncpy(driver_timestamp, &line[5], 14); + driver_timestamp[14] = '\0'; + amfree(line); + log_add(L_START,_("date %s"), driver_timestamp); + + gethostname(hostname, SIZEOF(hostname)); + log_add(L_STATS,_("hostname %s"), hostname); + + /* check that we don't do many dump in a day and usetimestamps is off */ + if(strlen(driver_timestamp) == 8) { + if (!nodump) { + char *conf_logdir = getconf_str(CNF_LOGDIR); + char *logfile = vstralloc(conf_logdir, "/log.", + driver_timestamp, ".0", NULL); + char *oldlogfile = vstralloc(conf_logdir, "/oldlog/log.", + driver_timestamp, ".0", NULL); + if(access(logfile, F_OK) == 0 || access(oldlogfile, F_OK) == 0) { + log_add(L_WARNING, _("WARNING: This is not the first amdump run today. Enable the usetimestamps option in the configuration file if you want to run amdump more than once per calendar day.")); + } + amfree(oldlogfile); + amfree(logfile); + } + hd_driver_timestamp = get_timestamp_from_time(0); + } + else { + hd_driver_timestamp = stralloc(driver_timestamp); + } + + taper_program = vstralloc(amlibexecdir, "/", "taper", NULL); + dumper_program = vstralloc(amlibexecdir, "/", "dumper", NULL); + chunker_program = vstralloc(amlibexecdir, "/", "chunker", NULL); + + conf_taperalgo = getconf_taperalgo(CNF_TAPERALGO); conf_tapetype = getconf_str(CNF_TAPETYPE); conf_runtapes = getconf_int(CNF_RUNTAPES); tape = lookup_tapetype(conf_tapetype); - tape_length = tape->length; - printf("driver: tape size %ld\n", tape_length); - - /* taper takes a while to get going, so start it up right away */ - - init_driverio(); - if(conf_runtapes > 0) { - startup_tape_process(taper_program); - taper_cmd(START_TAPER, datestamp, NULL, 0, NULL); - } + tape_length = tapetype_get_length(tape); + g_printf("driver: tape size %lld\n", (long long)tape_length); + conf_flush_threshold_dumped = getconf_int(CNF_FLUSH_THRESHOLD_DUMPED); + conf_flush_threshold_scheduled = getconf_int(CNF_FLUSH_THRESHOLD_SCHEDULED); + conf_taperflush = getconf_int(CNF_TAPERFLUSH); - /* start initializing: read in databases */ + flush_threshold_dumped = (conf_flush_threshold_dumped * tape_length) / 100; + flush_threshold_scheduled = (conf_flush_threshold_scheduled * tape_length) / 100; + taperflush = (conf_taperflush *tape_length) / 100; - conf_diskfile = getconf_str(CNF_DISKFILE); - if (*conf_diskfile == '/') { - conf_diskfile = stralloc(conf_diskfile); - } else { - conf_diskfile = stralloc2(config_dir, conf_diskfile); - } - if (read_diskfile(conf_diskfile, &origq) < 0) - error("could not load disklist \"%s\"", conf_diskfile); - amfree(conf_diskfile); + driver_debug(1, _("flush_threshold_dumped: %lld\n"), (long long)flush_threshold_dumped); + driver_debug(1, _("flush_threshold_scheduled: %lld\n"), (long long)flush_threshold_scheduled); + driver_debug(1, _("taperflush: %lld\n"), (long long)taperflush); /* set up any configuration-dependent variables */ inparallel = getconf_int(CNF_INPARALLEL); - reserve = getconf_int(CNF_RESERVE); - - total_disksize = 0; - for(hdp = getconf_holdingdisks(), dsk = 0; hdp != NULL; hdp = hdp->next, dsk++) { - hdp->up = (void *)alloc(sizeof(holdalloc_t)); - holdalloc(hdp)->allocated_dumpers = 0; - holdalloc(hdp)->allocated_space = 0L; - - if(get_fs_stats(hdp->diskdir, &fs) == -1 - || access(hdp->diskdir, W_OK) == -1) { - log_add(L_WARNING, "WARNING: ignoring holding disk %s: %s\n", - hdp->diskdir, strerror(errno)); - hdp->disksize = 0L; + reserve = (unsigned long)getconf_int(CNF_RESERVE); + + total_disksize = (off_t)0; + ha_last = NULL; + num_holdalloc = 0; + for (il = getconf_identlist(CNF_HOLDINGDISK), dsk = 0; + il != NULL; + il = il->next, dsk++) { + hdp = lookup_holdingdisk(il->data); + ha = alloc(SIZEOF(holdalloc_t)); + num_holdalloc++; + + /* link the list in the same order as getconf_holdingdisks's results */ + ha->next = NULL; + if (ha_last == NULL) + holdalloc = ha; + else + ha_last->next = ha; + ha_last = ha; + + ha->hdisk = hdp; + ha->allocated_dumpers = 0; + ha->allocated_space = (off_t)0; + ha->disksize = holdingdisk_get_disksize(hdp); + + /* get disk size */ + if(get_fs_usage(holdingdisk_get_diskdir(hdp), NULL, &fsusage) == -1 + || access(holdingdisk_get_diskdir(hdp), W_OK) == -1) { + log_add(L_WARNING, _("WARNING: ignoring holding disk %s: %s\n"), + holdingdisk_get_diskdir(hdp), strerror(errno)); + ha->disksize = 0L; continue; } - if(fs.avail != -1) { - if(hdp->disksize > 0) { - if(hdp->disksize > fs.avail) { - log_add(L_WARNING, - "WARNING: %s: %ld KB requested, but only %ld KB available.", - hdp->diskdir, hdp->disksize, fs.avail); - hdp->disksize = fs.avail; - } - } - else if(fs.avail + hdp->disksize < 0) { + /* do the division first to avoid potential integer overflow */ + if (fsusage.fsu_bavail_top_bit_set) + kb_avail = 0; + else + kb_avail = fsusage.fsu_bavail / 1024 * fsusage.fsu_blocksize; + + if(ha->disksize > (off_t)0) { + if(ha->disksize > kb_avail) { log_add(L_WARNING, - "WARNING: %s: not %ld KB free.", - hdp->diskdir, -hdp->disksize); - hdp->disksize = 0L; - continue; + _("WARNING: %s: %lld KB requested, " + "but only %lld KB available."), + holdingdisk_get_diskdir(hdp), + (long long)ha->disksize, + (long long)kb_avail); + ha->disksize = kb_avail; } - else - hdp->disksize += fs.avail; } + /* ha->disksize is negative; use all but that amount */ + else if(kb_avail < -ha->disksize) { + log_add(L_WARNING, + _("WARNING: %s: not %lld KB free."), + holdingdisk_get_diskdir(hdp), + (long long)-ha->disksize); + ha->disksize = (off_t)0; + continue; + } + else + ha->disksize += kb_avail; - printf("driver: adding holding disk %d dir %s size %ld chunksize %ld\n", - dsk, hdp->diskdir, hdp->disksize, hdp->chunksize); + g_printf(_("driver: adding holding disk %d dir %s size %lld chunksize %lld\n"), + dsk, holdingdisk_get_diskdir(hdp), + (long long)ha->disksize, + (long long)(holdingdisk_get_chunksize(hdp))); newdir = newvstralloc(newdir, - hdp->diskdir, "/", timestamp, + holdingdisk_get_diskdir(hdp), "/", hd_driver_timestamp, NULL); if(!mkholdingdir(newdir)) { - hdp->disksize = 0L; + ha->disksize = (off_t)0; } - total_disksize += hdp->disksize; + total_disksize += ha->disksize; } - reserved_space = total_disksize * (reserve / 100.0); + reserved_space = total_disksize * (off_t)(reserve / 100); - printf("reserving %ld out of %ld for degraded-mode dumps\n", - reserved_space, free_space()); + g_printf(_("reserving %lld out of %lld for degraded-mode dumps\n"), + (long long)reserved_space, (long long)free_space()); amfree(newdir); if(inparallel > MAX_DUMPERS) inparallel = MAX_DUMPERS; + /* taper takes a while to get going, so start it up right away */ + + init_driverio(); + if(conf_runtapes > 0) { + startup_tape_process(taper_program); + taper_cmd(START_TAPER, driver_timestamp, NULL, 0, NULL); + } + /* fire up the dumpers now while we are waiting */ - if(!nodump) startup_dump_processes(dumper_program, inparallel); + if(!nodump) startup_dump_processes(dumper_program, inparallel, driver_timestamp); /* * Read schedule from stdin. Usually, this is a pipe from planner, @@ -316,84 +426,129 @@ main(main_argc, main_argv) runq.head = NULL; runq.tail = NULL; + directq.head = NULL; + directq.tail = NULL; waitq = origq; + taper_state = TAPER_STATE_DEFAULT; tapeq = read_flush(); roomq.head = roomq.tail = NULL; - log_add(L_STATS, "startup time %s", walltime_str(curclock())); + log_add(L_STATS, _("startup time %s"), walltime_str(curclock())); - printf("driver: start time %s inparallel %d bandwidth %d diskspace %lu", - walltime_str(curclock()), inparallel, free_kps((interface_t *)0), - free_space()); - printf(" dir %s datestamp %s driver: drain-ends tapeq %s big-dumpers %s\n", - "OBSOLETE", datestamp, taperalgo2str(conf_taperalgo), + g_printf(_("driver: start time %s inparallel %d bandwidth %lu diskspace %lld "), walltime_str(curclock()), inparallel, + free_kps(NULL), (long long)free_space()); + g_printf(_(" dir %s datestamp %s driver: drain-ends tapeq %s big-dumpers %s\n"), + "OBSOLETE", driver_timestamp, taperalgo2str(conf_taperalgo), getconf_str(CNF_DUMPORDER)); fflush(stdout); /* ok, planner is done, now lets see if the tape is ready */ - if(conf_runtapes > 0) { - cmd = getresult(taper, 1, &result_argc, result_argv, MAX_ARGS+1); - - if(cmd != TAPER_OK) { + if (conf_runtapes > 0) { + cmd = getresult(taper, 1, &result_argc, &result_argv); + if (cmd != TAPER_OK) { /* no tape, go into degraded mode: dump to holding disk */ - need_degraded=1; + need_degraded = 1; } - } - else { - need_degraded=1; + } else { + need_degraded = 1; } tape_left = tape_length; taper_busy = 0; + amfree(taper_input_error); + amfree(taper_tape_error); taper_disk = NULL; taper_ev_read = NULL; + + schedule_done = nodump; + force_flush = 0; + if(!need_degraded) startaflush(); if(!nodump) - schedule_ev_read = event_register(0, EV_READFD, read_schedule, NULL); + schedule_ev_read = event_register((event_id_t)0, EV_READFD, read_schedule, NULL); short_dump_state(); event_loop(0); - /* handle any remaining dumps by dumping directly to tape, if possible */ + force_flush = 1; - while(!empty(runq) && taper > 0) { + /* mv runq to directq */ + while (!empty(runq)) { diskp = dequeue_disk(&runq); - if(!degraded_mode) { - int rc = dump_to_tape(diskp); - if(rc == 1) - log_add(L_INFO, - "%s %s %d [dump to tape failed, will try again]", - diskp->host->hostname, - diskp->name, - sched(diskp)->level); - else if(rc == 2) - log_add(L_FAIL, "%s %s %s %d [dump to tape failed]", - diskp->host->hostname, - diskp->name, - sched(diskp)->datestamp, - sched(diskp)->level); + headqueue_disk(&directq, diskp); + } + + /* handle any remaining dumps by dumping directly to tape, if possible */ + while(!empty(directq) && taper > 0) { + time_t sleep_time = 100000000; + disk_t *sleep_diskp = NULL; + time_t now = time(0); + + /* Find one we can do immediately or the sonner */ + for (diskp = directq.head; diskp != NULL; diskp = diskp->next) { + if (diskp->to_holdingdisk == HOLD_REQUIRED || + degraded_mode) { + sleep_time = 0; + sleep_diskp = diskp; + } else if (diskp->host->start_t - now < sleep_time && + diskp->start_t -now < sleep_time) { + if (diskp->host->start_t > diskp->start_t) + sleep_time = diskp->host->start_t - now; + else + sleep_time = diskp->start_t - now; + sleep_diskp = diskp; + } } - else + diskp = sleep_diskp; + if (sleep_time > 0) + sleep(sleep_time); + remove_disk(&directq, diskp); + + if (diskp->to_holdingdisk == HOLD_REQUIRED) { + char *qname = quote_string(diskp->name); + log_add(L_FAIL, "%s %s %s %d [%s]", + diskp->host->hostname, qname, sched(diskp)->datestamp, + sched(diskp)->level, + _("can't dump required holdingdisk")); + amfree(qname); + } + else if (!degraded_mode) { + taper_state |= TAPER_STATE_DUMP_TO_TAPE; + dump_to_tape(diskp); + event_loop(0); + taper_state &= ~TAPER_STATE_DUMP_TO_TAPE; + } + else { + char *qname = quote_string(diskp->name); log_add(L_FAIL, "%s %s %s %d [%s]", - diskp->host->hostname, diskp->name, sched(diskp)->datestamp, + diskp->host->hostname, qname, sched(diskp)->datestamp, sched(diskp)->level, - diskp->no_hold ? - "can't dump no-hold disk in degraded mode" : - "no more holding disk space"); + num_holdalloc == 0 ? + _("can't do degraded dump without holding disk") : + diskp->to_holdingdisk != HOLD_NEVER ? + _("out of holding space in degraded mode") : + _("can't dump 'holdingdisk never' dle in degraded mode")); + amfree(qname); + } } + /* fill up the tape or start new one for taperflush */ + startaflush(); + event_loop(0); + short_dump_state(); /* for amstatus */ - printf("driver: QUITTING time %s telling children to quit\n", + g_printf(_("driver: QUITTING time %s telling children to quit\n"), walltime_str(curclock())); fflush(stdout); if(!nodump) { for(dumper = dmptable; dumper < dmptable + inparallel; dumper++) { - dumper_cmd(dumper, QUIT, NULL); + if(dumper->fd >= 0) + dumper_cmd(dumper, QUIT, NULL, NULL); } } @@ -402,86 +557,188 @@ main(main_argc, main_argv) } /* wait for all to die */ + wait_children(600); - while(1) { - char number[NUM_STR_SIZE]; - pid_t pid; - char *who; - char *what; - int code=0; - - if((pid = wait(&retstat)) == -1) { - if(errno == EINTR) continue; - else break; - } - what = NULL; - if(! WIFEXITED(retstat)) { - what = "signal"; - code = WTERMSIG(retstat); - } else if(WEXITSTATUS(retstat) != 0) { - what = "code"; - code = WEXITSTATUS(retstat); - } - who = NULL; - for(dumper = dmptable; dumper < dmptable + inparallel; dumper++) { - if(pid == dumper->pid) { - who = stralloc(dumper->name); - break; - } - } - if(who == NULL && pid == taper_pid) { - who = stralloc("taper"); - } - if(what != NULL && who == NULL) { - snprintf(number, sizeof(number), "%ld", (long)pid); - who = stralloc2("unknown pid ", number); - } - if(who && what) { - log_add(L_WARNING, "%s exited with %s %d\n", who, what, code); - printf("driver: %s exited with %s %d\n", who, what, code); - } - amfree(who); - } - - for(dumper = dmptable; dumper < dmptable + inparallel; dumper++) { - amfree(dumper->name); - } + /* cleanup */ + holding_cleanup(NULL, NULL); - for(hdp = getconf_holdingdisks(); hdp != NULL; hdp = hdp->next) { - cleanup_holdingdisk(hdp->diskdir, 0); - amfree(hdp->up); - } amfree(newdir); check_unfree_serial(); - printf("driver: FINISHED time %s\n", walltime_str(curclock())); + g_printf(_("driver: FINISHED time %s\n"), walltime_str(curclock())); fflush(stdout); - log_add(L_FINISH,"date %s time %s", datestamp, walltime_str(curclock())); - amfree(datestamp); - amfree(timestamp); + log_add(L_FINISH,_("date %s time %s"), driver_timestamp, walltime_str(curclock())); + log_add(L_INFO, "pid-done %ld", (long)getpid()); + amfree(driver_timestamp); amfree(dumper_program); amfree(taper_program); - amfree(config_dir); - amfree(config_name); + if (result_argv) + g_strfreev(result_argv); + + dbclose(); + + return 0; +} + +/* sleep up to count seconds, and wait for terminating child process */ +/* if sleep is negative, this function will not timeout */ +/* exit once all child process are finished or the timout expired */ +/* return 0 if no more children to wait */ +/* return 1 if some children are still alive */ +static int +wait_children(int count) +{ + pid_t pid; + amwait_t retstat; + char *who; + char *what; + int code=0; + dumper_t *dumper; + int wait_errno; + + do { + do { + pid = waitpid((pid_t)-1, &retstat, WNOHANG); + wait_errno = errno; + if (pid > 0) { + what = NULL; + if (! WIFEXITED(retstat)) { + what = _("signal"); + code = WTERMSIG(retstat); + } else if (WEXITSTATUS(retstat) != 0) { + what = _("code"); + code = WEXITSTATUS(retstat); + } + who = NULL; + for (dumper = dmptable; dumper < dmptable + inparallel; + dumper++) { + if (pid == dumper->pid) { + who = stralloc(dumper->name); + dumper->pid = -1; + break; + } + if (dumper->chunker && pid == dumper->chunker->pid) { + who = stralloc(dumper->chunker->name); + dumper->chunker->pid = -1; + break; + } + } + if (who == NULL && pid == taper_pid) { + who = stralloc("taper"); + taper_pid = -1; + } + if(what != NULL && who == NULL) { + who = stralloc("unknown"); + } + if(who && what) { + log_add(L_WARNING, _("%s pid %u exited with %s %d\n"), who, + (unsigned)pid, what, code); + g_printf(_("driver: %s pid %u exited with %s %d\n"), who, + (unsigned)pid, what, code); + } + amfree(who); + } + } while (pid > 0 || wait_errno == EINTR); + if (errno != ECHILD) + sleep(1); + if (count > 0) + count--; + } while ((errno != ECHILD) && (count != 0)); + return (errno != ECHILD); +} + +static void +kill_children(int signal) +{ + dumper_t *dumper; - malloc_size_2 = malloc_inuse(&malloc_hist_2); + if(!nodump) { + for(dumper = dmptable; dumper < dmptable + inparallel; dumper++) { + if (!dumper->down && dumper->pid > 1) { + g_printf(_("driver: sending signal %d to %s pid %u\n"), signal, + dumper->name, (unsigned)dumper->pid); + if (kill(dumper->pid, signal) == -1 && errno == ESRCH) { + if (dumper->chunker) + dumper->chunker->pid = 0; + } + if (dumper->chunker && dumper->chunker->pid > 1) { + g_printf(_("driver: sending signal %d to %s pid %u\n"), signal, + dumper->chunker->name, + (unsigned)dumper->chunker->pid); + if (kill(dumper->chunker->pid, signal) == -1 && + errno == ESRCH) + dumper->chunker->pid = 0; + } + } + } + } - if(malloc_size_1 != malloc_size_2) { - malloc_list(fileno(stderr), malloc_hist_1, malloc_hist_2); + if(taper_pid > 1) { + g_printf(_("driver: sending signal %d to %s pid %u\n"), signal, + "taper", (unsigned)taper_pid); + if (kill(taper_pid, signal) == -1 && errno == ESRCH) + taper_pid = 0; } +} + +static void +wait_for_children(void) +{ + dumper_t *dumper; + + if(!nodump) { + for(dumper = dmptable; dumper < dmptable + inparallel; dumper++) { + if (dumper->pid > 1 && dumper->fd >= 0) { + dumper_cmd(dumper, QUIT, NULL, NULL); + if (dumper->chunker && dumper->chunker->pid > 1 && + dumper->chunker->fd >= 0) + chunker_cmd(dumper->chunker, QUIT, NULL, NULL); + } + } + } + + if(taper_pid > 1 && taper > 0) { + taper_cmd(QUIT, NULL, NULL, 0, NULL); + } + + if(wait_children(60) == 0) + return; + + kill_children(SIGHUP); + if(wait_children(60) == 0) + return; + + kill_children(SIGKILL); + if(wait_children(-1) == 0) + return; - return 0; } static void -startaflush() +startaflush(void) { disk_t *dp = NULL; disk_t *fit = NULL; char *datestamp; - unsigned int extra_tapes = 0; - if(!degraded_mode && !taper_busy && !empty(tapeq)) { + int extra_tapes = 0; + char *qname; + TapeAction result_tape_action; + char *why_no_new_tape; + + result_tape_action = tape_action(&why_no_new_tape); + + if (result_tape_action & TAPE_ACTION_NEW_TAPE) { + taper_state &= ~TAPER_STATE_WAIT_FOR_TAPE; + taper_cmd(NEW_TAPE, NULL, NULL, 0, NULL); + } else if (result_tape_action & TAPE_ACTION_NO_NEW_TAPE) { + taper_state &= ~TAPER_STATE_WAIT_FOR_TAPE; + taper_cmd(NO_NEW_TAPE, why_no_new_tape, NULL, 0, NULL); + start_degraded_mode(&runq); + } + + if (!degraded_mode && !taper_busy && !empty(tapeq) && + (result_tape_action & TAPE_ACTION_START_A_FLUSH)) { datestamp = sched(tapeq.head)->datestamp; switch(conf_taperalgo) { @@ -491,10 +748,11 @@ startaflush() case ALGO_FIRSTFIT: fit = tapeq.head; while (fit != NULL) { - extra_tapes = (fit->tape_splitsize > 0) ? - conf_runtapes - current_tape : 0; - if(sched(fit)->act_size <= (tape_left + tape_length*extra_tapes) && - strcmp(sched(fit)->datestamp, datestamp) <= 0) { + extra_tapes = (fit->tape_splitsize > (off_t)0) ? + conf_runtapes - current_tape : 0; + if(sched(fit)->act_size <= (tape_left + + tape_length * (off_t)extra_tapes) && + strcmp(sched(fit)->datestamp, datestamp) <= 0) { dp = fit; fit = NULL; } @@ -518,9 +776,10 @@ startaflush() case ALGO_LARGESTFIT: fit = tapeq.head; while (fit != NULL) { - extra_tapes = (fit->tape_splitsize > 0) ? - conf_runtapes - current_tape : 0; - if(sched(fit)->act_size <= (tape_left + tape_length*extra_tapes) && + extra_tapes = (fit->tape_splitsize > (off_t)0) ? + conf_runtapes - current_tape : 0; + if(sched(fit)->act_size <= + (tape_left + tape_length * (off_t)extra_tapes) && (!dp || sched(fit)->act_size > sched(dp)->act_size) && strcmp(sched(fit)->datestamp, datestamp) <= 0) { dp = fit; @@ -538,8 +797,8 @@ startaflush() } if(!dp) { /* ALGO_SMALLEST, or default if nothing fit. */ if(conf_taperalgo != ALGO_SMALLEST) { - fprintf(stderr, - "driver: startaflush: Using SMALLEST because nothing fit\n"); + g_fprintf(stderr, + _("driver: startaflush: Using SMALLEST because nothing fit\n")); } fit = dp = tapeq.head; while (fit != NULL) { @@ -552,35 +811,46 @@ startaflush() if(dp) remove_disk(&tapeq, dp); } if(taper_ev_read == NULL) { - taper_ev_read = event_register(taper, EV_READFD, + taper_ev_read = event_register((event_id_t)taper, EV_READFD, handle_taper_result, NULL); } - if (dp != NULL) { + if (dp) { taper_disk = dp; taper_busy = 1; + amfree(taper_input_error); + amfree(taper_tape_error); + taper_result = LAST_TOK; + taper_sendresult = 0; + taper_first_label = NULL; + taper_written = 0; + taper_state &= ~TAPER_STATE_DUMP_TO_TAPE; + taper_dumper = NULL; + qname = quote_string(dp->name); taper_cmd(FILE_WRITE, dp, sched(dp)->destname, sched(dp)->level, - sched(dp)->datestamp); - fprintf(stderr,"driver: startaflush: %s %s %s %ld %ld\n", - taperalgo2str(conf_taperalgo), dp->host->hostname, - dp->name, sched(taper_disk)->act_size, tape_left); + sched(dp)->datestamp); + g_fprintf(stderr,_("driver: startaflush: %s %s %s %lld %lld\n"), + taperalgo2str(conf_taperalgo), dp->host->hostname, qname, + (long long)sched(taper_disk)->act_size, + (long long)tape_left); if(sched(dp)->act_size <= tape_left) tape_left -= sched(dp)->act_size; else - tape_left = 0; + tape_left = (off_t)0; + amfree(qname); } else { - error("FATAL: Taper marked busy and no work found."); + error(_("FATAL: Taper marked busy and no work found.")); /*NOTREACHED*/ } + short_dump_state(); } else if(!taper_busy && taper_ev_read != NULL) { event_release(taper_ev_read); taper_ev_read = NULL; } } - static int -client_constrained(dp) - disk_t *dp; +client_constrained( + disk_t * dp) { disk_t *dp2; @@ -605,20 +875,22 @@ client_constrained(dp) } static void -start_some_dumps(rq) - disklist_t *rq; +start_some_dumps( + disklist_t * rq) { int cur_idle; disk_t *diskp, *delayed_diskp, *diskp_accept; + disk_t *dp; assignedhd_t **holdp=NULL, **holdp_accept; const time_t now = time(NULL); cmd_t cmd; int result_argc; - char *result_argv[MAX_ARGS+1]; + char **result_argv; chunker_t *chunker; dumper_t *dumper; char dumptype; char *dumporder; + int busy_dumpers = 0; idle_reason = IDLE_NO_DUMPERS; sleep_time = 0; @@ -628,14 +900,19 @@ start_some_dumps(rq) dumpers_ev_time = NULL; } + for(dumper = dmptable; dumper < (dmptable+inparallel); dumper++) { + if( dumper->busy ) { + busy_dumpers++; + } + } + for (dumper = dmptable; dumper < dmptable+inparallel; dumper++) { - if( dumper->busy ) { + if( dumper->busy || dumper->down) { continue; } if (dumper->ev_read != NULL) { -/* assert(dumper->ev_read == NULL);*/ event_release(dumper->ev_read); dumper->ev_read = NULL; } @@ -666,7 +943,7 @@ start_some_dumps(rq) cur_idle = NOT_IDLE; dumporder = getconf_str(CNF_DUMPORDER); - if(strlen(dumporder) > (dumper-dmptable)) { + if(strlen(dumporder) > (size_t)(dumper-dmptable)) { dumptype = dumporder[dumper-dmptable]; } else { @@ -679,10 +956,6 @@ start_some_dumps(rq) for(diskp = rq->head; diskp != NULL; diskp = diskp->next) { assert(diskp->host != NULL && sched(diskp) != NULL); - /* round estimate to next multiple of DISK_BLOCK_KB */ - sched(diskp)->est_size = am_round(sched(diskp)->est_size, - DISK_BLOCK_KB); - if (diskp->host->start_t > now) { cur_idle = max(cur_idle, IDLE_START_WAIT); if (delayed_diskp == NULL || sleep_time > diskp->host->start_t) { @@ -700,12 +973,15 @@ start_some_dumps(rq) cur_idle = max(cur_idle, IDLE_NO_BANDWIDTH); } else if(sched(diskp)->no_space) { cur_idle = max(cur_idle, IDLE_NO_DISKSPACE); + } else if (diskp->to_holdingdisk == HOLD_NEVER) { + cur_idle = max(cur_idle, IDLE_NO_HOLD); } else if ((holdp = - find_diskspace(sched(diskp)->est_size,&cur_idle,NULL)) == NULL) { + find_diskspace(sched(diskp)->est_size, &cur_idle, NULL)) == NULL) { cur_idle = max(cur_idle, IDLE_NO_DISKSPACE); - } else if (diskp->no_hold) { - free_assignedhd(holdp); - cur_idle = max(cur_idle, IDLE_NO_HOLD); + if (empty(tapeq) && busy_dumpers == 0) { + remove_disk(rq, diskp); + enqueue_disk(&directq, diskp); + } } else if (client_constrained(diskp)) { free_assignedhd(holdp); cur_idle = max(cur_idle, IDLE_CLIENT_CONSTRAINED); @@ -727,7 +1003,7 @@ start_some_dumps(rq) break; case 'B': accept = (sched(diskp)->est_kps > sched(diskp_accept)->est_kps); break; - default: log_add(L_WARNING, "Unknown dumporder character \'%c\', using 's'.\n", + default: log_add(L_WARNING, _("Unknown dumporder character \'%c\', using 's'.\n"), dumptype); accept = (sched(diskp)->est_size < sched(diskp_accept)->est_size); break; @@ -753,6 +1029,10 @@ start_some_dumps(rq) holdp = holdp_accept; idle_reason = max(idle_reason, cur_idle); + if (diskp == NULL && idle_reason == IDLE_NO_DISKSPACE) { + /* continue flush waiting for new tape */ + startaflush(); + } /* * If we have no disk at this point, and there are disks that @@ -762,11 +1042,11 @@ start_some_dumps(rq) if (diskp == NULL && delayed_diskp != NULL) { assert(sleep_time > now); sleep_time -= now; - dumpers_ev_time = event_register(sleep_time, EV_TIME, + dumpers_ev_time = event_register((event_id_t)sleep_time, EV_TIME, handle_dumpers_time, &runq); return; } else if (diskp != NULL) { - sched(diskp)->act_size = 0; + sched(diskp)->act_size = (off_t)0; allocate_bandwidth(diskp->host->netif, sched(diskp)->est_kps); sched(diskp)->activehd = assign_holdingdisk(holdp, diskp); amfree(holdp); @@ -776,42 +1056,77 @@ start_some_dumps(rq) diskp->inprogress = 1; sched(diskp)->dumper = dumper; sched(diskp)->timestamp = now; + amfree(diskp->dataport_list); - dumper->ev_read = event_register(dumper->fd, EV_READFD, - handle_dumper_result, dumper); dumper->busy = 1; /* dumper is now busy */ dumper->dp = diskp; /* link disk to dumper */ remove_disk(rq, diskp); /* take it off the run queue */ - sched(diskp)->origsize = -1; - sched(diskp)->dumpsize = -1; - sched(diskp)->dumptime = -1; - sched(diskp)->tapetime = -1; + sched(diskp)->origsize = (off_t)-1; + sched(diskp)->dumpsize = (off_t)-1; + sched(diskp)->dumptime = (time_t)0; + sched(diskp)->tapetime = (time_t)0; chunker = dumper->chunker; chunker->result = LAST_TOK; dumper->result = LAST_TOK; startup_chunk_process(chunker,chunker_program); + chunker_cmd(chunker, START, NULL, driver_timestamp); chunker->dumper = dumper; - chunker_cmd(chunker, PORT_WRITE, diskp); - cmd = getresult(chunker->fd, 1, &result_argc, result_argv, MAX_ARGS+1); + chunker_cmd(chunker, PORT_WRITE, diskp, NULL); + cmd = getresult(chunker->fd, 1, &result_argc, &result_argv); if(cmd != PORT) { - printf("driver: did not get PORT from %s for %s:%s\n", - chunker->name, diskp->host->hostname, diskp->name); - fflush(stdout); - return ; /* fatal problem */ - } - chunker->ev_read = event_register(chunker->fd, EV_READFD, - handle_chunker_result, chunker); - dumper->output_port = atoi(result_argv[2]); + assignedhd_t **h=NULL; + int activehd; + char *qname = quote_string(diskp->name); - dumper_cmd(dumper, PORT_DUMP, diskp); + g_printf(_("driver: did not get PORT from %s for %s:%s\n"), + chunker->name, diskp->host->hostname, qname); + amfree(qname); + fflush(stdout); + deallocate_bandwidth(diskp->host->netif, sched(diskp)->est_kps); + h = sched(diskp)->holdp; + activehd = sched(diskp)->activehd; + h[activehd]->used = 0; + h[activehd]->disk->allocated_dumpers--; + adjust_diskspace(diskp, DONE); + delete_diskspace(diskp); + diskp->host->inprogress--; + diskp->inprogress = 0; + sched(diskp)->dumper = NULL; + dumper->busy = 0; + dumper->dp = NULL; + sched(diskp)->dump_attempted++; + free_serial_dp(diskp); + if(sched(diskp)->dump_attempted < 2) + enqueue_disk(rq, diskp); + } + else { + dumper->ev_read = event_register((event_id_t)dumper->fd, EV_READFD, + handle_dumper_result, dumper); + chunker->ev_read = event_register((event_id_t)chunker->fd, EV_READFD, + handle_chunker_result, chunker); + dumper->output_port = atoi(result_argv[1]); + amfree(diskp->dataport_list); + diskp->dataport_list = stralloc(result_argv[2]); + + if (diskp->host->pre_script == 0) { + for (dp=diskp->host->disks; dp != NULL; dp = dp->hostnext) { + run_server_scripts(EXECUTE_ON_PRE_HOST_BACKUP, + get_config_name(), dp, -1); + } + diskp->host->pre_script = 1; + } + run_server_scripts(EXECUTE_ON_PRE_DLE_BACKUP, + get_config_name(), diskp, + sched(diskp)->level); + dumper_cmd(dumper, PORT_DUMP, diskp, NULL); + } diskp->host->start_t = now + 15; - } else if (/* cur_idle != NOT_IDLE && */ - (num_busy_dumpers() > 0 || taper_busy)) { - /* - * We are constrained. - */ + + if (result_argv) + g_strfreev(result_argv); + short_dump_state(); } } } @@ -821,9 +1136,10 @@ start_some_dumps(rq) * be because a disk has a delayed start, or amanda is constrained * by network or disk limits. */ + static void -handle_dumpers_time(cookie) - void *cookie; +handle_dumpers_time( + void * cookie) { disklist_t *runq = cookie; event_release(dumpers_ev_time); @@ -832,43 +1148,44 @@ handle_dumpers_time(cookie) } static void -dump_schedule(qp, str) - disklist_t *qp; - char *str; +dump_schedule( + disklist_t *qp, + char * str) { disk_t *dp; + char *qname; - printf("dump of driver schedule %s:\n--------\n", str); + g_printf(_("dump of driver schedule %s:\n--------\n"), str); for(dp = qp->head; dp != NULL; dp = dp->next) { - printf(" %-20s %-25s lv %d t %5ld s %8lu p %d\n", - dp->host->hostname, dp->name, sched(dp)->level, - sched(dp)->est_time, sched(dp)->est_size, sched(dp)->priority); + qname = quote_string(dp->name); + g_printf(" %-20s %-25s lv %d t %5lu s %lld p %d\n", + dp->host->hostname, qname, sched(dp)->level, + sched(dp)->est_time, + (long long)sched(dp)->est_size, sched(dp)->priority); + amfree(qname); } - printf("--------\n"); + g_printf("--------\n"); } static void -start_degraded_mode(queuep) - disklist_t *queuep; +start_degraded_mode( + /*@keep@*/ disklist_t *queuep) { disk_t *dp; disklist_t newq; - unsigned long est_full_size; - - if (taper_ev_read != NULL) { - event_release(taper_ev_read); - taper_ev_read = NULL; - } + off_t est_full_size; + char *qname; newq.head = newq.tail = 0; - dump_schedule(queuep, "before start degraded mode"); + dump_schedule(queuep, _("before start degraded mode")); - est_full_size = 0; + est_full_size = (off_t)0; while(!empty(*queuep)) { dp = dequeue_disk(queuep); + qname = quote_string(dp->name); if(sched(dp)->level != 0) /* go ahead and do the disk as-is */ enqueue_disk(&newq, dp); @@ -881,27 +1198,30 @@ start_degraded_mode(queuep) else if(sched(dp)->degr_level != -1) { sched(dp)->level = sched(dp)->degr_level; sched(dp)->dumpdate = sched(dp)->degr_dumpdate; - sched(dp)->est_size = sched(dp)->degr_size; + sched(dp)->est_nsize = sched(dp)->degr_nsize; + sched(dp)->est_csize = sched(dp)->degr_csize; sched(dp)->est_time = sched(dp)->degr_time; sched(dp)->est_kps = sched(dp)->degr_kps; enqueue_disk(&newq, dp); } else { - log_add(L_FAIL,"%s %s %s %d [can't switch to incremental dump]", - dp->host->hostname, dp->name, sched(dp)->datestamp, - sched(dp)->level); + log_add(L_FAIL, "%s %s %s %d [%s]", + dp->host->hostname, qname, sched(dp)->datestamp, + sched(dp)->level, sched(dp)->degr_mesg); } } + amfree(qname); } - *queuep = newq; + /*@i@*/ *queuep = newq; degraded_mode = 1; - dump_schedule(queuep, "after start degraded mode"); + dump_schedule(queuep, _("after start degraded mode")); } -static void continue_port_dumps() +static void +continue_port_dumps(void) { disk_t *dp, *ndp; assignedhd_t **h; @@ -912,16 +1232,20 @@ static void continue_port_dumps() for( dp = roomq.head; dp; dp = ndp ) { ndp = dp->next; /* find last holdingdisk used by this dump */ - for( i = 0, h = sched(dp)->holdp; h[i+1]; i++ ); + for( i = 0, h = sched(dp)->holdp; h[i+1]; i++ ) { + (void)h; /* Quiet lint */ + } /* find more space */ h = find_diskspace( sched(dp)->est_size - sched(dp)->act_size, &active_dumpers, h[i] ); if( h ) { for(dumper = dmptable; dumper < dmptable + inparallel && - dumper->dp != dp; dumper++); + dumper->dp != dp; dumper++) { + (void)dp; /* Quiet lint */ + } assert( dumper < dmptable + inparallel ); sched(dp)->activehd = assign_holdingdisk( h, dp ); - chunker_cmd( dumper->chunker, CONTINUE, dp ); + chunker_cmd( dumper->chunker, CONTINUE, dp, NULL ); amfree(h); remove_disk( &roomq, dp ); } @@ -932,15 +1256,11 @@ static void continue_port_dumps() * a) diskspace has been allocated for other dumps which are * still running or already being written to tape * b) all other dumps have been suspended due to lack of diskspace - * c) this dump doesn't fit on all the holding disks * Case a) is not a problem. We just wait for the diskspace to * be freed by moving the current disk to a queue. * If case b) occurs, we have a deadlock situation. We select * a dump from the queue to be aborted and abort it. It will - * be retried later dumping to disk. - * If case c) is detected, the dump is aborted. Next time - * it will be dumped directly to tape. Actually, case c is a special - * manifestation of case b) where only one dumper is busy. + * be retried directly to tape. */ for(dp=NULL, dumper = dmptable; dumper < (dmptable+inparallel); dumper++) { if( dumper->busy ) { @@ -955,162 +1275,254 @@ static void continue_port_dumps() } if((dp != NULL) && (active_dumpers == 0) && (busy_dumpers > 0) && ((!taper_busy && empty(tapeq)) || degraded_mode) && - pending_aborts == 0 ) { /* not case a */ - if( busy_dumpers == 1 ) { /* case c */ - sched(dp)->no_space = 1; - } - /* case b */ + pending_aborts == 0 ) { /* case b */ + sched(dp)->no_space = 1; /* At this time, dp points to the dump with the smallest est_size. * We abort that dump, hopefully not wasting too much time retrying it. */ remove_disk( &roomq, dp ); - chunker_cmd( sched(dp)->dumper->chunker, ABORT, NULL ); - dumper_cmd( sched(dp)->dumper, ABORT, NULL ); + chunker_cmd(sched(dp)->dumper->chunker, ABORT, NULL, _("Not enough holding disk space")); + dumper_cmd( sched(dp)->dumper, ABORT, NULL, _("Not enough holding disk space")); pending_aborts++; } } static void -handle_taper_result(void *cookie) +handle_taper_result( + void *cookie G_GNUC_UNUSED) { disk_t *dp; - int filenum; cmd_t cmd; int result_argc; - char *result_argv[MAX_ARGS+1]; - int avail_tapes = 0; - + char **result_argv; + char *qname, *q; + char *s; + assert(cookie == NULL); + amfree(taper_input_error); + amfree(taper_tape_error); do { short_dump_state(); - cmd = getresult(taper, 1, &result_argc, result_argv, MAX_ARGS+1); + cmd = getresult(taper, 1, &result_argc, &result_argv); switch(cmd) { - case PARTIAL: - case DONE: /* DONE